Skip to content

feat: monitor pull requests across source providers - #5305

Merged
chenmingwei23 merged 2 commits into
mainfrom
token-monitors-source-providers
Sep 12, 2026
Merged

chenmingwei23 merged 2 commits into
mainfrom
token-monitors-source-providers

Conversation

@kyleseaman

@kyleseaman kyleseaman commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Stacked change: PR 8 of 8

Stack: #5180 → #5181 → #5182 → #5183 → #5184 → #5185 → #5186 → #5305
Base: main (includes merged #5186)

Problem / Motivation

Structured babysit monitoring currently understands GitHub pull requests only. GitLab merge requests, Azure DevOps pull requests, and Bitbucket pull requests must fall back to prompt-owned polling, which spends agent turns even when review state is unchanged.

Why it matters

Teams using another source provider should get the same bounded, restart-safe, zero-turn monitoring behavior without granting an agent broad credentials or trusting provider payloads as instructions.

What changed (motivation → approach → change)

  • Define one provider-neutral review-readiness contract, then normalize GitHub, GitLab, Azure DevOps Services, and Bitbucket Cloud into that bounded state.

  • Add strict target parsers that reject credential-shaped canonical path text before persistence, plus provider-specific probes with constrained credentials, streaming output limits, bounded pagination, canonical output, and fail-closed incomplete-state handling.

  • Extend the monitor tool schema, persistence, public projection, REST flow, dashboard normalization, and babysit guidance to the new source-provider kinds.

  • Re-audit the monitor RFC against all eight implementation PRs and mark the still-open stack as in progress rather than draft.

  • Support GitLab.com and explicitly configured self-managed GitLab hosts, including custom ports; support Azure DevOps Services at dev.azure.com and Bitbucket Cloud at bitbucket.org.

  • Normalize common provider URL suffixes plus copied-link query strings and fragments in the dashboard, distinguish empty and invalid URLs from provider-changing edits, and render GitLab allowlist guidance pointing to config.json only for the backend-specific error code.

  • Keep retained terminal records read-only with Restart as the sole dashboard mutation; reject the retired replacement field until bulk slot cleanup fences every slot before awaiting.

  • Keep sparse non-target edits independent of target parsing so older malformed persisted targets do not crash unrelated saves.

  • Keep unchanged probes at zero agent turns and deduplicate actionable wakes by a stable provider-neutral fingerprint.

  • Retain the finite legacy path when readiness depends on generic PR comments or advisory findings outside canonical review/check facts.

  • Read only the newest current-head GitLab pipeline so a successful retry supersedes an older failed run, and map GitLab requested changes to the shared actionable review decision.

  • Apply provider CLI resource limits after exec through the repository spawn shim, avoiding Python work in a threaded fork child.

  • Confine host Azure CLI configuration and extension visibility to protected HOME/.azure; pod mode accepts only its credential-scrubbed disposable home.

  • Scrub Azure DevOps and Bitbucket credentials from isolated pod environments while retaining only the pod model and owner credentials.

  • Keep startup warnings credential-safe by reporting missing source-provider configuration without enumerating credential key identifiers in logs.

  • Inherit feat: show bounded monitors in the dashboard #5185's shared ErrorNotice handling for monitor failures, preserving unsaved drafts and provider-specific guidance without navigating away.

  • Correct the RFC to distinguish transient probe summaries from persisted classification/reason fields.

  • Preserve Bitbucket status-page completeness in canonical evidence independently of task pagination; incomplete statuses stay pending through the shared readiness contract.

  • Inherit feat: show bounded monitors in the dashboard #5185's guarded terminal reconnect-cache refresh, including older cached absence and predecessor monitor/legacy IDs, so stopped monitors remain inspectable after reconnect.

  • Render terminal notifications from the stored stop reason: state closed-unmerged PRs directly, distinguish merged from ready-for-review success, name known provider/delivery blockers, and identify the watched PR URL even for channel-bound watches. Unknown reasons retain a safe details fallback; unavailable conversations point to a new watch from an active conversation.

  • Audit revoked GitLab hosts and incomplete Bitbucket credentials as credential-free denials before any provider request; a failed audit writer never permits the denied request.

  • Correct the RFC: dashboard creation cannot replace retained records, and explicit restart checks the terminal record identity and configuration generation.

Tests

  • Focused backend tests covering monitor tools, targets, provider semantics including GitLab requested changes, pagination, bounded CLI execution, persistence, projections, credentials, controller behavior, slot-close/replacement concurrency, and the per-file coverage floor
  • Focused frontend tests covering REST and WebSocket normalization, provider inference, URL canonicalization, error guidance, strict public state, and monitor controls
  • TypeScript, focused ESLint, Python type/lint/import checks, Black baseline, documentation, diff-scoped i18n, brand, scrub, portability, and diff checks
  • Production build and fresh analyze-build gate pass: all 810 chunks within budget. Retain main's updated English-catalog ceiling; first-party code chunk budgets are unchanged

Previous composed-stack verification passed 145 focused frontend tests, TypeScript, focused ESLint, production analyze build, and the 810-chunk bundle gate. Those frontend files are unchanged by this notification-copy follow-up.

A separate, earlier cron-dedup Windows failure (not the latest notification regression) was classified as pre-existing: the cron dedup test and relevant production files are unchanged from main, and a fixed-clock local diagnostic reproduces the identical 1 != 2 failure. No CI rerun or unrelated cron change was made.

Previous composed-stack verification: 120 focused backend tests pass (72 provider transport/semantics tests, 16 shared-readiness tests, and 32 notification/observer tests). The notification fix is owned by #5186: it uses the recorded stop reason, distinguishes merged from review-ready success, and includes the target PR URL. Denial regressions still exercise real SEL records and unavailable writers without permitting provider requests. Focused Linux-platform mypy, Black, flake8, isort, docs lint, brand, and diff checks pass. GPT and Opus found no blockers on the preceding audit-fix head; fresh CI and review verdicts are required after this restack. No manual CI rerun was made.

Previous import follow-up: inherit #5186's terminal-notification redaction fix and preserve its ungated finite fallback recipe. Restore lazy target-parser and exception imports in dashboard monitor mutation paths: module-scope target imports eagerly loaded the GitHub provider even with monitoring disabled. The existing cold-gateway regression reproduced locally and failed on both Windows and Linux CI, then passed with this correction. All 187 focused backend tests pass across gateway initialization, notification redaction, babysit, tool acknowledgement, source-provider probes, directive application, and dashboard handlers. Linux-targeted handler mypy, Black, isort, flake8, docs lint, brand, and diff checks pass. Screenshot bytes are unchanged. Fresh CI and reviews are pending on ec16b57f7a414fb4dca6d91c60b852697584e472; no manual CI rerun was made.

The preceding head's Linux backend-shard failure was classified as a pre-existing Job SDK test race: test_live_while_a_registered_thread_runs waits for the durable terminal record, then checks the live table before the worker necessarily removes its entry. The test and apps/job_sdk.py are byte-identical to the local main snapshot; the coverage gate failed downstream because that shard failed. No unrelated Job SDK change or manual CI rerun was made.

Latest main-restack verification on 00710aaa538dbb4d4df38c550213352ee044f7a2: all 229 focused backend tests and 145 focused frontend tests passed, along with TypeScript compilation, docs lint, Black and flake8 on the resolved handler, and diff checks. The close-slot conflict preserves main's replacement-slot safety and this layer's monitor-admission fence. Screenshot bytes are unchanged. Fresh CI and reviews are pending; no manual CI rerun was made.

Manual verification

Rendered the dashboard automation popover locally and verified that the pull-request field identifies GitHub.com, GitLab, Azure DevOps Services, and Bitbucket Cloud.

Screenshots / video

The immutable screenshot illustrates the normal form, not the error-notice states covered by the component tests.

Dashboard monitor form naming GitHub.com, GitLab, Azure DevOps Services, and Bitbucket Cloud support

Related Issues

Part 8 of GitHub stack #5275. Stacked on #5186 and extends the monitor RFC introduced by #5180.

Checklist

  • Commit count satisfies the stacked PR hygiene limit
  • Existing tests pass and new tests cover the new behavior
  • Self-review completed; code follows project style guidelines
  • Documentation updated where applicable
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

N/A — the repository template does not yet supply final CLA wording.

Current rebuild verification on fa8c67e2c: rebuild the two source-provider commits from their clean pre-restack versions on corrected #5186, restoring the full dashboard handler tail and preserving the close-slot monitor-admission fence. All 680 focused backend tests pass; Linux-targeted handler mypy, Black, and flake8 pass. The two focused frontend files pass all 122 tests and TypeScript compilation passes. The inherited #5186 verification also passes all 300 focused tests plus docs lint. Screenshot bytes are unchanged. Fresh CI and reviews are pending; no manual CI rerun was made.

Current main-restack verification on 7352b2932fe0e0f978a3d8a765debd333abb5137: this top layer is one commit directly based on #5186 at c0056fdc0b4457f148876457c528985aeae0b1d9, preserving the eight-PR linear stack. The CodeQL credential-identifier logging finding is fixed and its regression coverage passes. The composed stack passes all 2,430 changed backend tests and all 101 focused sidebar/popover frontend tests; TypeScript compilation and the production frontend build also pass. Screenshot bytes and its immutable URL are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current security/restack verification on 2870dc748af24eb9931bf545a1d984454c33e614: this top layer is directly based on #5186 at 3b5f883a3721d35179b1b7d7caeb14c8df6dd317. Channel-bound Bitbucket probes never load gateway-owner credentials and use anonymous HTTPS; channel-bound Azure probes fail closed without reading the operator credential store or Azure CLI login state. Dashboard-bound credential behavior is preserved. The four new regressions pass within all 446 focused controller, provider, AutoNudge, and Slack gateway tests; focused Linux mypy, flake8, Black, and docs lint pass. Screenshot bytes and its immutable URL are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current credential-contract verification on 2ec2f953823b0c070b3a4a263b591dca55c49cf9: every source-provider probe now receives explicit owner-credential authority, and unlisted channel providers fail closed by default. GitHub and host-authorized GitLab retain their documented ambient CLI identity; Azure records a credential-free SEL denial before returning authorization failure, and Bitbucket remains anonymous in channels. All 277 focused provider, controller, and babysit tests pass; focused Linux mypy, flake8, Black, docs lint, and diff checks pass. Screenshot bytes and its immutable URL are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current rollback-fence verification on 2ec2f953823b0c070b3a4a263b591dca55c49cf9: failed slot closes retain the monitor-admission fence through every awaited rollback and release it only in the outer close finalizer, preventing a concurrent monitor from being overwritten by restoration. The new app-close regression failed before the fix and passes afterward; all 37 focused slot-close and monitor-directive tests pass, with focused Black, isort, flake8, Linux mypy, and diff checks clean. Screenshot bytes are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on c53426d879658ff1bc6e0ccf03eaeebe29878399: this two-commit top layer is directly based on #5186 at b2e22498966e2c2aa4f016e85426a5facb616c6f. The source-provider conflict preserves main’s tagged-refusal rule while normalizing GitHub, GitLab, Azure DevOps, and Bitbucket targets before monitor creation; invalid kind/target pairs return a refusal without publishing a directive. All 373 focused backend tests and all 218 focused frontend tests pass, along with TypeScript compilation, focused Black, and flake8. Screenshot bytes and its immutable URL are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current review-fix/restack verification on 950a2a9da33e0db15bd537f727c5879faa05a7ad: this two-commit top layer is directly based on #5186 at e8ddb34e3211e8c417dabfa0b543773d0bec72a9, preserving the linear stack. The composed 51-test automation-popover suite, TypeScript compilation, targeted ESLint, all 19 monitor MCP tests, focused Black, and docs lint pass. The inherited Remote Crew failures reproduce unchanged locally and no open PR layer changes those files; the isolated Mochi test passes locally. Screenshot bytes and its immutable URL are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on fb237a0e055a79e3506f8e4d22c0ffa05a5477fe: this two-commit top layer is directly based on #5186 at 7e2a294b73b34eb5e9300a8a5755c03ea0884c1f, preserving the linear stack. Locale conflict resolution combines main’s catalog changes with the provider-specific monitor additions without overlapping values. The composed top passes 125 focused frontend tests, TypeScript compilation, all 19 i18n gates against origin/main, 117 focused monitor/provider tests, and docs lint. Screenshot bytes and its immutable URL are unchanged. Fresh CI and reviews are running; no manual CI rerun was made.

Current review-fix/restack verification on 8e9bf26: this two-commit top layer is directly based on #5186 at edc01d9, preserving the linear stack. The form conflict preserves provider-specific validation and errors together with #5185's per-slot draft/error retention and persistent shared trigger. The composed top passes 284 focused backend tests and 160 focused frontend tests, plus TypeScript, targeted ESLint, all 19 i18n gates, and docs lint. The screenshot URL now names this current top commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current hygiene-clean verification on 8e9bf26: this PR is exactly two commits and is directly based on #5186 at 51f975e. Its tree is byte-for-byte identical to the already verified pre-fold top; the screenshot URL now names this current commit. No CI job was manually rerun.

Current inherited-fix restack verification on 8e9bf26: this two-commit top layer is directly based on #5186 at 03cb97f, preserving the linear open tail. The only tree delta from the prior top is #5185’s non-finite quarantine fix, its regression, and matching specification update. All 285 focused monitor, MCP, GitHub, and source-provider tests pass. The screenshot URL now names this current top commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current security-fix/restack verification on 548cf72: autonomous glab and az monitor probes now require a canonical system-owned executable chain that the gateway user cannot rewrite, independent of the relaxed policy for interactive provider surfaces, so an agent-planted provider binary cannot receive ambient login material or an invocation-scoped token. The regression failed on the prior head and passes with the fix. All 924 focused provider and runner tests pass on the fixed tree; after the final main restack, the two security-path regressions, focused flake8, Linux mypy, docs lint, TypeScript, the analyze build, the 812-chunk bundle gate, and all 19 base-aware i18n checks pass. The two-commit shape and direct #5186 base are preserved; the screenshot URL now names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on 548cf72: this two-commit top layer is directly based on #5186 at e444ec9, preserving the linear open tail on main at 6309382. The GitHub probe resolution retains the shared readiness builder and consolidated provider-exception classification, and the protected-executable requirement for autonomous glab and az probes remains intact. The composed top passes 1,013 focused backend tests, 145 focused dashboard/WebSocket tests, TypeScript, all 19 i18n gates, docs lint, focused flake8 and Linux mypy, the analyze build, and the 812-chunk bundle gate. Screenshot bytes are unchanged and the immutable URL names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current inherited-fix restack verification on 548cf72: this two-commit top is directly based on #5186 at 2ea5aa6 and inherits its concrete monitor_start URL example without changing this layer’s patch. All 92 focused guidance, babysit, controller, and monitor-MCP tests plus docs lint and diff checks pass. The previous Linux shard 4 snapshot failures are pre-existing ordering races outside this stack; coverage failed downstream. Screenshot bytes are unchanged and the immutable URL names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current inherited source-path fix on ad59854: this two-commit top is directly based on #5186 at 3389378 and inherits its resolved repository-root test paths without changing this layer’s patch. All 502 focused babysit and monitor tests pass, along with docs lint. The completed Linux shard 4 failure on the prior head is the pre-existing notification snapshot ordering race outside this stack; PR readiness still passed. Screenshot bytes are unchanged and the immutable URL now names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current inherited source-path gate fix on 548cf72: this two-commit top is directly based on #5186 at f904536 and inherits its resolved, Black-clean repository-root test paths without changing this layer’s patch. All 502 focused babysit and monitor tests pass, plus focused Black and docs lint. The prior top’s surface detection, coverage, screenshot, UX, and GPT failures were GitHub App API-rate-limit failures or downstream consequences. Screenshot bytes are unchanged and the immutable URL now names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current linked-channel credential-fence verification on eb09468: this two-commit top layer is directly based on #5186 at f904536. Monitor records now persist their authenticated creation surface independently of the storage slot, and Slack-linked immediate, queued, and recovery turns retain channel provenance. Azure DevOps and Bitbucket probes therefore cannot receive dashboard-owner credentials through a bare linked chat binding; legacy records without provenance fail closed outside the explicit GitHub/GitLab channel allowlist. All 329 focused monitor/provider tests and 246 focused messaging/directive/queue tests pass, plus Black, flake8, Linux mypy, subprocess encoding, brand, docs lint, and diff checks. Screenshot bytes are unchanged and the immutable URL names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on eb09468: this two-commit top layer is directly based on #5186 at fc34b5d, preserving the linear open tail. Its own source-provider patch is unchanged; it inherits #5185’s locale resolution and #5186’s combined babysit guidance. The composed top passes 314 focused backend tests, the production website build, all 19 base-aware i18n gates, Black, subprocess encoding, brand, and docs lint. Screenshot bytes are unchanged and the immutable URL names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current inherited main-restack verification on eb09468: this two-commit top layer is directly based on #5186 at 950ee12, preserving the linear open tail. Its source-provider patch is unchanged. The composed top passes the 3,628-test selected backend run, all 1,344 focused frontend tests, the production website build, all 19 base-aware i18n gates, Black, subprocess encoding, brand, and docs lint. Screenshot bytes are unchanged and the immutable URL names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current inherited main-restack verification on eb09468: this two-commit top layer is directly based on #5186 at 950ee12, preserving the linear open tail. Its source-provider patch is unchanged. The composed top passes the 3,628-test selected backend run, all 1,344 focused frontend tests, the production website build, all 19 base-aware i18n gates, Black, subprocess encoding, brand, and docs lint. Screenshot bytes are unchanged and the immutable URL names this commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current inherited terminal-delivery fix on eb09468: this two-commit top layer is directly based on #5186 at 91ce5df, preserving the linear open tail. It inherits startup-safe terminal observation and exact opaque-monitor delivery acknowledgements without changing this layer’s own source-provider patch or screenshot bytes. Both new regressions pass on the rebased top; the screenshot URL now names this current top commit. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on 466c5a3051517ba0f44350e98a3216e67e22c440: this two-commit top layer is directly based on #5186 at 0de1af3e4bdb993b3137478b9db6276f4e8277cb. The pod/runtime.py conflict preserves main’s pod-scoped OAuth-home isolation together with this layer’s source-provider CLI and credential isolation. All 626 focused provider, pod, monitor, and credential tests pass with 2 platform skips; all 124 focused frontend tests, the production website build, focused flake8, and Black pass. Screenshot bytes are unchanged and the immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current inherited dashboard review fix on 4eac2ab2ad1ee3e11416f9ea14a62158ce2bacf5: this two-commit top layer is directly based on #5186 at e2a3efceed983ede5ded0333052e17b461569943, preserving the linear open tail and inheriting #5185’s two current review fixes. All 155 composed focused tests pass with targeted ESLint and TypeScript clean; Git range-diff confirms both source-provider patches and screenshot bytes are unchanged. The immutable screenshot URL now names this current top commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current main-restack verification on 4eac2ab2ad1ee3e11416f9ea14a62158ce2bacf5: this two-commit top layer is directly based on #5186 at fbd19a2b70e0d1ae647dc9a2c45fd90e7e3baf3b. The chat-runner conflict preserves main’s terminal-question bookkeeping together with this layer’s channel-origin credential boundary. The composed top passes 876 focused backend tests and 275 focused frontend tests, TypeScript, targeted ESLint, Black, subprocess encoding, all 19 base-aware i18n gates, docs lint, and brand lint. Screenshot bytes are unchanged and the immutable screenshot URL now names this current top commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current final main-restack verification on 4eac2ab2ad1ee3e11416f9ea14a62158ce2bacf5: this two-commit top layer is directly based on #5186 at be1a2de18a0bd15a3afa51abba6b3f9e4edaeff7. The integration preserves main’s self-arm provenance and outcome reporting while carrying this layer’s channel creation-surface credential fence, closing-slot admission, and terminal-question bookkeeping. The composed top passes 1,264 focused self-arm, directive, provider, dashboard, and Slack tests with 2 platform skips, plus TypeScript, i18n, Black, isort, flake8, Linux-targeted mypy, docs, brand, and repository gates. Screenshot bytes are unchanged and the immutable screenshot URL names this current top commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current internal-content scan fix on 4eac2ab2ad1ee3e11416f9ea14a62158ce2bacf5: the self-managed GitLab denial regression now uses the reserved gitlab.example.com test host instead of an internal-marker-shaped fake hostname. All 75 provider tests, focused Black, isort, flake8, and diff checks pass. The two-commit top shape is preserved and the screenshot URL names this current commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current channel-retarget credential fix on 4bcbd22288b46454c238cb4158931efb27988a9f: a channel-origin target change atomically ratchets a dashboard-created monitor to the channel creation surface, so the retargeted Azure DevOps or Bitbucket probe cannot inherit dashboard-only owner credentials. The regression failed on the prior head and passes with the fix. This two-commit top is directly based on #5186 at f93c40c10f01327fad422a3a35c53ba2e3c8bc01; the open tail is rebased onto current main at 8a9c269b48e6a0a74708a69d4949929abbe128ad. All 1,265 focused tests pass with 2 platform skips, plus focused Black, isort, flake8, Linux-targeted mypy, docs, subprocess-encoding, and brand gates. Screenshot bytes are unchanged and its immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current review-fix/main-restack verification on 4bcbd22288b46454c238cb4158931efb27988a9f: this two-commit top is directly based on #5186 at f28639e3fb614b314a46f2d81e5c827220be70c3, with the open tail rebased onto current main at 7177fa4400c5c463c183b35c6ee67d2ec73cf2bd. Provider probes now call the shared suspended-spawn policy owner, and dashboard monitor admission consistently reads the public is_closing slot API. The regressions failed on the prior head and pass with the fix; all 134 focused monitor/provider/directive/AutoNudge/Slack tests and all 42 security-conductor contract tests pass, along with focused Black, isort, flake8, Linux mypy, subprocess encoding, and brand gates. The stack was force-pushed bottom-up with explicit leases and no conflicts. Screenshot bytes are unchanged and its immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current review-fix/main-restack verification on 675ea1c24: this top layer is based exactly on #5186 at ba1d991cf, with the open tail rooted on current main at 7fa305f35. The current GPT and First Principles findings are addressed: owner credentials require a protected dashboard grant, autonomous GitHub CLI resolution uses the strict protected executable chain, blank check labels retain provider state, and legacy persisted observations preserve completed-check semantics. The composed open tail passes 485 focused backend tests, all 30,540 website tests, and the 127 directly affected frontend tests, plus Black, flake8, Linux mypy, comment-history, subprocess-encoding, brand, harness-parity, and clean-clone diff checks. The unrelated Electron packaging suite is unavailable because its nested package fixtures are absent. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current security-review verification on 4bcbd22288b46454c238cb4158931efb27988a9f: the owner-credential authorization record now lives beneath the sandbox-hidden .vault directory instead of the agent-writable trust/ tree. A failed revocation denies the monitor id immediately in-process and retries durable deletion on later credential checks. The provider CLI reaches the shared suspended-spawn policy through the agent SDK boundary, and credential identifiers are absent from revocation warnings. All 109 focused provenance, provider-transport, and SDK-boundary tests pass, along with focused Linux mypy, flake8, Black, isort, docs lint, subprocess-encoding, comment-history, brand, harness-parity, and diff checks. The screenshot bytes are unchanged and its immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current credential-activation rollback verification on 4bcbd22288b46454c238cb4158931efb27988a9f: a failed owner-credential activation during monitor restart now durably restores the exact terminal monitor row while retaining its prior protected grant, so the failed request does not consume the restart or make an immediate retry conflict. The regression failed on the prior head and passes with the fix. All 110 focused provenance, provider-transport, and SDK-boundary tests, all 196 AutoNudge service tests, and all 196 authorization, banner, and self-arm tests pass, along with focused Linux mypy, flake8, Black, isort, docs lint, subprocess-encoding, comment-history, brand, harness-parity, SDK-boundary, and diff checks. The two-commit top and exact #5186 base are preserved; screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current main-restack verification on 4bcbd22288b46454c238cb4158931efb27988a9f: this two-commit top is based exactly on #5186 at 530e2fa2f80f2b4cd433d83df093ec118f155c3f, with the open tail rooted on current main at 1192049a3ccb3ba52d76154c20c66d5905fd4cbd. The sole cumulative conflict was the generated comment-history baseline; regeneration lowered the combined total from 7,600 to 7,593 without widening any entry. The comment-history gate and all 180 focused provider, controller, provenance, and persistence tests pass. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Restacked 2026-09-08 after main advanced. The current stack integrates the shared cron query, reconnect cleanup, Feature Preview catalog entries, and regenerated comment-history baseline. Focused backend tests (180), frontend tests (295), TypeScript, i18n, and comment-history validation pass.

Bundle-size follow-up (2026-09-08): current main left about 0.5 KB of the documented i18n-runtime headroom; this PR adds 2.7 KB of required English monitor strings. The t-chunk ceiling now restores the gate’s stated ~5% headroom. The previously failing analyze report and all 16 bundle-gate tests pass.

PR-hygiene follow-up (2026-09-08): the bundle-budget adjustment is folded into the existing fix commit, keeping this PR at the required two-commit maximum with an identical final tree.

Current credential-transaction review fix on 5cabe9265: grant mutations now preserve existing provenance by failing on unreadable or invalid records; a failed credential rebind durably restores the exact prior monitor unless a concurrent mutation has superseded it; and restart preserves channel creation provenance. The seven new regressions fail on the prior head and pass on this head. All 267 focused monitor, authorization, directive, dashboard, and self-arm tests pass, plus Black, flake8, Linux mypy, docs lint, brand, and diff checks. The two-commit top and exact #5186 base are preserved; screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current credential-transaction/main-restack verification on 1610fb0e05c5a40d735e447a27882223869eb305: this two-commit top is based exactly on #5186 at db49860bf6707f52bd201bee93731c2553c06dda. Grant mutations fail closed without overwriting unrelated provenance, failed credential rebinding rolls the monitor back race-safely, and restart preserves channel creation provenance. All 519 focused monitor/provider/authorization/directive/dashboard/self-arm tests pass, plus the analyze build, the 825-chunk bundle gate, all 16 bundle-gate tests, Black, flake8, docs, brand, comment-history, and stack-specific Linux mypy. GitHub reports all three open PRs MERGEABLE with zero current unresolved review threads. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current inherited CI-fix verification on 1610fb0e05c5a40d735e447a27882223869eb305: this two-commit top is based exactly on #5186 at 8154e2c02bdf1ae5e8e396133d61e19e48153b30 and inherits #5185’s reduced comment-history baseline plus #5186’s MonitorVerdict test corrections. The composed 533-test monitor suite, comment-history, Black, flake8, focused Linux mypy, docs, brand, and stack-integrity gates pass. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI is running; no CI job was manually rerun.

Current conflict-free main restack on b6c1223bc: this two-commit top is based exactly on #5186 at 28226e76c, and the open tail is rooted on current main at ab3a5ac8d. The conflict resolution preserves main’s centralized transcript renderers and present-tense chat-runner commentary while retaining this stack’s automation and provider behavior; the generated comment-history baseline was regenerated without adding or widening entries. TypeScript and 329 focused frontend tests pass, along with Python compilation of the backend conflict surface, the comment-history gate, and stack-integrity checks. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI is running; no CI job was manually rerun.

Current review-fix verification on 16e8edae5bde6721d7f00a13b87deeae8366f321: durable provider-credential revocation is now a hard precondition before an agent-writable monitor row can be removed; a failed tombstone write aborts the removal and retains the row. GitHub monitors again use the established same-user gh resolver, preserving stock Homebrew and user-local installs while the protected executable-chain requirement remains on autonomous glab and az. The official Atlassian Bitbucket Cloud REST reference confirms the pull-request conflicts endpoint used by the provider. All 93 focused provider-trust and source-provider tests pass, plus focused Black, isort, flake8, Linux mypy, docs lint, subprocess-encoding, brand, and diff checks. The two-commit top remains directly based on #5186; screenshot bytes are unchanged and its immutable URL names this head. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on 4f10503b1f98b3dc60f60df4762b87f8d4cc06a2: this two-commit top is based exactly on #5186 at 7f7bf81bf3115c0db32d76ba833866c64f3b3a97, with the open tail rooted on current main at 53d14a8ae1f5401e2b216d9b170efdc7ca46423a. The RFC conflict preserves main’s current consolidated-monitor audit while retaining this active stack’s in-progress status. All 145 focused tests and the relevant repository gates pass. Screenshot bytes are unchanged and its immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current inherited terminal-retry fix on 4f10503b1f98b3dc60f60df4762b87f8d4cc06a2: this two-commit top is based exactly on #5186 at e0f75dad2195867693b338142d73c2506bfdde68, preserving the linear open tail. It inherits #5186's process-local retry fix without changing this layer's source-provider patches or screenshot bytes. All 269 focused Slack, provider-trust, source-provider, and dashboard-handler tests pass, plus Black, isort, flake8, Linux mypy, and docs lint. The prior Windows shard 4 failure is an unchanged pre-existing scheduler-ordering race in test_nudge_expiring_during_the_persist_cannot_resurrect, not an introduced stack failure; no CI job was manually rerun.

Current credential-rollback review fix on 4f10503b1f98b3dc60f60df4762b87f8d4cc06a2: a generic AutoNudge replacement now captures whether the displaced structured monitor owns an exact active provider grant, revokes it before the combined agent-writable snapshot, and restores that grant before re-arming the prior monitor when persistence fails. The regression fails on the prior head and passes on this head. All 270 focused Slack, provider-trust, source-provider, and dashboard-handler tests pass, plus Black, isort, flake8, Linux mypy, docs lint, comment-history, and the agent-SDK boundary gate. The two-commit top and exact #5186 base are preserved; screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current inherited compatibility-feed fix on 4f10503b1f98b3dc60f60df4762b87f8d4cc06a2: this two-commit top is based exactly on #5186 at 8e4882bfa921f5ad299ded1493f0832034faf62a, preserving the linear open tail while inheriting #5185’s reduced-row filtering. The focused composed automation suite passes 151 tests, plus TypeScript, ESLint, docs lint, and diff checks. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI is running; no CI job was manually rerun.\n\nCurrent post-restack verification on 4f563bfdfeacfc289a5b85cf85a90dba45bab8e4: this two-commit top is directly based on #5186 at cd24422e9a654a58eed18e2b3caaa6388b394148, preserving the eight-PR linear stack. All 669 focused controller, provider, babysit, Slack, registry, and readiness tests pass; the comment-history gate, Black, isort, flake8, and focused Linux-platform mypy pass. Screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI is running; no CI job was manually rerun.\n\nCurrent revocation-rollback/main-restack verification on 3af6b3726034ff9a7305e616b02cd534c25d7e78: this two-commit top is directly based on current main at cb7fe7650661f9c8f23b354cafa299195832df1c. When a non-dashboard target update cannot durably revoke the prior owner-credential grant, it now compare-and-swap restores the prior monitor identity before returning 503, so restart cannot expose that grant under the attacker-selected target. The regression failed on the prior head and passes here; all 74 focused authorization and provider-trust tests pass, plus Python 3.12 Linux-targeted mypy across 1,464 source files, Black, isort, flake8, subprocess encoding, and docs lint. Screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current provider-compatibility/main-restack verification on f0ce73f5561a912b26c44055789bdd04b6bb1b6b: this two-commit top is directly based on current main at 8b58f72a8677c649cefe6cb5582d7c70f56ea5ea. GitLab and Azure monitor probes now retain the shared same-user provider-CLI policy, so stock Homebrew and user-local installs work while other-user, world-writable, project, and workspace paths remain refused; operators can still require system-owned binaries with KIROCREW_PROVIDER_BIN_STRICT=1. The regressions failed before the fix and all 769 focused provider and runner tests pass afterward, plus focused Black, isort, flake8, Linux-targeted mypy, subprocess encoding, and docs lint. Screenshot bytes are unchanged and the immutable URL names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current atomic-rollback review fix on b4f465ac4ae5a6324a626e1e07c4962baec6fa23: monitor target and owner-credential updates now capture their rollback snapshot under the same service lock that applies the patch, so a failed credential write preserves any concurrent update that committed first. The regression failed on the prior head and passes here; all 261 monitor service, authorization, directive, and kind-registry tests pass, plus focused Black, isort, flake8, Linux-targeted mypy, subprocess encoding, docs lint, and diff checks. The two-commit top remains directly based on current main; screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current Windows race fix on b9a3e0843887a4cf37643b5397f71e0eac71facc: durable provider-credential revocation now quiesces and cancels the loop timer before its off-loop trust write, then restores the active timer if revocation fails. This closes the slot-close fire window exposed by the prior head. The existing deterministic race test failed locally and on Windows before the fix and passes afterward; all 622 AutoNudge and slot-close tests pass, plus focused Black, isort, flake8, Linux-targeted mypy, subprocess encoding, docs lint, and diff checks. The other prior Windows failure was an unrelated temporary-file PermissionError. The two-commit top remains directly based on current main; screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current upstream-fix restack verification on b9a3e0843887a4cf37643b5397f71e0eac71facc: this two-commit top layer is directly based on main at bf09e50e56d05a2fe243769dcab2521fe8b4c517. Both prior current-head shard failures were the same malformed-cron-owner assertion, and this new base is the exact upstream fix; the previously failing regression plus all 74 focused slot-close and AutoNudge authorization tests pass locally (75 total). The only tree delta from the prior top is the upstream test fix. Screenshot bytes are unchanged and its immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current main-restack verification on b9a3e0843887a4cf37643b5397f71e0eac71facc: this two-commit top layer is directly based on main at c381e6d4f8687b85ac93bd4dd3a5cb205e471138. The upstream scratch-tree reclamation change and its test coverage compose cleanly with the slot-close regression suite; all 89 focused scratch, slot-close, AutoNudge authorization, and malformed-cron-owner tests pass. The prior Linux shard-4 PTY failure was an unrelated transcript-order race in terminal code and tests untouched by this stack; the exact test passed locally, while Coverage Gate failed only downstream. Screenshot bytes are unchanged and its immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current cron-fix restack verification on b9a3e0843887a4cf37643b5397f71e0eac71facc: this two-commit top layer is directly based on main at 1c031cc7c4684951e9d0b877dc385f212380bdab. Upstream’s one-shot child-release change composes without conflicts; all 92 focused cron-cascade, scratch, slot-close, AutoNudge authorization, and malformed-cron-owner tests pass. The prior Windows eager-spawn failure is a race in a test and implementation byte-identical to main, and its exact test passes locally. The prior frontend shard passed all 7,603 tests before a Vitest worker exited unexpectedly; frontend coverage and the aggregate coverage gate failed downstream. Screenshot bytes are unchanged and its immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current protected-grant update verification on b9a3e08: a dashboard PATCH now rebinds owner-provider credentials only when the protected store proves the exact prior monitor identity already held that grant; updating a channel-created or otherwise ungranted monitor keeps authority absent. The regression failed on the prior head and passes with the fix. All 76 focused authorization and protected-provenance tests pass, plus focused Black, isort, flake8, isolated Linux mypy, docs lint, and diff checks. The repository-wide subprocess-encoding and full mypy gates currently stop on the unmatched-quote f-string in src/kiro_crew/apps/builtins/aws_control/backend/backup.py inherited byte-for-byte from main. Screenshot bytes are unchanged and its immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current restart grant-fence verification on b9a3e08: restarting a terminal monitor now rebinds owner-provider credentials only when the protected store proves the exact prior id, slot, kind, and target already held an active grant. Forging the agent-writable creation surface or target cannot mint credential authority. The regression failed on the prior head and passes with the fix; the legitimate granted-restart path remains covered. All 77 focused authorization and protected-provenance tests pass, plus focused Black, isort, flake8, isolated Linux mypy, docs lint, and diff checks. Screenshot bytes are unchanged and its immutable URL now names this commit. Fresh CI and reviews are running; no CI job was manually rerun.

Current upstream-race restack verification on 40bc6e02b1a1ab7879b3c031139ff5fe06c8ae2a: this two-commit top is directly based on current main at 12212200b546f86a007acc60e10307edbfa1d02e. The failed Windows eager-spawn check ran against the prior base; current main contains the exact upstream arm-generation fix for that race. The previously failing concurrent admission regression, the new deterministic Windows-race regression, and all 77 protected-credential tests pass locally (79 total). Range-diff confirms both PR commits are unchanged, the rebase completed without conflicts, and the screenshot bytes are unchanged with its immutable URL naming this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current advisory-review cleanup on ce7746a0d2e7d47baeb775ffefb55bd7e75df950: monitor retargeting copy now uses the user-facing “code host” concept, self-managed GitLab guidance names the exact ~/.kiro/crew/config.json path in every locale, and the unknown .env warning no longer points to a nonexistent Settings roster or logs credential identifiers. The unused single-provider controller compatibility seam and its test-only mutations are removed. All 128 focused controller, warning, and popover tests pass, plus base-aware i18n checks, TypeScript, targeted ESLint, Black, isort, flake8, focused Linux mypy, docs lint, and diff checks. The screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current design-spec/main-restack verification on efc844cbb6ee7687910f42b61bc8a88b5d15769c: monitor-architecture.md now describes the shipped data registry, provider-neutral plural probe boundary, verdict evidence wrapper, kind-scoped objectives, and the remaining split from the irq driver instead of presenting the pre-provider implementation as current. The two-commit top rebased without conflicts onto current main at 1b9423e5864764b75442764aae667bb94e57fd7c; range-diff confirms both PR commits are unchanged. All 193 focused controller, registry, workflow-run, credential-warning, and popover tests pass, plus base-aware i18n checks, TypeScript, targeted ESLint, Black, isort, flake8, focused Linux mypy, docs lint, and diff checks. Screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current provider-binary trust fix on 8c8a5c45c1b27a3673e0f44438758d90077f6fe8: credential-bearing GitLab and Azure monitor probes now require a protected canonical system-owned CLI chain, so a same-user glab or az replacement cannot receive provider credentials. GitHub retains its established same-user resolver. The regression failed before the change; all 111 focused provider and runner tests pass, with Black, isort, flake8, docs lint, and the second-commit diff check clean. Full mypy and subprocess-encoding remain blocked by the unmatched-quote f-string in the AWS backup module inherited byte-for-byte from main. The two-commit top is based exactly on current main at 2d418a3ab79f295ef2ef9a9414d037bef0096eee; screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews will run; no CI job was manually rerun.

Current replacement-rollback CAS fix on 00c788e59c1e8ebbb0859418bb29903d355f2494: failed owner-credential activation restores the displaced terminal monitor only while the exact replacement snapshot remains current. A concurrent committed PATCH now wins and the failed restart reports 409 instead of overwriting that edit. The regression failed on the prior head and passes here; all 274 focused AutoNudge service, authorization, and credential-trust tests pass, plus Black, isort, flake8, docs lint, and diff checks. Full Linux mypy remains blocked by the unmatched-quote f-string in the AWS backup module inherited byte-for-byte from main. The two-commit top remains directly based on current main; screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current durable-revocation verification on a6e39b0518e6e7f4d349b3f47f03b981305b20ca: restart durably revokes the displaced provider-credential grant before the replacement monitor snapshot can commit, restores it when persistence fails, and restores it after a successful rollback only while the exact replacement remains current. The regression failed on the prior head and passes with the fix. All 276 focused AutoNudge, authorization, and provider-trust tests pass after rebasing the two commits onto current main; focused flake8, Black, docs lint, and the changed-commit diff check pass. Linux-targeted mypy remains blocked before checking this file by the byte-identical syntax error in src/kiro_crew/apps/builtins/aws_control/backend/backup.py on current main. Screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no manual CI rerun was made.

Current main-restack verification on c3fad45: this two-commit top is directly based on current main at d83a9d4. The babysit guidance conflict preserves main’s compact review-repair routing while documenting all four supported source providers; the provider-runner conflict preserves main’s current Windows token model while retaining the protected executable-chain requirement for credential-bearing autonomous probes. The 359-test core monitor suite, 371-test provider and runner suite, and 190-test babysit and persistence suite pass, plus Black, focused flake8, and docs lint. Screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current restack-contract fix on 6f3012e: the conflict-resolved babysit guidance again carries the exact provider-facts versus generic-comment contract required by the shared review-routing gate. The regression reproduced locally before the fix; its exact test and all 20 review-routing skill tests pass afterward, along with docs lint and diff checks. The other prior macOS failure reproduces unchanged locally in the dependency-provisioning lock test, whose production and test files are byte-identical to current main, so it remains classified as pre-existing. The two-commit top and current-main base are preserved; screenshot bytes are unchanged and the immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

Current removal-rollback review fix on 6f3012e0fb42706748147a88a65626c388bb3c9f: an ordinary structured-monitor removal now snapshots whether its exact protected provider grant exists before revocation and restores that grant with the durable row if monitor-store persistence fails. The regression failed on the prior head and passes here; all 92 focused authorization, provider-trust, and removal tests pass, including the exact regression under xdist, plus Black, isort, focused flake8, isolated Linux mypy, docs lint, and diff checks. Full configured mypy and subprocess-encoding remain blocked before the changed files by the unmatched-quote f-string inherited byte-for-byte from current main. The two-commit top remains directly based on current main; screenshot bytes are unchanged and its immutable URL now names this head. Fresh CI and reviews are running; no CI job was manually rerun.

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 6f3012e0fb42706748147a88a65626c388bb3c9f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6f3012e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6f3012e0fb42706748147a88a65626c388bb3c9f: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Aug 23, 2026
@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 6f3012e0fb42706748147a88a65626c388bb3c9f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

I have everything needed: the blind read, the full frontend diff, the PR description, and the screenshot itself. The user-facing surface is small — a new help line under the URL field, multi-provider URL acceptance, and three new error strings. The blind reader understood the primary path ("sure" on the URL field, its help note, and Start monitor); their confusions (legacy goal loop, "actionable wake", turns vs tokens) all attach to strings that pre-exist at base, not this diff. The three new error states appear in no screenshot — the PR says so itself — and both the blind reader and my own read of the low-res screenshot see "GitHub, GitLab, Azure DevOps, and Bitbucket" where the shipped string says "GitHub.com, GitLab, Azure DevOps Services, and Bitbucket Cloud", so the committed capture appears stale relative to the final copy.

UX-Verdict: CONCERNS

The multi-provider URL field reads clean cold, but all three new error states ship unseen and the lone screenshot appears to predate the final copy.

Watch

  • The screenshot's help line reads "GitHub, GitLab, Azure DevOps, and Bitbucket are supported" (blind reader's transcription matches my read), while the shipped string is "GitHub.com, GitLab, Azure DevOps Services, and Bitbucket Cloud are supported." — the image alt claims the latter. The "bytes unchanged" capture appears stale; the 7 KB JPEG is also too low-resolution to verify any copy. Low frequency (review-time only) but it means no one has looked at the shipped pixels. Fix: recapture at full resolution from this head.

Evidence gaps

  • Inline error "Enter a supported pull request URL." (invalid_pull_request_url) shown in no screenshot — capture the URL field with this error rendered.
  • Notice "This GitLab host isn't allowed yet. Add it to dashboard.gitlab_hosts in ~/.kiro/crew/config.json." shown in no screenshot — capture the rejected self-managed-GitLab flow.
  • Inline error "This monitor is tied to its current code host. Watch the new link from a new session." shown in no screenshot — capture the edit flow with a cross-host URL.

[UX-REVIEWED] 6f3012e

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 6f3012e0fb42706748147a88a65626c388bb3c9f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

Four-provider contract is sound; the vault record is the real authority, so the persisted surface enum and its rollback protocol are unneeded surface.

Not justified as shipped

  • MonitorCreationSurface — 3 variants, 2 reads, both is DASHBOARD; UNKNOWN and CHANNEL never differ.
  • Deferred-revocation / commit-rollback protocol — 5 new service entry points, one consumer each, all availability on a fail-closed path.
  • TS normalizePullRequestMonitorTarget — second spelling of the Python parsers the backend already applies.
  • Slot close fence + session_close restart refusal — a sibling PR's race, shipped here with API and UI behavior.
  • GitHub blank-label acceptance — replaces an existing rejection, mentioned in no bullet.

What this change ships

Inventory (10 items) — 5 justified

Intent: extend structured PR monitoring from GitHub-only to four source providers. ADDITION.

  1. monitoring/pull_request.py shared readiness contract; GitHub refactored onto it — justified
  2. GitLab/Azure/Bitbucket adapters plus strict canonical target parsers — justified
  3. Hardened provider CLI transport: minimal env, byte ceilings, SEL audit — justified
  4. .vault/ trust record; agent-writable store cannot authorize owner credentials — justified
  5. MonitorCreationSurface persisted, threaded through ~12 signatures — one consumer, generalized
  6. defer_replaced_trust_revocation, commit/rollback replacement, _prior_snapshot_out, 503 — oversized
  7. Frontend re-implements four providers' URL rules in TS — duplicate of src/kiro_crew/monitoring/targets.py
  8. is_closing/begin_close fence; restart 409s on session_close — rides along
  9. Empty CheckRun name / StatusContext no longer malformed — undeclared
  10. _directive_channel_origin provenance through queue, dispatch, applier — justified

Capped at 10 of ~115 files; unlisted riders: RFC status and open-question rewrite, first .jpg plus *.jpg binary -diff, credential-warning text.

Watch

  • Base raised "GitHub check rollup is malformed"; now two blank-labelled checks in one workflow sharing status/conclusion collapse to one identity. Clears when: a test keeps two such checks distinct, or the rejection returns.
  • RFC open question 5, "Which monitor kinds should follow next?", is narrowed to "Which non-review monitor kind…" by the diff that answers it. Clears when: the demand for a non-GitHub provider is pointed to outside this branch.

Subtractions

  • Delete MonitorCreationSurface and its persisted field: the vault record decides at fire time, and grant_owner_provider_credentials=True ships only from the three dashboard handlers.
  • Delete defer_replaced_trust_revocation, commit_monitor_replacement, rollback_monitor_replacement, rollback_monitor_update, _prior_snapshot_out and the rollback-capability 503; a failed replacement already fails closed until re-armed.
  • Delete the client-side kind inference: _monitor_config infers the kind and answers invalid_pull_request_url.

[FIRST-PRINCIPLES-REVIEWED] 6f3012e

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — 🟡 CONCERNS

Design-level review of 6f3012e0fb42706748147a88a65626c388bb3c9f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Sound provider-neutral contract, but the credential-grant protocol is call-site choreography whose own history shows it breeds races, and binary trust splits by provider.

Watch

  • The .vault/ grant store is a two-phase protocol (prepare → activate → forget/tombstone → CAS rollback) hand-threaded through every mutation path — create, PATCH, restart, replacement, removal, slot-close each re-implement the sequence in autonudge.py/autonudge_authz.py/dashboard handlers. The PR description records ~10 successive review-found rollback/revocation races, one per path ("failed credential rebind durably restores…", "replacement-rollback CAS fix…", "removal-rollback review fix…"). The invariant (agent-writable row never authorizes credentials) lives in convention, not in one owner, so the next mutation path added will plausibly ship the eleventh race as a credential leak or a stuck grant.
    Clears when: the prepare/activate/forget/rollback sequence is consolidated behind one transactional service API (or context manager) that all mutation paths must call, or a pinned test enumerates every monitor-mutation path and asserts grant↔row consistency across injected persistence failures.

  • Same threat, two trust policies: resolve_provider_cli forces require_protected=True (root-owned, symlink-free chain) for glab/az, while gh keeps the documented "if it works in your terminal" same-user policy with GH_TOKEN passthrough — the identical agent-planted-binary exfil channel the strict rule exists to close. Consequence: GitLab/Azure monitoring fails on stock Homebrew/user-local installs (the override env var is validated under the same strict rule, so there is no in-product remedy) while GitHub works, and the security rationale is undercut by the gh exception.
    Clears when: the asymmetry is documented as a deliberate legacy exception with a stated plan (tighten gh, or an operator knob that relaxes glab/az to gh's policy), or the policies are aligned.

[DESIGN-REVIEWED] 6f3012e

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 6f3012e0fb42706748147a88a65626c388bb3c9f — this comment is updated in place on each push.

Review details

The candidate dies under falsification. Its (c) — observable wrong outcome — is absent, as its own analysis concedes. I verified:

  • _probe_one (targets.py caller) parses raw_target into a structured AzureDevOpsPullRequestTarget and passes the structured fields to _fetch_with_az; the raw string is never reused. _parts runs unquote on each segment, so an over-encoded spelling (%41bc) decodes to the true intended value (Abc) — the fetched resource is correct regardless of round-trip.
  • normalize_pull_request_target persists target.url (the canonical, re-quoted form), never raw, so storage is canonical.
  • _AZURE_SEGMENT_RE still excludes / : \ % ~ @ ? # $ * { } [ ] & ; ' " | < > , + = and all control chars, so no path smuggling, host confusion, or argv injection survives the permissive regex.
  • infer_pull_request_kind gates Azure on host=="dev.azure.com" and the fixed _git/pullrequest markers, so no cross-provider misrouting.

The missing target.url != raw check is a strict-parsing style asymmetry with no reachable wrong result — exactly what the candidate rated "low" confidence. It does not survive Step 1. No new grounded finding emerged in this module.

No findings.

[OPUS-REVIEWED] 6f3012e

Verdict parsed from the review's SHA-scoped output markers for commit 6f3012e0fb42706748147a88a65626c388bb3c9f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6f3012e0fb42706748147a88a65626c388bb3c9f: <one-sentence reason>

@kyleseaman
kyleseaman force-pushed the token-monitors-source-providers branch from a35bfbe to 08562fe Compare August 23, 2026 14:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Aug 23, 2026
@kyleseaman
kyleseaman force-pushed the token-monitors-source-providers branch from 08562fe to 6572db2 Compare August 23, 2026 14:43
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Aug 23, 2026
@kyleseaman
kyleseaman force-pushed the token-monitors-source-providers branch from 6572db2 to 434894c Compare August 23, 2026 15:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Aug 23, 2026
@kyleseaman
kyleseaman force-pushed the token-monitors-source-providers branch from 434894c to 45fd3a0 Compare August 23, 2026 15:20
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Aug 23, 2026
@kyleseaman
kyleseaman force-pushed the token-monitors-source-providers branch from 45fd3a0 to ed225b2 Compare August 23, 2026 15:33
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the Azure CLI blocker and the Windows shard failures in 29577f0. Azure config/extension visibility now uses HOME consistently across platforms and rejects paths equal to or beneath agent-writable project/workspace roots. Added focused coverage for both equality and descendant cases; 4 focused tests, flake8, Linux-parity mypy, Black gate, and docs lint pass.

@bolichen97

Copy link
Copy Markdown
Contributor

Audit note — this PR is one slice of a declared branch stack, not a duplicate

A duplicate-detection sweep flagged #5184 / #5185 / #5186 / #5305 as overlapping at FULL coverage. That is a stacking artifact, and it is worth stating plainly so nobody acts on it: each branch physically contains the previous one, so the shared code is inherited and each PR's review diff overstates what it actually authored.

Proved mechanically, not by reading code:

The two PRs are also cleanly split by surface, which is why they are complementary rather than redundant. #5184 is backend-only: 26 files under src/kiro_crew/ (monitoring/controller.py, mcp_tools/control.py, validation.py, session_directive.py, dashboard/handlers/autonudge.py, slack/gateway.py, discord/gateway.py, ...) and ZERO files under website/. #5185's own delta (git diff pr/5184..pr/5185) is 55 files, +4328/-278, of which 44 are under website/ — the dashboard consumer for the six /api/monitors routes #5184 ships with no consumer (the exact point the first-principles review bot raised on #5184): new website/src/components/SessionAutomationPopover.tsx (+587), new website/src/monitoring/automation.ts (+400, exporting normalizeAutomationRecord/deriveAutomationStatus/automationForSlot), new website/src/monitoring/contract.json (+36), MonitorRadar.tsx (+25), useWebSocket.ts (+235), chatSlice.ts, i18n keys across 13 locale files, and ~1,300 lines of new frontend tests (SessionAutomationPopover.test.tsx +480, automationNormalizer.test.ts +238, monitorFixtures.ts +77).

The 11 non-website files in #5185's own delta are strictly ADDITIVE refinements in service of that frontend, not a competing design: monitoring/models.py gains monitor_frontend_contract() (which is what contract.json is generated from), a _public_github_observation() bounded projection over the public boundary, and two new MonitorState fields (last_observation_status, last_observation_reason_code) with their post_init validation and monitor_state_from_dict enum coercion; autonudge.py gains 4 lines populating those two fields; mcp_tools/control.py adds the same two keys to _compact_monitor_inspection's field tuple. Because #5185 sits downstream, it is structurally impossible for it to present an incompatible design for #5184's requirement — it edits #5184's own lines as a successor, not as an alternative.

Neither has landed: 550ea7b, fc82d95, 4c7b130 and 331c07d are all absent from origin/main; main carries monitoring/{init,completion,decision,github_pull_request,models,shadow}.py but NOT controller.py, and website/src/monitoring/ and SessionAutomationPopover.tsx do not exist on main. Ironically the first-pass record itself, the cached PR data, states in prose "Stacked descendant (PR 6). Its branch is #5184's head plus 4c7b130 + 331c07d; the shared code is inherited, which per the brief is a stacked branch, not duplicate" — the FULL/complete_coverage=true coding of that same relation is what the scan surfaced as a duplicate signal.

Proof of stacking: git merge-base origin/main pr/5184 == git merge-base origin/main pr/5186 == dc35c19, and git merge-base --is-ancestor pr/5184 pr/5186 returns YES. git log --oneline dc35c192f..pr/5186 is 7ce67a7, 04e9461, 331c07d, 4c7b130, fc82d95, 550ea7b -- the last two ARE #5184's entire branch (550ea7b "feat: expose session monitors to agents", fc82d95 "fix: preserve bounded monitor recovery"), and 4c7b130/331c07d53 are #5185's. So the merge-base-vs-main diff for #5186 (118 files, +14347/-1684) contains 100% of #5184 by construction. One REST call confirmed intent: #5186 is head token-monitors-babysit onto base token-monitors-dashboard, and its body declares "PR 7 of 8 / Base: #5185 / Next: #5305"; #5184's body declares "PR 5 of 8 / Base: #5183 / Next: #5185". GitHub therefore renders only #5186's own delta. The maintainer reviews it the same way: bolichen97's 2026-09-01 review on #5184 states it reviewed origin/token-monitors-github-probe...origin/token-monitors-tools -- the slice, not the range to main.

#5186's own delta (git diff 331c07d53..7ce67a772) is 25 files, +1158/-751, and none of it duplicates #5184: (1) babysit/SKILL.md rewritten by 744 lines to point at monitor_watch instead of prompt-owned polling -- a file #5184 never touches; (2) a new shipped user doc src/kiro_crew/docs/monitoring.md (+85) with its docs/README.md and docs/index.md rows; (3) src/kiro_crew/config/prompt.md guidance; (4) a behavioural policy change in validation.py banning unbounded loops -- MONITOR_START_SCHEMA and MONITOR_UPDATE_SCHEMA move max_cycles/max_runtime_secs from min_val=0 to min_val=1; (5) a new AutoNudgeService.stop_monitor_if_budget_exhausted plus its _Service Protocol row and the if await self._service.stop_monitor_if_budget_exhausted(loop.id, now=now): return MonitorDecision.STOP_BUDGET call site in MonitorController.tick; (6) an evidence_scope FieldSpec on MONITOR_WATCH_SCHEMA and monitor_start's demotion to "Legacy fallback for targets or objectives unsupported by monitor_watch"; (7) slack/gateway.py terminal-outcome notifications keyed on (loop.id, outcome, stopped_at) for SUCCESS/BLOCKED/BUDGET/TARGET_UNAVAILABLE; (8) a new test module test/test_babysit_monitor_scenarios.py (+476) plus four more test files #5184 does not touch.

Per-file judgment of the 14 shared paths: every one is a file #5184 creates or extends and #5186 then builds further on. src/kiro_crew/monitoring/controller.py does not exist on origin/main at all (git ls-tree of the monitoring package shows only init.py, completion.py, decision.py, github_pull_request.py, models.py, shadow.py) -- #5184 creates it, #5186 adds 9 lines to it. mcp_tools/control.py: #5184 introduces the monitor_watch schema and #5186 edits the schema #5184 authored. That is a build-on-top dependency, the opposite of two implementations of one behaviour.

Deciding question: if #5184 merged, would #5186 still carry real, wanted work? Yes -- the whole babysit-skill migration, the shipped monitoring doc, the unbounded-loop ban, the pre-probe budget stop, evidence_scope, and the Slack terminal notifications. The reverse direction is not a redundancy signal: #5186 "contains" #5184 only because it is branched off it.

The task premise that both are "open against main" is FACTUALLY WRONG for 5305. Its GitHub base ref is token-monitors-babysit (= 7ce67a7, #5186's branch head), not main. 5305 therefore cannot merge before its ancestors; there is no scenario in which it lands and strands 5184. Both bodies declare the same chain in prose: "Stack: #5180 -> #5181 -> #5182 -> #5183 -> #5184 -> #5185 -> #5186 -> #5305", with 5184 self-labelled "PR 5 of 8" / "Base: #5183" and 5305 "PR 8 of 8" / "Base: #5186". The remote branch chain matches exactly: token-monitors-github-probe (ca6fc25) -> token-monitors-tools (fc82d95 = pr/5184) -> token-monitors-dashboard (331c07d) -> token-monitors-babysit (7ce67a7) -> token-monitors-source-providers (9a6f511 = pr/5305).

On its OWN range (7ce67a7..9a6f511) 5305 is 77 files / +5,642 / -432 — matching GitHub's own 77 / +5605 / -432 for the PR. That range EXTENDS the four files 5184 created (src/kiro_crew/monitoring/controller.py, test/test_monitor_controller.py, test/test_monitor_directive_apply.py, test/test_monitor_mcp.py); it does not reimplement any of them. It also ADDS six modules 5184 has no counterpart for at all: monitoring/pull_request.py (the provider-neutral review-readiness contract), monitoring/targets.py (strict target parsers), monitoring/gitlab_merge_request.py, monitoring/azure_devops_pull_request.py, monitoring/bitbucket_pull_request.py, monitoring/provider_cli.py — plus dashboard/handlers/source_providers.py and a whole frontend surface (SessionAutomationPopover.tsx +626, monitoring/automation.ts +455, MonitorRadar.tsx) across 12 locale catalogs.

That is a capability 5184 STRUCTURALLY CANNOT DELIVER: 5184's MonitorController drives only the single GitHub probe already on main (monitoring/github_pull_request.py, landed by the stack's merged #5183 = dc35c19, which is 5184's merge base). GitLab / Azure DevOps / Bitbucket are different addressing schemes and different providers. Conversely 5184 is the substrate 5305 consumes — MonitorController, the monitor_watch/inspect/update/stop MCP tools, the owner-gated REST routes, format_monitor_wake, MonitorDispatchResult. Neither can be closed without destroying real, wanted work: closing 5184 deletes the controller 5305 imports; closing 5305 deletes four provider probes, the neutral readiness contract, and the entire multi-provider dashboard surface.

The maintainer agrees in practice. bolichen97 reviewed each slice on its own per-slice range — 5184 as origin/token-monitors-github-probe...origin/token-monitors-tools (59 files, +8285/-613) and 5305 as origin/token-monitors-babysit...origin/token-monitors-source-providers (73 files, +4763/-384). Nobody has ever suggested either is redundant; both carry live execution-verified review findings to fix, which is a request to iterate, not to close.

Consequence for review

Land the stack in order. Reviewing a later slice before its base lands means reviewing the base's code again, and the FULL-overlap signal a keyword or file-overlap sweep produces here means nothing.

Separately, #5184 vs #7634 (the zero-token-probe monitor gate) was adjudicated as independent — same monitor area, different behaviour — so neither blocks the other.


From a repository-wide duplicate/overlap audit of every pull request open against main, re-run against the current tree (origin/main 680baf9448dc). This PR is not being closed — the note is informational. If the reading is wrong, please correct the reasoning rather than just the conclusion.

@bolichen97

Copy link
Copy Markdown
Contributor

Review — head 9a6f511d09d063eaca6bcd6b3a46ffde36624f67 (PR 8 of 8)

Re-checked against the 2026-09-01 review and its addendum. Verdict: mergeable in stack order; the one red check is unrelated to this PR.

CI: Backend Tests (Windows) (2) fails on test/test_denied_commands_security.py::TestNestedPayloadExtractionIsLinear::test_the_scan_is_linear_not_quadratic ("0.0739s -> 0.2453s looks super-linear") — a runner-timing assertion in a file this stack does not touch. A re-run should clear it.

Prior blocking findings — verified fixed

  • --project is no longer passed to az repos pr show / policy list.
  • checks_incomplete keys on the provider's checks_complete flag, not on canonical bucket size (src/kiro_crew/monitoring/pull_request.py:325); the bounded canonical still marks overflow with checks:incomplete.
  • GitLab reads the MR's head_pipeline (src/kiro_crew/monitoring/gitlab_merge_request.py:85) and reports checks_unknown when none is observable instead of a terminal review_ready.
  • Azure carries real statuses_complete / threads_complete / policies_complete flags rather than a len >= 100 proxy.
  • AZURE_CONFIG_DIR is validated before it reaches the sandbox's visible-dirs list (src/kiro_crew/monitoring/provider_cli.py:132); pipe joins are bounded and the reader pool is shut down with wait=False, cancel_futures=True (:241-247).
  • build_pod_env redirects GH_CONFIG_DIR alongside GLAB_CONFIG_DIR / AZURE_CONFIG_DIR and scrubs the JIRA_TOKEN_* family (src/kiro_crew/pod/runtime.py:1756-1806).
  • Credentials are resolved once per probe with propagate=False, so a read-only probe no longer mutates the gateway's environment.

Leftovers (should-fix, not blocking)

  1. docs/request-for-change/rfc-token-efficient-monitors.md frontmatter still reads status: draft, implementation-prs: [], audited-at: 6ce882d5b (not reachable from any ref), and docs/request-for-change/README.md:49 still says "Nothing." The directory's own rule asks for these to be updated in the PR that lands the implementation.

Cross-cutting session-mode and memory notes are in the #5184 review comment.

Execution-verified against a local checkout at 9a6f511d (1817 tests passing across the monitor/provider suites); nothing modified.

Comment thread src/kiro_crew/config/loader.py Fixed
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for ad59854ccbb5d900d54d1f9133e6d28ff5b5d9ae; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ad59854ccbb5d900d54d1f9133e6d28ff5b5d9ae: <one-sentence reason>

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the linked-channel credential-boundary finding in 591aea1. Monitor creation provenance is now persisted independently of the slot binding; Slack-linked immediate, queued, and recovery turns retain channel provenance, and legacy unknown provenance fails closed for Azure DevOps and Bitbucket owner credentials. Focused monitor/provider and messaging/directive/queue suites pass locally.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the current-head mixed-queue credential-boundary finding in 8bce380. Channel provenance now wins for an entire merged queue batch when any consumed entry came from a channel, so adjacent dashboard input cannot widen the turn to dashboard-owner Azure or Bitbucket credentials. The regression failed before the change and passes after it; 83 focused queue/directive tests plus targeted Black, flake8, Linux mypy, docs lint, subprocess-encoding, brand, and diff checks pass. The top remains two commits directly above #5186.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Fixed the fresh CI contract failures in c0dd854: queue-dispatch expectations now preserve channel provenance, the monitor-start test supplies its producer surface, and the workflow nudge fake accepts the persisted creation surface. Focused verification passes all 351 tests in the five affected files both serially and with the repository xdist configuration; formatting, flake8, Linux mypy, docs, subprocess-encoding, brand, and diff gates also pass. The leased force-push has started a fresh CI run.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the current Opus credential-boundary finding in 0c8b2de. A channel-origin monitor_update that changes the target now atomically ratchets a dashboard-created monitor to the channel creation surface, preventing the new Azure DevOps or Bitbucket target from inheriting dashboard-only owner credentials. The regression failed on the prior head and passes with the fix; the composed 1,265-test focused suite passes with 2 platform skips, along with focused Black, isort, flake8, Linux-targeted mypy, docs, subprocess-encoding, and brand gates. The open tail was restacked bottom-up onto current main with explicit leases; no CI job was manually rerun.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the current First Principles blockers on a93bb979d024979fbbbfdf07bb5768ca8c7d7d51:

  • Removed the provider-local suspended-spawn policy copy; source-provider probes now call acp.client.finish_suspended_spawn, while translating its failure into the existing provider SetupError contract.
  • Made both dashboard monitor admission readers use the public is_closing slot API. This fixes the five AutoNudge dashboard-fire failures and the close-admission regression reported by CI.

The two spawn-policy tests and three representative close/admission tests failed on the prior head and pass after the fix. On the final restacked tree, all 134 focused monitor/provider/directive/AutoNudge/Slack tests and all 42 security-conductor contract tests pass, along with focused Black, isort, flake8, Linux mypy, subprocess-encoding, and brand gates. #5185, #5186, and #5305 were restacked and force-pushed bottom-up with explicit leases; no rebase conflicts occurred. No CI job was manually rerun.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 44286dd: GitHub and GitLab are the documented channel allowlist whose providers always require the operator authenticated gh/glab CLI; the protected dashboard grant gates only providers outside that allowlist. The kind fallback preserves the existing authenticated-only provider contract, and adding the suggested DASHBOARD exclusion would break dashboard GitHub/GitLab monitoring without reducing channel credential exposure.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@kyleseaman marked the gpt AI finding as false positive, not applicable, or explicitly accepted for 44286dd4b0a258f78758c54b612745e57d2680fe.

GitHub and GitLab are the documented channel allowlist whose providers always require the operator authenticated gh/glab CLI; the protected dashboard grant gates only providers outside that allowlist. The kind fallback preserves the existing authenticated-only provider contract, and adding the suggested DASHBOARD exclusion would break dashboard GitHub/GitLab monitoring without reducing channel credential exposure.

This decision applies only to this commit. A new push requires a new judgment.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the blocking durable-revocation finding in 5376df955668c85519a8c7b8f5e1cc36eb4f7c9a. Revocation now persists a protected tombstone before deleting the active grant, and credential checks deny a matching tombstone after restart even if grant cleanup failed. Authenticated re-grants clear the tombstone only after the replacement identity is protected. The regression fails on the prior implementation and passes with the fix; all 227 focused provider-trust, controller, directive, authorization, and source-provider tests pass, with focused lint, type, documentation, and repository policy gates clean.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the current GPT blocker and the valid First Principles gh regression on 16e8edae5bde6721d7f00a13b87deeae8366f321.

  • A durable provider-credential revocation is now required before a monitor row can be removed. Tombstone failure aborts removal and retains both the in-memory and persisted row.
  • GitHub monitors again use the established same-user resolve_gh path, preserving stock Homebrew and user-local installs. The protected-chain resolver remains scoped to autonomous glab and az probes.
  • The Bitbucket conflicts route is confirmed by the official Bitbucket Cloud REST reference, which documents GET /repositories/{workspace}/{repo_slug}/pullrequests/{pull_request_id}/conflicts and its redirect to repository file-conflict results; that blocker does not require subtraction.
  • The agent_sdk.finish_suspended_spawn adapter remains intentional: the repository agent-SDK boundary gate passes with this dependency direction, while a direct monitoring → acp.client import would violate that layer boundary.

All 93 focused provider-trust and source-provider tests pass, with Black, isort, flake8, Linux mypy, docs, subprocess-encoding, agent-SDK-boundary, brand, and diff checks clean. The PR remains two commits and exactly based on #5186. CI was not manually rerun.

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Addressed the credential-rollback finding in 83889d5. Generic AutoNudge replacement now restores the displaced structured monitor’s exact active provider grant if the combined snapshot fails, before its timer is re-armed. The regression fails on 5a91c8a and passes on this head; all 270 focused tests and the relevant static/repository gates pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants