Skip to content

fix(slots): stop a folder or tag delete crashing when a tab closes concurrently - #5933

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
rnoack1:fix/slots-snapshot-across-await
Nov 8, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
rnoack1:fix/slots-snapshot-across-await

Conversation

@rnoack1

@rnoack1 rnoack1 commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Deleting a folder or a tag finishes cleanly, with every tab updated and the delete audited, even when a tab closes or the client disconnects at the same moment.

api_chat_folder_delete (src/kiro_crew/dashboard/chat_folders_routes.py) and api_chat_tag_delete (src/kiro_crew/dashboard/chat_tags_vocabulary.py) each walk every slot and persist it with await save_slot_off_loop(...) inside a loop over the live state._slots.values() view.

A tab closing during that await calls _slots.pop, which resizes the dict mid-iteration and raises RuntimeError: dictionary changed size during iteration. The sweep aborts part way, so some slots are stripped and the rest still name a folder or tag that no longer exists.

Why it matters

The delete is not atomic today. Three ways a user loses state:

  1. The crash. The sweep dies mid-way, leaving durable state half-applied.
  2. The ordering. The folder delete unfiles slots before committing the removal, and its rollback can be refused, so a slot can stay durably unfiled while its folder still exists.
  3. The disconnect. asyncio.to_thread hands the vocabulary write to a worker that cannot be interrupted, so cancelling the handler does not stop the bytes landing, but everything after that await (the sweep and the SEL audit) is lost.

Not a goal

What changed (motivation → approach → change)

Symptom: a delete crashes or half-applies when a close or a disconnect lands mid-sweep. Cause: the sweep awaits while iterating the live slot dict, the folder side unfiles before it commits, and a cancellation skips the sweep and the audit.

  • Snapshot, then await. Both handlers strip in one pass with no await, then persist in a second pass.
  • Closes in flight stay visible. close_in_flight (new leaf module src/kiro_crew/dashboard/snapshot_commit.py) registers a slot across the pop/save/restore frame of close_slot and the bulk api_chat_slots_cleanup (chat_api/slot_lifecycle.py), so the sweep also strips a slot that is out of _slots mid-close. Each registration has a unique token, so overlapping closes do not unregister each other.
  • Commit first. The folder delete commits the removal before touching any slot, so a failed commit changes no slot. The old rollback closure is gone.
  • A cancelled delete still sweeps and audits. Both store commits (_commit_tags_snapshot, FolderRepository.mutate) and the sweep wait through the existing chat_utils.run_to_completion, with no new drain loop. A write that landed is still confirmed on the cancelled path. VocabularyDeleteCancellations re-raises the captured cancellation only after the audit line.
  • Removal is confirmed per request. mutate_folders(..., on_committed=...) and _commit_tags_snapshot(..., on_committed=...) fire only after the write is proven on disk. There is no store-wide committed-vocabulary set.
  • Side effect, declared. Every tag and folder write now holds its store lock until a cancelled disk write finishes, so an older in-flight write cannot overwrite a later one.
  • chat_tags.py names the new imports in its type-checking manifest. docs/system-specs/modules/history.md records the order.

Backwards compatibility

Compatible: request and response shapes are unchanged; only the order and the cancellation handling inside the two delete handlers change.

Removes nothing: the deleted _restore_unfiled rollback closure was private to api_chat_folder_delete and had no other reader.

Tests

  • test_delete_tag_strips_a_slot_popped_during_the_vocabulary_write: a slot popped during the tag write loses the deleted tag id.
  • test_a_failed_folder_commit_leaves_every_slot_untouched: a failed folder commit leaves every slot clean.
  • test_a_cancellation_inside_the_commit_still_unfiles_and_still_audits: a cancelled delete still sweeps and writes its audit line.
  • test/test_snapshot_commit_protocol.py: a cancelled tag or folder commit still confirms a landed write, a failed write wins over the cancel (folder rows restored), the sweep finishes via run_to_completion, re-raise order, close registry. Every completion await is bounded by await_until.
  • test/test_slot_close_recreation_race.py: the slot popped by the bulk cleanup is visible to a sweep, and unpublished after.

Nearby inputs also run: every test module that calls close_slot or api_chat_slots_cleanup, the folder/tag/channel-folder suites and all facade guards (about 7,000 tests, green). flake8, black, isort and mypy clean.

Proof: not provable -- other: the changed tests import the new snapshot_commit module, so with production reverted they fail at collection; the author showed the three reproductions red on the pre-fix base with only the tests applied.

Manual verification

N/A: unit coverage sufficient. The failures are specific interleavings, which the tests reproduce against the real routes.

Related Issues

Sibling sweep

Swept: git grep -nE "for .* in state._slots.(values|items)()" -- src, then checked each loop body for an await
Siblings: none -- the two delete sweeps were the only live-view loops with an await inside

Pattern harvest

Rule candidate: semgrep
Pattern: an await inside a for loop over a live state._slots view

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Aug 25, 2026
@dwu96

dwu96 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@rnoack1
rnoack1 marked this pull request as ready for review August 25, 2026 20:02
@rnoack1
rnoack1 requested review from a team and buluoray August 25, 2026 20:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 648e68d737b5a0de813954c95e28cadb10c1ba97 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: committing before the sweep, two-pass iteration and the shielded sweep plus audit fix all three harms the description names, and they reuse existing seams (on_committed, run_to_completion, expected_slot_name).

Notes

  • Commit-first brings back the window the deleted comment warned about: a folder gone while slots still hold a dangling folder_id. That is safe only because "dangling id pruned on next load" holds for both stores. A sentence in history.md that names the pruner would show it is a decision, not luck.
  • close_in_flight puts every slot-popping path under one obligation: "A second popping path left unwrapped reopens the hole in full." The deferred semgrep/build gate (Add build gates for the slot-sweep invariants, including the semgrep rule #26164) is what keeps that obligation enforced, so it should land soon.

[DESIGN-REVIEWED] 648e68d

Description read

[DESCRIPTION-READ] e7a46050a4290a99a36e8096005e68595eafaf5d388c05ac5d203794607a6e3a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 648e68d737b5a0de813954c95e28cadb10c1ba97 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 648e68d

@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 648e68d737b5a0de813954c95e28cadb10c1ba97 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The new close-in-flight capture, the registry and the slot-name pin protect against a stale id that the base code already says is pruned when the store next loads.

Notes

  • Item 4 — oversized: the pre-commit closing capture, close_in_flight / slots_with_a_close_in_flight and their two wrap sites only matter when a close's own save fails and the slot comes back still naming the deleted id. The base code already covers the durable half of that: "a dangling id on disk is pruned on the next load" and "a dangling folder_id left on the old transcript is ignored on the next load". Subtraction: delete closing, the registry and both close_in_flight wraps, then the expected_slot_name pin, which exists only because of the capture (item 5). Clears when: the mechanism is removed, or a human amends the Goal.
  • Item 9 — undeclared: after an unproven cancel, the tag comes back in memory with its grant still revoked ("Present but closed"). The description never says this.
  • Item 8 — one consumer, generalized: "THE FIRST SWEEP CANCELLATION WINS" assumes several sweeps, but each handler calls capturing_sweep once (2 call sites). Subtraction: replace it with a single assignment.

What this change ships

Inventory (9 items) — 5 justified

Intent: Deleting a folder or tag finishes fully and is audited even if a tab closes or the client disconnects mid-delete. FIX.

  1. Folder/tag delete no longer crashes when a tab closes mid-sweep — justified
  2. Folder delete removes the folder before unfiling; the rollback is gone — justified
  3. A cancelled delete still sweeps, pushes the update and writes its audit line — justified
  4. Slots being closed are visible to the delete sweeps — oversized
  5. Sweep saves are pinned to the slot name, so a completed close isn't resurrected — oversized; only needed because of item 4's capture
  6. Every tag/folder write holds its lock until a cancelled disk write finishes — justified
  7. One shared tag-commit path with a confirmation hook — justified
  8. Shared cancellation ledger, "first sweep wins" — one consumer, generalized
  9. After an unproven cancel the tag returns with its grant revoked — undeclared

[FIRST-PRINCIPLES-REVIEWED] 648e68d

Description read

[DESCRIPTION-READ] 30d9458d2df17f75c312117e677b8e90e73c7b72915c0d9dc13e724a03e1bbab

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 648e68d737b5a0de813954c95e28cadb10c1ba97 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 648e68d

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Aug 25, 2026
@rnoack1
rnoack1 force-pushed the fix/slots-snapshot-across-await branch from 5fcb630 to 3040073 Compare August 25, 2026 22:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Aug 25, 2026
@rnoack1
rnoack1 force-pushed the fix/slots-snapshot-across-await branch from 3040073 to 30431ab Compare August 25, 2026 22:46
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Aug 25, 2026
@rnoack1
rnoack1 force-pushed the fix/slots-snapshot-across-await branch from 30431ab to 30b2a43 Compare August 25, 2026 23:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Aug 25, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Not approving for now: the description itself defers the merge-aware-save layer fix to #8361 and states that whether the interim guard/adopt protocol is acceptable is a maintainer decision, which is exactly the kind of unresolved blocker I should not sign off past at 10660 added lines.

@bolichen97

Copy link
Copy Markdown
Contributor

A maintainer attempted a conflict-only rebase of this PR onto main cff7de54 (2026-09-19) but did not push, because the conflict is semantic rather than textual and resolving it needs changes outside the conflict hunks -- which is the author's call. Nothing on this branch was changed.

What blocks a mechanical rebase:

  • The four textual conflicts (chat_folders.py, chat_handlers.py, chat_persistence.py, chat_tags.py) resolve by keeping both sides, and 137 targeted tests pass -- but the PR's function-keyed vocabulary gate then fails structurally: hydration moved to _hydrate_slot_from_history, and _apply_chat_tag now performs assignments the gate does not recognise. The snapshot fix itself still applies; the gate needs re-keying against current main.

Once rebased onto current main with the above reconciled, readiness should re-evaluate on the new head.

Copy link
Copy Markdown
Contributor

PR triage (2026-10-05): REBASE, keep open

Checked the full diff at head c743e41dfe (merge base 80bd0a81f1) against origin/main af1eb612da.

  • This fix is still needed. Main still awaits inside a loop over the live slot dict: chat_folders.py:2377 (for slot in state._slots.values(): with await save_slot_off_loop(...) at :2387, then the _restore_unfiled rollback at :2404/:2460). The same pattern is at chat_tags.py:1225/:1236. snapshot_commit.py does not exist on main, and no merged PR fixes this. This is not SUPERSEDED.
  • Rebase needed. The branch is mergeable_state: dirty and 1943 commits behind main. The handlers have moved about 800 lines since the base (api_chat_folder_delete is now at chat_folders.py:2218, and api_chat_tag_delete is at chat_tags.py:1152). The semantic re-keying described in the 2026-09-19 maintainer note still applies.
  • Overlaps to resolve during the rebase:
  • Still open: the two blocking findings from the GPT review (bulk api_chat_cleanup pops outside close_in_flight, and the id(slot) token is not reference-counted when two closes overlap). Please address them in the rebased head. I'm not repeating them as a new review.
  • The description's "committed-vocabulary signal" section (publish_committed_*) still describes code this diff doesn't ship. Please update it to describe the per-request on_committed hook.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 648e68d737b5a0de813954c95e28cadb10c1ba97 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@iamwhatever

Copy link
Copy Markdown
Contributor

First Principles BLOCK on 1344213 (second spelling of run_to_completion): fixed in c900812.

fixed: sweep_to_completion_despite_cancellation is deleted from snapshot_commit.py.
Both delete handlers now call chat_utils.run_to_completion(...) inside capturing_sweep() (chat_folders_routes.py, chat_tags_vocabulary.py).
The sweep tests in test/test_snapshot_commit_protocol.py now drive run_to_completion directly: the sweep still finishes after a cancel, and a sweep failure still wins over the cancel.
self-added: no
mechanism: remove the duplicate helper, reuse the existing one

Notes (no reply required, answered for the record):

  • Item 5 (close_in_flight oversized): kept. The GPT lane blocked c743e41 because the bulk cleanup was not wrapped and the token was not unique; removing the registry would bring that data-loss finding back. Declared in the description.
  • Item 6 (lock held until a cancelled write finishes): now declared in the description under What changed. Folding drain_shielded into drained_to_thread is listed under Not a goal.

@iamwhatever

Copy link
Copy Markdown
Contributor

GPT 6.1 finding on 1344213 (test/test_snapshot_commit_protocol.py:81, unbounded completion awaits): fixed in c900812.

fixed: every completion await in test/test_snapshot_commit_protocol.py (the drain, both commit tests, both sweep tests) goes through a _bounded(task, what) helper built on kiro_crew.testing.wait.await_until, which cancels the owned task if the bound fails.
test/test_slot_close_recreation_race.py bulk-archive test: await close is now await_until(close, what=...) with the same cleanup.
A hang now fails by name instead of reaching the global pytest timeout.
self-added: yes
mechanism: bound test awaits with await_until

@iamwhatever

Copy link
Copy Markdown
Contributor

First Principles BLOCK on c900812 (second spelling of the cancellation-drain loop): fixed in e048c3d.

fixed: drain_shielded and commit_snapshot_while_holding_the_lock are deleted; snapshot_commit.py defines no drain loop.
_commit_tags_snapshot and FolderRepository.mutate now await run_to_completion(write), confirm on success, and on CancelledError confirm only when the write itself was not cancelled, then re-raise.
A failed write still wins over the cancel (raised by run_to_completion), and the folder rows are restored on it.
Tests in test/test_snapshot_commit_protocol.py now drive the two real store commits with a gated worker-thread writer.
self-added: no
mechanism: reuse run_to_completion for the store commits

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on head e048c3d for missing follow-up issues.

The description's Not a goal section says six items are kept on the fork branch archive/slots-snapshot-full-10-items for separate PRs: restore-time pruning of deleted vocabulary ids, tag-prune reader consolidation, in-flight-delete refusals, parked-slot tag revalidation, a metadata-only sweep persist, and the AST gate families (including the semgrep rule under Pattern harvest). None of these has a GitHub issue. Please open an issue for each item you still plan to do and link them in the description, or drop the promise for any you do not.

The fix itself looks sound. Snapshot-then-await removes the dict-resize crash, the folder delete now commits before it unfiles, the sweep and audit survive a cancellation, and close_in_flight is keyed per registration (snapshot_commit.py#L76). All checks on this head are green.

After the issues are linked, a maintainer still needs to review this PR. It changes delete handlers, the close lifecycle, and a path that re-mints a revoked tag grant on an unproven cancelled commit (chat_tags_vocabulary.py#L703-L728).

AI findings judged non-blocking:

  • Design Review note 1: nothing enforces close_in_flight registration for future pop paths. Today the only pop-save-restore frames are close_slot and api_chat_slots_cleanup, and both are wrapped (slot_lifecycle.py#L534).
  • Design Review note 2: the store lock is held until a cancelled write finishes. The description declares this, and releasing the lock early is the ordering bug this PR fixes (folder_repository.py#L95-L105).

— crew-pr-reviewer (r133)

@rnoack1

rnoack1 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever Your 2026-10-28 change request (follow-up issues for the "Not a goal" items) is addressed at head e610d2f.

The second "Not a goal" bullet in the description now links one issue per item:

This head is a plain rebase onto main with no content change. Every per-file git patch-id --stable matches the previous head, 443a7a2.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on head ed78a92.

The follow-up issues from my earlier review are linked and match the Not-a-goal items (#26159, #26160, #26161, #26162, #26163, #26164, plus #8361). The snapshot-then-await sweep, commit-first folder delete and per-token close_in_flight look sound, and all checks on this head are green.

Blocker: the unproven-cancel branch of the tag delete re-opens a revoked grant.

When the vocabulary commit is cancelled and never confirmed, the handler restores memory and re-mints the grant it revoked (chat_tags_vocabulary.py#L743-L749, #L723-L732). Because run_to_completion shields the write from the handler's own cancel, "not confirmed" only happens when the write task itself is cancelled (chat_tags_store.py#L130-L140), for example by asyncio.run cancelling every task at gateway shutdown. At that point the to_thread worker may already be running and can still land the deletion in tags.json. The result is a grant row for a tag id that no longer exists in an agent-writable file, which is the stale-open state this handler's docstring rules out (#L655-L670). Before this PR a cancelled write escaped except Exception and the grant stayed revoked.

Smallest fix: on that branch, restore the tag in memory but do not re-mint the grant, leaving the documented "present but closed" state that the owner can re-adopt. Please add a test that cancels the write task directly and asserts no grant row remains.

AI findings judged non-blocking:

  • Design Review note 1: cite the load-time folder_id prune in the spec. A documentation nit with no user-visible effect.
  • Design Review note 2: close_in_flight wrapping is enforced only by review. Both current pop-save-restore frames are wrapped, and #26164 tracks the gate (snapshot_commit.py#L98).
  • First Principles note, item 4: the registry is oversized. The author kept it because removing it reopens the earlier GPT bulk-cleanup finding. It is a note, not a BLOCK.

This PR changes delete handlers, the close lifecycle and tag-grant restoration, so a maintainer still needs to review it even after the fix.

— crew-pr-reviewer (r148)

@rnoack1

rnoack1 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever The blocker from your review of ed78a92 (the unproven-cancel branch of the tag delete re-minting the revoked grant) is fixed at head 3559e76.

  • src/kiro_crew/dashboard/chat_tags_vocabulary.py:744-751: when the commit is cancelled and never confirmed, the handler now puts the tag back in memory and does not re-mint the grant. The tag is left present but closed, so the owner can re-adopt it. The failure branch (except Exception) still re-mints, because a failed write did not land.
  • test/test_forced_save_history_key_pin.py:581, test_a_cancelled_write_task_never_reopens_the_revoked_grant: holds the to_thread worker mid-write, cancels the write task itself, then lets the worker land the removal in tags.json. It asserts the tag is gone on disk and no grant row remains. With the old branch restored, it fails on the grant-row assertion. With the fix, it passed 5 of 5 runs.

The spec citation nit (load-time folder_id prune) is not in this push.

bolichen97
bolichen97 previously approved these changes Nov 7, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 4b78ca6. The folder and tag deletes now snapshot the slots before awaiting, include tabs whose close is in flight (close_in_flight), and commit the store write first, so a tab closing or a client disconnecting mid-delete no longer crashes it or skips a tab. On a cancelled, never-confirmed vocabulary commit, the tag comes back in memory with its grant still revoked, present but closed. A failed write still restores the grant, because that write never landed. No regex is added, and all checks pass.

@iamwhatever, could you re-review? Your change request at ed78a92 was that the unproven-cancel branch of the tag delete re-minted the revoked grant. At this head that branch restores the tag without re-minting the grant.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 4b78ca646233e267f9bdaeb3e548b6438fde8498: this changes tag-grant restoration, delete ordering and the close lifecycle, which our rules reserve for a human. @bolichen97 has approved this head as that reviewer.

The blocker from our r148 review is fixed. When the vocabulary commit is cancelled and never confirmed, the tag comes back in memory and the revoked grant stays revoked (chat_tags_vocabulary.py#L743-L751). A failed write still restores the grant, because that write never landed. The new test cancels the write task mid-write, lets the worker land the removal, and checks that no grant row remains. Since ed78a92 the only other changes are rebase import churn. The linked follow-ups (#26159, #26161, #26163, #26164, #8361) match the Not-a-goal items.

Our change request at ed78a92 is answered and can be dismissed. We add no bot approval because the maintainer approval covers the reserved paths.

AI findings judged non-blocking: Design note 1 (only prose enforces close_in_flight for future pop paths; both current frames are wrapped and history.md states the rule, though #26164 does not list this pairing yet); Design note 2 (the present-but-closed tag state is described only in a code comment; a doc gap); First Principles item 9 (the first-wins guard has one caller; a simplification). All checks are green and GitHub reports the PR mergeable.

— crew-pr-reviewer (r149)

…ncurrently

The sweep awaited a slot save while iterating the live ``_slots`` view, so a concurrent
close resized the dict mid-loop; the delete now commits first and sweeps a snapshot.
@iamwhatever

Copy link
Copy Markdown
Contributor

@bolichen97 rebased onto main as 648e68d73 (only a rebase; one import conflict in slot_lifecycle.py). The push dropped your approval at 4b78ca646; could you re-approve once CI is green?

@rnoack1

rnoack1 commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever I re-checked both of your change requests at the current head, 648e68d (a rebase onto main, no content change).

The non-blocking spec citation note is not addressed in this head.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again at 648e68d. Against our approval at 4b78ca6, the range-diff shows only a rebase onto main: the commit's own patch is unchanged, and the only difference is main's import line in slot_lifecycle.py. All checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants