Repository navigation
feat: AgentCore core interfaces and governance schema - #6594
Conversation
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Sound inert-slice design; the ride-along CapabilityGate strictness change and per-scope parser hooks are the two things a human should consciously accept. Watch
Suggestions
[DESIGN-REVIEWED] 0d5e146 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsFINDING -- src/kiro_crew/platform/agentcore_schema.py:45 -- False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All mechanical checks are done. Counts verified: the six non- First-Principles-Verdict: CONCERNS
What this change shipsIntent: land the inert contract (interfaces + governance schema) that the later AgentCore identity/Gateway PRs attach to. ADDITION.
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 0d5e146 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Stack review summary The six-PR decomposition is a substantial improvement: each layer now has a coherent trust boundary, the unrelated main-branch reversions are gone, and the ordering is mostly right. The stack is not mergeable yet. Confirmed blockers by layer:
I would fix the base contract and principal layer first, then rebase the remaining stack before reviewing downstream behavior again. In particular, the proxy authentication design and the principal-at-session-create contract affect several later fixes. |
UX Review (Fable 5) — ⏭️ skippedRevision |
e559056 to
83e6eff
Compare
83e6eff to
3da2524
Compare
163db12 to
31dd32b
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Re-approving after conflict-resolution rebase (single conflict in the RFC README index, both rows kept; commits squashed to one per PR Hygiene; 18 files unchanged in scope).
31dd32b to
02b4ebb
Compare
02b4ebb to
e16d646
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Full-diff maintainer review passed: change matches its stated scope, no regressions or trust-boundary weakening found, checks green and no outstanding change requests. Approving.
Problem / Motivation
The AgentCore identity + Gateway work landed as one ~18k-line PR (#6387, 111 files). That form mixes independent security boundaries and is too large to review. This is PR 1 of 6 in a stacked split by trust boundary. Each PR is merge-safe and inert by default.
Why it matters
Reviewers of governance and the CPP contract should not also have to review SigV4, OAuth consent, or Settings UI. A schema-only first PR lets that review happen on a small, AWS-free surface.
What changed (motivation → approach → change)
Goal: land the contract later PRs attach to, without turning anything on.
AgentIdentityProviderProtocol +WorkloadIdentity/SessionPrincipal/InboundTokentypesDefaultAgentIdentityProviderno-op (enabled() -> False; no tokens, no Gateway spec)PlatformContext.agent_identityslot (CONTRACT_VERSION stays 1)capabilities.agentcorecatalog row (capability_default=False)posture/gateway_url/workload_namewith fail-closed unknown postureplatform/agentcore_schema.pyso governance never imports boto3_agent_identity_enabled()three-conjunct probe (adapter AND capability AND known posture)agentcore-inboundreserved on the keystone leaf list (writer comes later)CapabilityGate.from_dictnow rejects a non-booleanenabledthe same wayScopedRuleset.modealready does. A profile or policy that previously coerced"false"/1/"0"will fail composition instead of silently permitting. This is the existing gate parser, not AgentCore-only.Unrelated Node/theming/Discord reversions from #6387 are not in this stack.
Later PRs (stacked on this one):
#6387 will be closed as superseded once the stack is up.
Tests
TestAgentIdentitySeamintest_platform_cpp_seam_coverage.py: Default disabled, opt-in catalog, fail-closed posture, policy-only keys rejected on profiles, https-only gateway URL, three-conjunct probe stays off without capability/posturetest_fully_enumerated_block_reports_no_gapsupplies a known agentcore posturetest_platform_cpp_seam_coverage.py+test_governance_policy.py)Manual verification
N/A — this PR is inert. No Settings UI, no AWS calls, no Gateway inject. Unit coverage is the verification.
Related Issues
Supersedes the schema/CPP portion of #6387.
Checklist