Repository navigation
feat/agentcore 2 principal - #6772
kyleseaman wants to merge 2 commits into
Conversation
Partition SessionPrincipal as {surface}+{raw_id} at turn start.
Injected cron/subagent envelopes skip bind. Existing
publish_turn_identity callers that omit surface/raw_id stay
byte-identical. No Gateway attach or AWS in this slice.
CLI identity comes from the process UID or token SID, not environment usernames. Automated turns omit raw_id and publish after session acquire so a concurrent human principal is not cleared mid-stream. Live-credential retract belongs to the later Gateway layer.
First Principles Review (Fable 5) — 🔴 BLOCKPremise-level review of Verification is complete. All consumer counts were run against the merged HEAD checkout; the review follows. First-Principles-Verdict: BLOCK Dashboard/queue principal plumbing feeds What this change shipsIntent: record which human is speaking on each session so a later AgentCore login/token-vending layer can act as that user — an ADDITION (stack part 2). The PR description is the untouched template: every item below is undeclared.
BlockersDashboard principal stamping terminates in a sink the PR itself pins shut. Grepped Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 07a2ea0 |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of All the evidence is in. The channel-side design (core-derived subjects, fail-closed exclusivity, injected-envelope skip, annotate-not-replace) is coherent; the problems are the incomplete dashboard-bind reversal and a fail-open provenance default. Design-Verdict: CONCERNS Sound principal model, but commit 2's dashboard-bind reversal left the spec contradicting itself and orphaned identity plumbing the next stack PR will misread. Watch
[DESIGN-REVIEWED] 07a2ea0 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Review detailsBoth candidates hinge on the same unconfirmed caller: a genuine human turn reaching the changed For every confirmed real caller the flip does not occur:
I opened Separately, the dashboard principal-binding half has no current consumer: No findings. [OPUS-REVIEWED] 07a2ea0 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Why it matters
What changed (motivation → approach → change)
Tests
Manual verification
Screenshots / video
Related Issues
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement