Repository navigation
feat/agentcore 3 aws - #6773
feat/agentcore 3 aws#6773kyleseaman wants to merge 2 commits into
Conversation
Land the inert AWS extra and launch-path identity so later Gateway and login PRs have something to attach to. Default-off: no policy or env posture means no boto3, no extra install, no adapter swap. Workload gateway_mcp_spec returns the https hostname and does not import the SigV4 proxy; that rewrite belongs in the next PR.
resolved_* reads the composed ceiling first. Workload Allow is GetWorkloadAccessToken only; UserId stays on the login Deny. Inspect is Get/List/GetTarget — no Synchronize. Dashboard launch stays none.
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Sound, well-staged opt-in adapter and boundary design — but a 2,600-line IAM-sensitive diff shipped with a completely empty PR description. Watch
Suggestions
[DESIGN-REVIEWED] 9db6b9d |
Opus 4.8 Review — ✅ no blocking findingsReviewed Review detailsBoth candidates die under falsification:
No new grounded finding surfaced during falsification: the launcher policy correctly withholds No findings. [OPUS-REVIEWED] 9db6b9d Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All evidence gathered; counts verified. Final review follows. First-Principles-Verdict: CONCERNS A quarter of this surface — self-pip-install, probes, hot-apply, dashboard launch plumbing — has zero consumers; two doc sentences describe code that doesn't exist. What this change shipsIntent: let an operator give a cloud-launched crew an Amazon Bedrock AgentCore workload identity (CFN resource + posture-scoped IAM) with a default-off AWS identity adapter — an ADDITION. The PR description is an untouched template, so every item below is undeclared.
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 9db6b9d |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Why it matters
What changed (motivation → approach → change)
Tests
Manual verification
Screenshots / video
Related Issues
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement