Repository navigation
feat/agentcore 4 gateway - #6774
kyleseaman wants to merge 2 commits into
Conversation
Workload inbound is IAM. kiro-cli cannot sign InvokeGateway, so the adapter rewrites gateway_mcp_spec onto a 127.0.0.1 listener and session/new injects that live loopback URL. The unsigned hostname never reaches the agent file. Login sidecars and consent stay out.
Loopback is same-host, so each hop carries an HMAC-bound session token. Request-time signing requires the calling session's profile to still permit AgentCore and the composed posture to be workload — login uses JWT inbound, not instance IAM.
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All evidence is gathered: the patch, the intent file (an entirely unfilled template), consumer counts for the new endpoints (zero in First-Principles-Verdict: CONCERNS A ~950-line, 3-endpoint dashboard catalog rides along undeclared — zero UI consumers — in a PR whose own docs describe only the SigV4 proxy. What this change shipsIntent: let kiro-cli call the workload AgentCore Gateway by re-signing its MCP traffic through a localhost SigV4 proxy — an ADDITION (the stack step
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 164d6e1 |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Sound proxy/inject design, but the new sync endpoint invokes an IAM verb the project's own instance policy deliberately withholds, and the PR description is empty. Watch
[DESIGN-REVIEWED] 164d6e1 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Review detailsI've now established the key facts to falsify Candidate 1:
The candidate's own confidence line concedes it "could not confirm that the AcpClient (non-runtime) inject path is ever exercised for a session whose kiro name and crew-agent name diverge." I cannot re-derive (a) a concrete input that occurs in practice — it resolves to "if a caller were to." Dropped. No new grounded finding surfaced during falsification that meets the 80+ bar (the secret-stripping, loopback-only, posture, and per-hop recheck paths are all internally consistent and guarded). No findings. [OPUS-REVIEWED] 164d6e1 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Why it matters
What changed (motivation → approach → change)
Tests
Manual verification
Screenshots / video
Related Issues
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement