Repository navigation
refactor: extract issue radar client boundaries - #7604
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Spawn chokepoints verified: Design-Verdict: PASS Behavior-preserving decomposition that keeps the façade seams, spawn-audit chokepoints, and exception identity intact — the right shape for this split. [DESIGN-REVIEWED] e7a1d3d |
Keep the provider clients as stable compatibility facades while moving transport, normalization, and GitHub query planning into focused sibling modules. Preserve existing call signatures, patch seams, exception identity, CLI spawn chokepoints, and provider output shapes.
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of I have the full picture and every count I need. Composing the review. First-Principles-Verdict: CONCERNS The injection layer defends monkeypatch seams that had zero users before this PR invented them, and the "easier to review" split ships +418 net lines with the façades still 3,193/2,579/1,808 lines. What this change shipsIntent: restructure the three Issue Radar provider clients into façade + transport/normalization/query modules so future provider changes are easier to review, preserving behavior — an ADDITION of structure, repairing no defect.
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] e7a1d3d |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
62d9979 to
e7a1d3d
Compare
Problem / Motivation
Issue Radar's provider clients combine their stable route-facing API with transport mechanics, payload normalization, and query orchestration. That coupling makes provider changes harder to review and risks breaking long-standing import and monkeypatch seams.
Why it matters
Routes, parity checks, tests, and spawn audits rely on
github_client,gitlab_client, andazure_clientas stable provider boundaries. Separating responsibilities makes those implementations easier to maintain without changing provider behavior.What changed (motivation → approach → change)
*_transport.pyand*_normalization.py.github_queries.py.This refactor is intended to be behavior-preserving: no request or provider behavior is meant to change, and no UI files or user-facing workflows changed.
Tests
e7a1d3d: 1,364 passed, 57 skipped, with one xdist deprecation warning.test/test_app_art_route.pybecause this Windows host lacks symlink privilege (OSError [WinError 1314]); no Issue Radar test failed. Linux CI remains authoritative for those symlink-dependent cases.Manual verification
Local GPT-contract and reduced-fidelity Opus-contract reviews at
e7a1d3dreported no findings; true Claude was unavailable locally.N/A — there is no UI change, so product walkthroughs and screenshots/video are not applicable.
Related Issues
No linked issue: this is an internal behavior-preserving refactor.
At review time, the sole overlap with an open PR is #7560, which adds explicit UTF-8 decoding to
azure_client.py. That behavior change is intentionally not absorbed here:_az_runretains its currenttext=Truedecoding so this refactor remains behavior-preserving.Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement