Skip to content

feat: show a file tab's full path as its hover tooltip - #7935

Merged
bolichen97 merged 2 commits into
kirodotdev:mainfrom
mitrajparmar93:feat/tabchip-path-tooltip
Sep 23, 2026
Merged

bolichen97 merged 2 commits into
kirodotdev:mainfrom
mitrajparmar93:feat/tabchip-path-tooltip

Conversation

@mitrajparmar93

@mitrajparmar93 mitrajparmar93 commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

A side panel tab chip labels itself with the file's basename inside a max-w-[240px] truncating span, and carried no title attribute at all unless it was one of the icon-only pinned view chips. So on hover the chip tells the user nothing the label did not already say. Two things a user cannot do today:

  • read the rest of a filename that CSS-truncated at 240px
  • tell two tabs holding a same-named file from different directories apart (/repo/alpha/index.ts and /repo/beta/index.ts render the identical chip) without clicking each one and reading the breadcrumb in the panel body

Why it matters

Reported in #7900. The truncated label is frequently ambiguous — repos contain many same-named files (index.ts, config.json, AGENTS.md), and the only way to confirm which one a tab holds is to click it, which changes what the panel is showing just to answer an identity question. The breadcrumb bar in the panel body already carries the full path; the chip is the surface a user hovers first, and it was the one surface that did not.

What changed (motivation → approach → change)

Goal: make the chip answer "which file is this?" on hover, without adding a second tooltip mechanism or new user-facing strings.

Approach: the chip already receives the tab object, and file, diff and folder tabs all carry the absolute path on it as path. Rather than recomputing or threading a new prop, prefer that existing field as the tooltip and fall back to the current value. The alternative considered — a custom hover card on the chip — was rejected as far more surface for a value the native title already renders, and the chip's title is also the accessible name for the icon-only pinned chips, so it has to stay a single string.

The change, in website/src/pages/chat/SidePanel.tsx:

  • TabChip's tab prop type widens from Pick<PanelTab, 'title'> & Partial<Pick<PanelTab, 'kind' | 'sessionId'>> to include 'path', so the optional field is visible to the component.
  • title={tab.title} becomes title={tab.path ?? tab.title}. Tabs with no path (terminal, app, and the icon-only pinned view chips whose glyph needs a name) are untouched by the nullish fallback.

That is the whole source delta: 2 lines changed plus a comment, in one component. No i18n catalog changes, because no new string is introduced — the value shown is a path that already exists in state.

Screenshots

Side panel tab strip with two index.ts chips: on origin/main the hover names only index.ts, on this branch it names the full path

Both halves are the REAL built bundle behind the screenshot harnesses' usual
gateway-free static server, same two tabs, same hovered chip: the top half is
origin/main, the bottom half is this branch.

A title is drawn by the browser as its own chrome, not as page content, so it
cannot appear in a page screenshot (scripts/capture-reveal-label-sweep.mjs
records the same limitation). The pale bubble in each half is therefore painted
by the capture harness from the value it reads off that chip's real title
attribute — the house pattern from scripts/capture-composer-default-agent-marker.mjs
— and the harness asserts the attribute's exact value before it writes a frame,
so a stale bundle fails instead of being saved as evidence:

  • origin/main: both chips' title is index.ts
  • this branch: …/packages/checkout/src/index.ts and …/packages/catalog/src/index.ts
  • both bundles: the icon-only pinned chips (Changes / Artifacts / Files) keep their names

The same PNG is committed at website/temp-screenshots/7935-tabchip-path-tooltip/tabchip-path-tooltip.png,
and attached to this description so the review lanes can open it.

Backwards compatibility

Compatible: the prop type only widens (an added optional field), and ?? changes the rendered tooltip only for tabs that carry a path — every tab that has none keeps tab.title byte-for-byte, including the pinned chips that depend on title as their accessible name.

Tests

New website/src/test/sidePanelTabChipPathTooltip.test.tsx, four cases, each locking in one half of the ratchet:

  • a file tab opened at a deep path is titled with that absolute path, not the basename
  • two same-named files in different directories are distinguishable, because both chips' title values appear and differ
  • a folder tab is titled with its path (so the behaviour is not file-tab-only)
  • the icon-only pinned chips keep their accessible name — the regression guard, so this change cannot strip the only name a glyph-only chip has

Verified as a real ratchet, not a tautology: with the source change stashed, the first three assertions fail with expected null, while the pinned-chip guard passes both ways.

Gates run locally in a dedicated worktree:

  • npx tsc -b — clean
  • npx vitest run (full frontend suite) — 1764 files, 27,706 passed, 1 expected-fail, 2 skipped
  • npm run jscpd — 0 clones
  • backend cross-surface guards (the 416 files scripts/ci-surface-tests.py --surface backend selects for a frontend-only diff)

Two pre-existing failures on this host, both confirmed identical on a pristine origin/main tree with the change stashed and the new test file moved out, so neither is introduced here:

  • website/electron node suite: exit 1 with 1552 tests, 1525 pass, 0 fail, 26 cancelledByParent in test/gateway-stop.test.js
  • backend guards: 40 failures across 8 files, same distribution on main — ops_mission_control/tests/test_routes.py, test_sandbox_argv.py, test_acp_client.py, test_acp_runtime.py, test_browser_cli_install.py, test_terminal_handler.py, test_host_isolation_floor.py, auto_improvement/tests/test_dogfood_learnings.py. These look environment-specific (this host clamped pytest to 2 of 12 workers on available memory, which is itself what the worker-budget assertion checks)

No Python source is touched, so isort, flake8 and mypy have nothing in this diff to act on.

Related Issues

Reported in #7900.

Note on CI

Opened from a fork, so the three Bedrock-credentialed AI review checks are skipped by design per CONTRIBUTING.

@mitrajparmar93
mitrajparmar93 requested review from a team and buluoray September 2, 2026 17:08
@dwu96

dwu96 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

1 similar comment
@iamwhatever

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 2, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Open PR relationship audit

This is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion.

Relationship findings

  • PR #7975 is OVERLAPPING relative to this PR. The goals differ or the implementations can complement each other; this is not a duplicate claim. Recommended action for PR #7975: REBASE. Independent, complementary edits to one component; both can land with a trivial textual resolution. Files: website/src/pages/chat/SidePanel.tsx.

No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit.

@dwu96

dwu96 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

3 similar comments
@dwu96

dwu96 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@iamwhatever

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@dwu96

dwu96 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@dwu96

dwu96 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

2 similar comments
@dwu96

dwu96 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@iamwhatever

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main 2b060c18 by a maintainer as part of the 2026-09-08 open-PR audit.

Conflicts: none, clean rebase. The single line this PR edits in website/src/pages/chat/SidePanel.tsx was still byte-identical on main, so the change applied unchanged. No behaviour was altered.

Gates run locally: npx tsc --noEmit -p website/tsconfig.json clean; npx vitest run src/test/sidePanelTabChipPathTooltip.test.tsx 4/4 passing on top of current main (this was the risk item, since #7975 reshaped TabChip's icon lookup and pinned-descriptor plumbing after your branch point).

Please review the rebased head. Note that a maintainer push makes the maintainer the last pusher, so under this repo's last-push rule a second approver is needed before merge. Reply here if anything looks wrong.

@dwu96

dwu96 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 9, 2026
@NicholasRBowers NicholasRBowers added the needs-pr-triage PR scanner: awaiting automated triage label Sep 13, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor

Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable -- I'll push fixes directly to this branch as a co-author.

Assessment: Two mechanical blockers, no design change. (1) The branch is dirty -- a merge conflict returned after the 2026-09-08 maintainer rebase; the diff is a small 130-line frontend-only change (SidePanel.tsx tooltip + its test), so the conflict resolution is guided by the PR's clear intent against main's current tab-chip code. (2) All pull_request CI is stuck at action_required because the fork workflow-approval gate is suppressed: the PR description uses ## What / ## Why / ## Testing instead of the template's required ## Problem / Motivation, ## Why it matters, ## What changed, ## Tests, so the Fork PR Description gate is red and auto-approval never resumes. Fix plan: rebase-resolve onto current main, then rewrite the body to the exact template headers (same content, template section names) to restore fork auto-approval and let CI run.

If you'd prefer I don't touch this PR, add the pr-no-autofix label.

@chenmingwei23 chenmingwei23 added drive-to-green PR claimed by drive-to-green pipeline and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 13, 2026
@iamwhatever
iamwhatever force-pushed the feat/tabchip-path-tooltip branch from 7fc442b to baff61d Compare September 21, 2026 19:11
@iamwhatever

Copy link
Copy Markdown
Contributor

Rebased onto current origin/main by a maintainer (was conflicting) and force-pushed once — new head baff61d65.

Conflict resolved (website/src/pages/chat/SidePanel.tsx)

Merged #9868 landed an unconditional title={tab.title} on the chip plus data-testid={testId}, and merged #7975 narrowed TabChip's tab prop from the full PanelTab to Pick<PanelTab, 'title'> & Partial<Pick<PanelTab, 'kind' | 'sessionId'>> so the host's leading tab can supply a title-only chip. Re-applied the PR's intent onto that shape:

  • title={tab.path ?? tab.title} — the path still wins whenever the tab carries one, and every other chip (terminal, app, the icon-only pinned views) keeps the name MCP App side-panel tab chip should use the app's name instead of the fixed "MCP App" label #9868 gave it. The PR's original pinned && !showLabel fallback is no longer needed, since main now names every chip.
  • Added 'path' to the prop's Partial<Pick<...>> list so the narrowed type can read it; aria-label and data-testid are untouched.

Tests run (Node 24, website): npx vitest run src/test/sidePanel src/test/SidePanelLayout src/test/panelTab src/test/usePanelTabs.test.ts → 25 files / 235 tests passed, including this PR's own sidePanelTabChipPathTooltip.test.tsx (4/4) and the existing tooltip/leading-tab/pinned-chip suites. npx tsc -b --noEmit clean.

Tree verified against the merge base: 2 files, +130/-2 — component plus its test, nothing else.

No open questions left undecided on this one.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 21, 2026
@dwu96

dwu96 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@dwu96

dwu96 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

2 similar comments
@dwu96

dwu96 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@dwu96

dwu96 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed ea9f95b6ce6be23ac378e8952ed7cd699129ea80 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ea9f95b

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review (fork) — ✅ no blocking findings

Reviewed 1667aa12f3d8d8453b95bda35fafbdae998807b9 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1667aa1

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of 1667aa12f3d8d8453b95bda35fafbdae998807b9 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Full-path tooltip is shown but no first-time reader has cold-read it — fork-lane cap, not an author gap.

Watch

  • No blind read possible on a fork: the attachment shows both hover states (index.ts → /Users/dev/workspace/storefront/packages/catalog/src/index.ts), but comprehension is unverified; a maintainer wanting the blind read can push the branch to this repo.
  • Keyboard-only users never see the fix: a native title renders only on pointer hover, so the exact ambiguity Show the full file path on hover in the dashboard file viewer panel #7900 reports (two index.ts chips) remains unresolvable without selecting each tab. Low frequency × friction × persistent — worth a note in the PR or follow-up issue rather than a change here, since the description already rejected a custom hover card.

[UX-REVIEWED] 1667aa1

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 1667aa12f3d8d8453b95bda35fafbdae998807b9 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify a file tab and its same-path diff tab stay tellable apart on hover, since both tooltips now show the identical path.

[DESIGN-REVIEWED] 1667aa1

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of 1667aa12f3d8d8453b95bda35fafbdae998807b9 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Base already tooltipped truncated names via title={tab.title}; the real new value is the same-name ambiguity fix — verify #7900 reports that.

The description's "carried no title attribute at all" is contradicted by the diff's own removed line (title={tab.title}, SidePanel.tsx:1561, kept comment citing #9868), so the first stated harm (reading a CSS-truncated name) already worked on base. The second harm — two index.ts tabs indistinguishable without clicking — is real on base (label and title are both basename), is the linked defect, and alone justifies the identical two-line diff, so nothing shipped changes.

What this change ships

Inventory (3 items) — 3 justified

Intent: let a user identify which file a side-panel tab holds by hovering it — a FIX for #7900.

  1. Hovering a file, diff or folder tab now shows the full path, not the basename; pathless tabs (terminal, app, pinned views, artifacts) unchanged — justified
  2. New test file pinning the path tooltip and the pinned chips' accessible name — justified
  3. Evidence screenshot committed under website/temp-screenshots/ — justified (7 sibling dirs already committed there)

[FIRST-PRINCIPLES-REVIEWED] 1667aa1

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

The shard-4 red is not from this PR

Backend Tests (3.12, 4), Backend Tests (Windows) (4) and the downstream Coverage Gate are failing on a main-inherited test, not on anything in this diff.

Failing test

test/test_pending_boundary_consumer_semantics.py::test_running_and_turn_running_slot_readers_are_enumerated

What differs. The test AST-scans src/kiro_crew/dashboard/ for direct reads of slot.running / slot.turn_running and asserts an exact site set. On current main the actual set has one site the expected set lacks, and lacks four the expected set has:

Left (actual) contains 1 more item:
  ('chat_handlers.py', '_switch_target_busy'): frozenset({'running'})
Right (expected) contains 4 more items:
  ('chat_handlers.py', 'api_chat_slot_agent'):            frozenset({'running'})
  ('chat_handlers.py', 'api_chat_slot_model'):            frozenset({'running'})
  ('chat_handlers.py', 'api_chat_slot_reasoning_effort'): frozenset({'running'})
  ('chat_handlers.py', 'api_chat_slot_workspace'):        frozenset({'running'})

The four handlers still exist and still refuse a switch mid-turn. Only the attribution moved: their inline slot.running read was hoisted into a shared helper, so the scanner now credits the helper instead of each caller.

Introducing commit. af0f1867808351cb2390b9ba7e078b4dbd8e8881 — "fix(dashboard): refuse a slot switch while a sibling alias cold-starts" — added _switch_target_busy to chat_handlers.py. The test's expected set was not updated.

The enumeration test itself is newer than that refactor (2515d7b07be391a4584b9a7485fffe93c59620c0), and was written against a pre-refactor base, so it was red from birth on main. Verified: it fails at that very commit, with no PR involved.

Reproduced on pristine main, no PR merge ref, at 0a80050938cfac1cc90e239a8ad02910ec4dbe07:

git worktree add --detach /tmp/probe origin/main
cd /tmp/probe
PYTHONPATH="$PWD/src" python -m pytest \
  test/test_pending_boundary_consumer_semantics.py -q -p no:cacheprovider -n0
# 1 failed, 8 passed

Tracking / fix. Already filed and already being fixed — nothing is needed from this PR:

I applied 12718 and 12715 to a pristine main worktree in turn; each takes the file to 9 passed.

Please ignore the shard-4 / Coverage Gate red here. It clears on this PR once a fix lands on main and the branch is rebased. No push to this PR is required.

Committed under `website/temp-screenshots/`, which is where this repo's other
19 evidence PNGs live, and attached to the PR description as well so the fork
review lanes can open it (they never check out the fork head, so a committed
copy reaches them as a binary marker only).

The chip's tooltip is a native `title`, which the browser draws as chrome
rather than as page content, so it cannot appear in a page screenshot. The
frame instead shows the real tab strip from the built bundle with a bubble
painted from the chip's own `title` attribute, read out of the DOM at capture
time -- the same pattern the existing capture harnesses use for a `title`.

Top half is origin/main, bottom half is this branch, same two tabs and the
same hovered chip in both: before, hovering either chip answers `index.ts`;
after, it answers the full path of the file that chip holds.
@iamwhatever
iamwhatever force-pushed the feat/tabchip-path-tooltip branch from ea9f95b to 1667aa1 Compare September 22, 2026 06:11
@iamwhatever

Copy link
Copy Markdown
Contributor

Visual-evidence pass on 1667aa12f3. Screenshot Evidence was the red lane; it is green, and the fork UX Review lane's evidence gap is closed too.

What the evidence is

The description now carries the before/after frame as a real description attachment (github.com/user-attachments/assets/…), which is the only image form the fork review lanes admit — .github/scripts/pr-attachment-evidence.sh allowlists exactly that shape, and a fork PR's committed image never reaches those runners because the fork head is not checked out. It renders: fetched back over the 302 to the signed asset it returns HTTP 200 image/png, 1654x632, 107929 bytes, sha256-identical to the file in the branch, and the rendered PR page carries it as an <img>.

Both halves are the REAL built bundle behind the screenshot harnesses' usual gateway-free static server (scripts/lib/serve-dist.mjs + lib/stub-dashboard-api.mjs), same two tabs and the same hovered chip: origin/main on top, this branch below.

One thing to know before reading the frame: a title is drawn by the browser as its own chrome, not as page content, so it cannot appear in a page screenshot — scripts/capture-reveal-label-sweep.mjs records the same limitation. The pale bubble in each half is painted by the capture harness from the value it reads off that chip's real title attribute, the house pattern from scripts/capture-composer-default-agent-marker.mjs. The harness asserts the attribute's exact value before it writes a frame (index.ts on both chips for the base bundle, the two distinct full paths on this branch, and a surviving name on the icon-only pinned chips), so a stale bundle fails the run instead of being saved as evidence.

The committed copy is redundant — drop it at merge if you want the author's file set

The same PNG is also committed at website/temp-screenshots/7935-tabchip-path-tooltip/tabchip-path-tooltip.png (108 KB). It was committed before the attachment route was available, and with the attachment in the description it buys nothing: it sits inside website/, so it rides along in the frontend tree of what is otherwise a 7-line source change. I am deliberately leaving it rather than force-pushing again, because another head forfeits this head's green lanes and restarts the whole fork matrix. Squash-drop that one file at merge time if you want the diff to match the author's file set — the description's evidence does not depend on it.

The backend red is main's, not this PR's

Backend Tests (3.12, 4), Backend Tests (Windows) (4) and the Coverage Gate that fails closed behind them are inherited from origin/main: test/test_pending_boundary_consumer_semantics.py::test_running_and_turn_running_slot_readers_are_enumerated fails on the base commit itself, with the identical assertion, and this PR touches no Python. It was shipped red by 2515d7b (#11454) against a helper added in af0f186 (#11425); tracked in #12713 with a fix open in #12718.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
@iamwhatever iamwhatever self-assigned this Sep 23, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after verified readiness: passed, PR Readiness success on this head, mergeable, no open change requests. [operator: bolichen97 batch review 2026-09-23]

@bolichen97
bolichen97 merged commit 4fb459d into kirodotdev:main Sep 23, 2026
148 of 154 checks passed
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
* feat: show a file tab's full path as its hover tooltip

A side panel tab chip labels itself with the file's basename inside a
240px truncating span, and carried no tooltip at all unless it was one
of the icon-only pinned view chips. So a long filename was unreadable,
and two tabs holding a same-named file from different directories were
impossible to tell apart without clicking each one.

The chip already receives the tab, and file, diff and folder tabs all
carry the absolute path on it. Prefer that path as the tooltip, falling
back to the title for tabs that have no path, such as terminal and app
tabs, and for the icon-only pinned chips whose glyph needs a name.

The breadcrumb bar in the panel body already exposes the full path this
way; this brings the chip, which is the surface a user hovers first, to
the same behaviour.

Closes kirodotdev#7900

* docs: add the screenshot evidence for the tab-chip path tooltip

Committed under `website/temp-screenshots/`, which is where this repo's other
19 evidence PNGs live, and attached to the PR description as well so the fork
review lanes can open it (they never check out the fork head, so a committed
copy reaches them as a binary marker only).

The chip's tooltip is a native `title`, which the browser draws as chrome
rather than as page content, so it cannot appear in a page screenshot. The
frame instead shows the real tab strip from the built bundle with a bubble
painted from the chip's own `title` attribute, read out of the DOM at capture
time -- the same pattern the existing capture harnesses use for a `title`.

Top half is origin/main, bottom half is this branch, same two tabs and the
same hovered chip in both: before, hovering either chip answers `index.ts`;
after, it answers the full path of the file that chip holds.

---------

Co-authored-by: Mitraj Parmar <mrpmrp@amazon.com>
Co-authored-by: Joe Guo <zejiangg@amazon.com>
@mbriones98 mbriones98 removed the drive-to-green PR claimed by drive-to-green pipeline label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants