Skip to content

fix(dashboard): recognise Windows paths in file viewer breadcrumbs - #8012

Merged
NicholasRBowers merged 1 commit into
kirodotdev:mainfrom
shrihan-vijay:fix/windows-path-predicates-7990
Sep 28, 2026
Merged

NicholasRBowers merged 1 commit into
kirodotdev:mainfrom
shrihan-vijay:fix/windows-path-predicates-7990

Conversation

@shrihan-vijay

@shrihan-vijay shrihan-vijay commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a Windows gateway, the file viewer's breadcrumbs show the folders of a drive-rooted path, as they already do for POSIX paths.

MarkdownPanel.tsx's breadcrumbSegments only split on /. On a Windows
gateway (backslash paths, drive letters), an open file's breadcrumb bar
rendered a drive-rooted path (C:\Users\me\notes.md) as one giant,
non-navigable segment instead of the usual clickable ancestor chain.

Why it matters

Kiro Crew supports native Windows gateways, so a Windows user opening a file
in the dashboard gets a useless breadcrumb bar in the file viewer.

Not a goal

What changed (motivation → approach → change)

A Windows path in the file viewer header now shows its folders: C:\Users\me\Documents\notes.md reads me › Documents › notes.md instead of one unbroken string.

breadcrumbSegments splits a drive-rooted path (WINDOWS_ABS_PATH_RE) on either separator and rejoins each ancestor with the separator the input used. The drive letter stays as its own segment, and its path is the drive root (C:\), because a bare C: means the drive's current folder on Windows. Every other path splits on / only, because a backslash is a legal filename character on Linux and macOS: /home/me/we\ird.md keeps we\ird.md as its file name.

Backwards compatibility

Compatible: every path that is not drive-rooted splits exactly as before.

Tests

  • MarkdownPanel.test.tsx: breadcrumbSegments splits a drive-rooted backslash path, rebuilds each ancestor with the drive letter, accepts the forward-slash spelling, gives a short path's drive segment the drive root (C:\, C:/), and keeps a backslash inside a POSIX file name (/home/me/we\ird.md).

Manual verification

Rendered the real FileHeaderBreadcrumb with a C:\Users\... path on this branch and on main and compared the frames (below).

Screenshots / video

Breadcrumb strip on Windows-path input. Before: the whole path is a single non-navigable blob. After: the usual ancestor chain, with the last-three-segment truncation intact.

Breadcrumb on main: the Windows path renders as one non-navigable segment

Breadcrumb with this PR: the same path renders as the usual segmented ancestor chain

Related Issues

Fixes #7990

Pattern harvest

Rule candidate: lint
Pattern: a gateway path split on / only (.split('/').pop(), private basename clones). The same assumption remains at the sites listed in #14581, which tracks one shared drive-root-aware helper plus a lint rule; the terminal predicate is tracked in #14560.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — N/A, no spec document covers these predicates
  • No secrets, credentials, or internal references in the diff

@shrihan-vijay
shrihan-vijay requested review from a team and Zedmor September 2, 2026 22:40
@iamwhatever

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

1 similar comment
@dwu96

dwu96 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 2, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Open PR relationship audit

This is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion.

Relationship findings

  • This PR is OVERLAPPING with PR #7969. The goals differ or the implementations can complement each other; this is not a duplicate claim. Recommended action for PR #8012: CONTINUE_DEVELOPMENT. The merged sibling covers a different predicate and does not implement either behavior this PR adds, but it also fixes the UNC guard by shape after review rejected the alternation form this PR ships; align the regex with main's /^[/\]{2}/ (and have the hoisted export be the one thing every call site imports) before merge. Files: website/src/components/MarkdownRenderer.tsx, website/src/utils/urlTransform.ts.

No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit.

@bolichen97

Copy link
Copy Markdown
Contributor

@shrihan-vijay Thanks for keeping this scoped to #7990 and for leaving isPathCandidate alone.

What already landed: merged #7969 (d31d9c700) fixed the first of the three predicates #7990 enumerates, isPathCandidate in website/src/components/MarkdownRenderer.tsx, and it carries its own UNC guard there.

What is still missing on main: both of your user-facing fixes. website/src/utils/terminalCompletion.ts still gates shouldComplete and looksLikePath on token.includes('/'), and breadcrumbSegments in website/src/components/MarkdownPanel.tsx still splits and rejoins on / only. Nothing has superseded this work, so please keep the PR.

Two changes we would like before merge:

  1. Align the UNC guard with the shape fix(dashboard): recognise Windows paths in the markdown path chip #7969 actually merged, /^[/\\]{2}/. The UNC_PREFIX_RE you export from website/src/utils/urlTransform.ts requires two of the same separator, so mixed spellings that Windows still reads as a UNC root pass shouldComplete and reach POST /api/terminal/complete.
  2. Make MarkdownRenderer.tsx import the hoisted constant. As the diff stands the hoist adds a copy instead of removing one: main would end up with three UNC regexes under two different semantics, one in urlTransform.ts, one local to terminalCompletion.ts, and the existing one in MarkdownRenderer.tsx.

Then please rebase. The branch is 705 commits behind main and is currently blocked, and open #9301 edits the lines immediately after breadcrumbSegments in the same file plus the same test file, so whichever lands second will need a small conflict fix.

Posted from the 2026-09-08 open-PR relationship audit (read-only, one auditor per PR); reply here if any of this is wrong.

@dwu96 dwu96 added the needs-pr-triage PR scanner: awaiting automated triage label Sep 15, 2026
@NicholasRBowers NicholasRBowers added drive-to-green PR claimed by drive-to-green pipeline and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 15, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author.

Assessment: Nothing here needs a Windows host — the change is pure path-string classification with vitest coverage that is already green on all four Frontend Test shards. The reds are: a Backend Tests (Windows) (2) timing assertion in test/test_jsonl_util.py (no Python is touched, loaded-runner flake), PR Hygiene from a body that has since gained its ## Pattern harvest section but never re-ran, and Screenshot Evidence because the body says "no visual change" without the <!-- no-visual-delta --> marker and **Why no screenshot:** line the gate requires. Plan: rebase onto current main (~1400 behind, expect a small MarkdownPanel.tsx conflict from #9301), apply the maintainer's two 2026-09-08 asks — align UNC_PREFIX_RE to main's merged /^[/\\]{2}/ shape with mixed-separator tests, and make MarkdownRenderer.tsx import the hoisted constant instead of keeping a third copy — then fix the body (no-visual-delta waiver, drop the CLA placeholder and session-URL trailer) and push once to re-fire CI and the review lanes.

If you'd prefer I don't touch this PR, add the pr-no-autofix label.

@NicholasRBowers
NicholasRBowers force-pushed the fix/windows-path-predicates-7990 branch from 502db1e to 6271384 Compare September 15, 2026 11:38
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

Drove this PR per the maintainer's 2026-09-08 direction (keep the PR; align the UNC regex; share the constant) — original fix by @shrihan-vijay, whose authorship the commit keeps. Changes in 62713846e:

Rebase. Rebased the single commit onto current main (~1400 commits behind; the MarkdownPanel.tsx overlap with #9301 merged cleanly — #9301's header-path code and this PR's separator logic coexist in breadcrumbSegments).

UNC regex aligned to the merged shape. UNC_PREFIX_RE in urlTransform.ts and the local restatement in terminalCompletion.ts changed from /^(?:\\\\|\/\/)/ to /^[/\\]{2}/, so the mixed-separator pairs \/host and /\host — which Windows reads as the same UNC root — are refused too. Added mixed-pair cases to urlTransform.test.ts and terminalCompletion.test.ts (both shouldComplete and completionMode).

Shared constant imported, not copied. MarkdownRenderer.tsx now imports UNC_PREFIX_RE from ../utils/urlTransform instead of keeping its own copy; its comment keeps the site-specific rationale and points at the shared constant. terminalCompletion.ts keeps a local restatement (same bytes) because that module is deliberately dependency-free — urlTransform.ts imports react-markdown — the same trade WIN_PRODUCER_PATH_RE in fileTokens.ts documents; this is the "unless it creates an import cycle/dependency problem" branch of the maintainer's ask.

Body. Rewritten from the whole diff: added the required screenshot evidence (before/after of the breadcrumb strip rendering C:\Users\... — the one surface whose rendering visibly changes), removed the CLA placeholder and an external session-URL footer, kept ## Pattern harvest.

Verification. typecheck, lint --quiet, lint:i18n all clean; 1013 tests across 50 frontend files pass (all MarkdownPanel*, MarkdownRenderer*, terminalCompletion, urlTransform, DisplayPanel.terminalCompletion suites). Two independent model reviews of the final diff reported no findings.

@NicholasRBowers

Copy link
Copy Markdown
Contributor

Intent: Make the terminal-completion and breadcrumb path predicates recognise Windows paths (backslash separators, drive-letter roots) while refusing UNC-shaped tokens in every spelling, so a Windows-gateway user gets working completion and navigable breadcrumbs without the frontend ever asking the gateway to stat a named host.
Not a goal: Changing what counts as a path candidate beyond the separator/UNC shapes the maintainer named; touching any backend code; altering the rendering of the completion menu or breadcrumb bar themselves.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of fdd15ac233b720b3dc1c6c98171388bb7ba079e7 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has seen the now-clickable Windows crumbs — this fork lane cannot confirm comprehension, only that the rendering matches the POSIX pattern.

Watch

  • The shallow-path drive crumb (C: › Users › notes.md, target C:\) — the diff special-cases it (isDriveSeg ? joined + sep : joined) and tests it, but both attachments show only deep paths where the drive is hidden; a Windows user on a short path meets an unverified crumb. Low frequency, low impact, but it is the one visual this diff invents. Fix: attach one screenshot of a ≤3-segment path (C:\Users\notes.md).

[UX-REVIEWED] fdd15ac

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed fdd15ac233b720b3dc1c6c98171388bb7ba079e7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] fdd15ac

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of fdd15ac233b720b3dc1c6c98171388bb7ba079e7 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

UNC paths (\\server\share\…) still render as one blob; #14560 tracks only the terminal half — confirm the breadcrumb UNC case is tracked too.

[DESIGN-REVIEWED] fdd15ac

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — 🟡 CONCERNS

Premise-level review of fdd15ac233b720b3dc1c6c98171388bb7ba079e7 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

"Pattern harvest: Not generalizable" undercounts — the same '/'-only split survives at 7 counted sibling sites that still misrender Windows paths.

Not justified as shipped

  • Item 1 — symptom-level: the breadcrumb split is fixed at mechanism level for its own surface, but the description's "Not generalizable … No new rule is needed" claims the sibling set is closed while the identical POSIX-only-separator assumption remains at 7 counted sites (grepped (filePath|path).split('/').pop() in src/components): MarkdownPanel.tsx:810,855,937,1227, FileRenderers.tsx:79, ChatInput.tsx:857,894 — each shows the full C:\… path as the file name on a Windows gateway — plus six private POSIX-only basename clones (file-explorer/utils.ts:14, FolderPanel.tsx:17, FilesHomePanel.tsx:13, MarkdownRenderer.tsx:194, composerDrop.ts:188, ProjectScaffolderPage.tsx:225). Deferring the general fix is fine; the closed-set claim is contradicted by the count.
    Clears when: those sites are fixed, or a linked issue records the deferral the way Windows terminal completion needs a cwd source (PowerShell prompt integration) #14560 does for the terminal half.

What this change ships

Inventory (3 items) — 2 justified

Intent: on a Windows gateway, the file viewer's breadcrumbs show a drive-rooted path's folders as a clickable ancestor chain — a FIX (#7990, with tests that fail on base).

  1. A backslash drive-rooted path renders as an ancestor chain instead of one non-navigable blob — symptom-level: point patch of the '/'-only assumption; 7 counted unfixed siblings.
  2. Each Windows ancestor crumb's click target rejoins with the separator the input used — justified
  3. A shallow Windows path's drive crumb targets the drive root (C:\/C:/), never bare drive-relative C: — justified

WINDOWS_ABS_PATH_RE is reused from utils/urlTransform.ts, not duplicated; POSIX paths (including backslash-in-filename) split exactly as before; not product shape — the fix restores behaviour issue #7990 pins.

[FIRST-PRINCIPLES-REVIEWED] fdd15ac

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed fdd15ac233b720b3dc1c6c98171388bb7ba079e7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] fdd15ac

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 15, 2026
@NicholasRBowers

NicholasRBowers commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

Verified in source, not rebutted: the finding holds, and it goes deeper than the frontend. isPlainWord (website/src/utils/terminalCompletion.ts:116) refuses cd ..\ and unescapeWord decodes ..\src to ..src, and on a Windows gateway the completion route also returns no path entries at all: _session_cwd returns None off POSIX (src/kiro_crew/dashboard/handlers/terminal.py:785) and api_terminal_complete then answers every path request with an empty listing (terminal.py:2283).
A correct cwd source is new backend design: PowerShell's cd does not move the process working directory, so the shell itself has to report its location. That is out of this PR's scope.
Resolution: the lane's first Clears-when branch. The terminal-completion hunks are removed at 1a7fcc2; this PR now ships only the breadcrumb fix and the shared UNC_PREFIX_RE. The terminal half, with the frontend pipeline changes it needs, is tracked in #14560, starting from this commit.

Edited 2026-09-27: this comment previously asked bolichen97 whether to split the terminal half out or complete it here. It is split; nothing is pending.

@NicholasRBowers NicholasRBowers changed the title fix(dashboard): recognise Windows paths in terminal completion and breadcrumbs fix(dashboard): recognise Windows paths in file viewer breadcrumbs Sep 27, 2026
@NicholasRBowers
NicholasRBowers force-pushed the fix/windows-path-predicates-7990 branch from 6271384 to 1a7fcc2 Compare September 27, 2026 23:45
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

Pushed 0bb5350d7. It is now only the breadcrumb fix, 2 files.

  • Moving UNC_PREFIX_RE into urlTransform.ts is removed (First Principles review on 1a7fcc2d2). The breadcrumb change never uses it, and MarkdownRenderer.tsx was its only user, so the move consolidated nothing. MarkdownRenderer.tsx, urlTransform.ts and urlTransform.test.ts are back to main. The move was asked for because the terminal half added a second copy of the regex. With that half gone, main keeps its single copy, and the move goes with the terminal work in Windows terminal completion needs a cwd source (PowerShell prompt integration) #14560, where it gets a second user.
  • Unchanged: the drive-rooted breadcrumb split and the test that pins a backslash inside a POSIX file name.
  • The Integration (in-process gateway) red on the previous head is test_route_sweep.py::test_every_parameterless_get_route_serves_on_a_fresh_home expecting /api/models to return 503. It fails the same way on main at 61e100ded, after fix(testing): teach the fake kiro-cli to answer chat --list-models #14463 taught the fake backend to list models, so it is not caused by this diff.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 28, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

  • Description calls the breadcrumb a "clickable ancestor chain" — span=36daf6e01dd7 — rebutted (no code change needed)

Correct that the crumbs do not navigate: FileHeaderBreadcrumb (website/src/components/MarkdownPanel.tsx) renders each segment as a plain <span>, on POSIX and Windows alike, and this diff adds no navigation.
The word "clickable" is in the contributor's original Problem / Motivation text, which the PR template freezes once the PR is open. The unfrozen What changed section describes the actual effect: the header "reads me › Documents › notes.md instead of one unbroken string".
The Goal line claims display only ("breadcrumbs show the folders of a drive-rooted path"), so the shipped behaviour matches the stated goal. A maintainer may strike the word from the frozen text.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@NicholasRBowers
NicholasRBowers force-pushed the fix/windows-path-predicates-7990 branch from 0bb5350 to a2d3c7c Compare September 28, 2026 00:20
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

  • Drive crumb of a short Windows path is the drive-relative C: — span=62c33351e01e — fixed in a2d3c7c

Held: for C:\Users\notes.md the first shown crumb joined to the bare drive token, so its path was C:, which Windows reads as the drive's current directory, not its root. That contradicted BreadcrumbSegment's absolute-path contract.
Fix in breadcrumbSegments (website/src/components/MarkdownPanel.tsx): the drive segment of a drive-rooted path takes the input's separator (C:\ / C:/). Deeper ancestors, the file crumb and every non-drive-rooted path are unchanged.
Tests: C:\Users\notes.md gives C:\, C:\Users, C:\Users\notes.md; C:/notes.md gives C:/, C:/notes.md; a deep path is pinned unchanged. The two new drive tests fail on the previous head.
Also rebased onto current main (12 commits, none in these files).

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 28, 2026
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 28, 2026
@NicholasRBowers

NicholasRBowers commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

Verified: ToolCallLine.tsx:790, FilesHomePanel.tsx:14 and FolderPanel.tsx:18 split gateway paths on / only, and VectorMemoryCard.tsx:161 / FolderPanel.tsx:66 already hand-roll an either-separator split.
Out of this PR's scope: each site is a different surface with its own tests, and #7990 enumerates only the breadcrumb and terminal predicates. The breadcrumb fix removes the reported defect on its own.
Tracked in #14581 (deferred-finding, assignee NicholasRBowers, Due: 2026-10-26): one shared helper that splits on \ only for drive-rooted paths, applied at all five sites.

@NicholasRBowers

NicholasRBowers commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

  • Shallow-path drive crumb appears in no screenshot — span=4e6d5b73faea — rebutted (no rendered delta to capture)

The crumbs are not clickable: FileHeaderBreadcrumb (website/src/components/MarkdownPanel.tsx) renders each segment as a plain <span> with no navigation, so the drive crumb does not open anything.
The drive-root rule changes only the unused path field (C:\ instead of C:), not the rendered text. C:\Users\notes.md renders C: › Users › notes.md with or without it, and that segmentation is the same one attachment 02 shows for a deep path. A still would show no difference to verify.

@NicholasRBowers

NicholasRBowers commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

  • Note in the docstring that BreadcrumbSegment.path has no production consumer — span=f84e76ed38e4 — rebutted (advisory, no push)

Correct that path has no production consumer today: FileHeaderBreadcrumb renders only seg and isFile.
The contract, including the drive-root C:\ case, is pinned by the breadcrumbSegments unit tests in website/src/test/MarkdownPanel.test.tsx. A note that would go stale the moment a caller wires navigation adds nothing those tests do not already enforce, and it would restart CI for a comment-only change.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
MarkdownPanel.tsx's breadcrumbSegments split only on '/', so on a Windows
gateway a drive-rooted path (`C:\Users\me\notes.md`) read as one
non-navigable breadcrumb segment instead of the usual ancestor chain.

breadcrumbSegments now splits a drive-rooted path (WINDOWS_ABS_PATH_RE) on
either separator and rejoins each ancestor with the separator the input
used; the drive letter survives the split as its own segment, and that
segment's path is the drive root (`C:\`), since a bare `C:` is
drive-relative on Windows. Any other
path still splits on '/' only, since a backslash is a legal POSIX filename
character.

The terminal-completion half of kirodotdev#7990 is not in this change: the completion
route has no working-directory source on a Windows gateway, so it moves to
its own issue.

Original fix authored by Shrihan Vijay.

Fixes kirodotdev#7990.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Kiro Crew <noreply@kirodotdev.github.io>
@NicholasRBowers
NicholasRBowers force-pushed the fix/windows-path-predicates-7990 branch from a2d3c7c to fdd15ac Compare September 28, 2026 02:37
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

Rebased onto main for #14578's route-sweep test fix (the one blocking readiness item, Integration (in-process gateway), was red on main itself). The change is identical: head fdd15ac23; CI re-running.

@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

Verified on main: the inline .split('/').pop() sites (MarkdownPanel.tsx:810,855,937,1227, FileRenderers.tsx:79, ChatInput.tsx:857,894) and the private basename clones are POSIX-only. MarkdownRenderer.tsx:194 basenameOf already splits on both separators, so it is listed as an existing copy rather than a defect.
#14581 (deferred-finding, assignee NicholasRBowers, Due: 2026-10-26) now lists every verified site, pinned to main cd783d223, and asks for one shared drive-root-aware helper plus a lint rule. The PR description's Pattern harvest now names that rule candidate and links #14581 instead of claiming the set is closed.
Same class as span ef831a051090 on the previous head.

@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]

  • Shallow-path drive crumb appears in no screenshot — span=9fab8c1134a6 — rebutted (same as span 4e6d5b73faea on the previous head)

The crumbs render as plain <span> text with no navigation (FileHeaderBreadcrumb, website/src/components/MarkdownPanel.tsx), so the drive-root rule (C:\ instead of C:) changes only the unused path field, not a pixel. C:\Users\notes.md renders C: › Users › notes.md with or without it, and that is the same segmentation attachment 02 shows. The behaviour is pinned by the breadcrumbSegments unit tests. Earlier record: #8012 (comment)

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 28, 2026
@NicholasRBowers
NicholasRBowers enabled auto-merge (squash) September 28, 2026 03:07
@NicholasRBowers
NicholasRBowers merged commit 560ba22 into kirodotdev:main Sep 28, 2026
108 checks passed
@mbriones98 mbriones98 removed the drive-to-green PR claimed by drive-to-green pipeline label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows-aware path predicates: fix terminalCompletion + MarkdownPanel, hoist the shared UNC guard

6 participants