Repository navigation
fix(dashboard): recognise Windows paths in file viewer breadcrumbs - #8012
NicholasRBowers merged 1 commit into
Conversation
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
1 similar comment
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
Open PR relationship auditThis is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion. Relationship findings
No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit. |
|
@shrihan-vijay Thanks for keeping this scoped to #7990 and for leaving What already landed: merged #7969 ( What is still missing on main: both of your user-facing fixes. Two changes we would like before merge:
Then please rebase. The branch is 705 commits behind main and is currently blocked, and open #9301 edits the lines immediately after Posted from the 2026-09-08 open-PR relationship audit (read-only, one auditor per PR); reply here if any of this is wrong. |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author. Assessment: Nothing here needs a Windows host — the change is pure path-string classification with vitest coverage that is already green on all four Frontend Test shards. The reds are: a If you'd prefer I don't touch this PR, add the |
502db1e to
6271384
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca] Drove this PR per the maintainer's 2026-09-08 direction (keep the PR; align the UNC regex; share the constant) — original fix by @shrihan-vijay, whose authorship the commit keeps. Changes in Rebase. Rebased the single commit onto current UNC regex aligned to the merged shape. Shared constant imported, not copied. Body. Rewritten from the whole diff: added the required screenshot evidence (before/after of the breadcrumb strip rendering Verification. typecheck, |
|
Intent: Make the terminal-completion and breadcrumb path predicates recognise Windows paths (backslash separators, drive-letter roots) while refusing UNC-shaped tokens in every spelling, so a Windows-gateway user gets working completion and navigable breadcrumbs without the frontend ever asking the gateway to stat a named host. |
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has seen the now-clickable Windows crumbs — this fork lane cannot confirm comprehension, only that the rendering matches the POSIX pattern. Watch
[UX-REVIEWED] fdd15ac |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS UNC paths ( [DESIGN-REVIEWED] fdd15ac |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS "Pattern harvest: Not generalizable" undercounts — the same '/'-only split survives at 7 counted sibling sites that still misrender Windows paths. Not justified as shipped
What this change shipsInventory (3 items) — 2 justifiedIntent: on a Windows gateway, the file viewer's breadcrumbs show a drive-rooted path's folders as a clickable ancestor chain — a FIX (#7990, with tests that fail on base).
[FIRST-PRINCIPLES-REVIEWED] fdd15ac |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
Edited 2026-09-27: this comment previously asked bolichen97 whether to split the terminal half out or complete it here. It is split; nothing is pending. |
6271384 to
1a7fcc2
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca] Pushed
|
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
0bb5350 to
a2d3c7c
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
MarkdownPanel.tsx's breadcrumbSegments split only on '/', so on a Windows gateway a drive-rooted path (`C:\Users\me\notes.md`) read as one non-navigable breadcrumb segment instead of the usual ancestor chain. breadcrumbSegments now splits a drive-rooted path (WINDOWS_ABS_PATH_RE) on either separator and rejoins each ancestor with the separator the input used; the drive letter survives the split as its own segment, and that segment's path is the drive root (`C:\`), since a bare `C:` is drive-relative on Windows. Any other path still splits on '/' only, since a backslash is a legal POSIX filename character. The terminal-completion half of kirodotdev#7990 is not in this change: the completion route has no working-directory source on a Windows gateway, so it moves to its own issue. Original fix authored by Shrihan Vijay. Fixes kirodotdev#7990. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: Kiro Crew <noreply@kirodotdev.github.io>
a2d3c7c to
fdd15ac
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca] Rebased onto main for #14578's route-sweep test fix (the one blocking readiness item, |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]
|
Problem / Motivation
Goal: On a Windows gateway, the file viewer's breadcrumbs show the folders of a drive-rooted path, as they already do for POSIX paths.
MarkdownPanel.tsx'sbreadcrumbSegmentsonly split on/. On a Windowsgateway (backslash paths, drive letters), an open file's breadcrumb bar
rendered a drive-rooted path (
C:\Users\me\notes.md) as one giant,non-navigable segment instead of the usual clickable ancestor chain.
Why it matters
Kiro Crew supports native Windows gateways, so a Windows user opening a file
in the dashboard gets a useless breadcrumb bar in the file viewer.
Not a goal
isPathCandidateinMarkdownRenderer.tsx, already fixed by fix(dashboard): recognise Windows paths in the markdown path chip #7969.What changed (motivation → approach → change)
A Windows path in the file viewer header now shows its folders:
C:\Users\me\Documents\notes.mdreadsme › Documents › notes.mdinstead of one unbroken string.breadcrumbSegmentssplits a drive-rooted path (WINDOWS_ABS_PATH_RE) on either separator and rejoins each ancestor with the separator the input used. The drive letter stays as its own segment, and its path is the drive root (C:\), because a bareC:means the drive's current folder on Windows. Every other path splits on/only, because a backslash is a legal filename character on Linux and macOS:/home/me/we\ird.mdkeepswe\ird.mdas its file name.Backwards compatibility
Compatible: every path that is not drive-rooted splits exactly as before.
Tests
MarkdownPanel.test.tsx:breadcrumbSegmentssplits a drive-rooted backslash path, rebuilds each ancestor with the drive letter, accepts the forward-slash spelling, gives a short path's drive segment the drive root (C:\,C:/), and keeps a backslash inside a POSIX file name (/home/me/we\ird.md).Manual verification
Rendered the real
FileHeaderBreadcrumbwith aC:\Users\...path on this branch and onmainand compared the frames (below).Screenshots / video
Breadcrumb strip on Windows-path input. Before: the whole path is a single non-navigable blob. After: the usual ancestor chain, with the last-three-segment truncation intact.
Related Issues
Fixes #7990
Pattern harvest
Rule candidate: lint
Pattern: a gateway path split on
/only (.split('/').pop(), privatebasenameclones). The same assumption remains at the sites listed in #14581, which tracks one shared drive-root-aware helper plus a lint rule; the terminal predicate is tracked in #14560.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)