Repository navigation
Conversation
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
3 similar comments
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
Open PR relationship auditThis is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion. Relationship findings
No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit. |
d22ad34 to
db7f1a7
Compare
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
1 similar comment
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
db7f1a7 to
c9246a6
Compare
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed Adjudication produced no [GPT-ADJUDICATED] marker for 3e13345: the adjudication stage FAILED TO RUN (its raw output is in the Adjudication details block -- typically an API or setup error), so no proportionality review took place and GPT's blocking verdict stands unreviewed. BLOCKING -- src/kiro_crew/apps/builtins/code_review_sage/sage_lib/results.py:295 -- response handoff bypasses the result-size bound BLOCKING -- src/kiro_crew/apps/builtins/code_review_sage/sage_lib/review_driver.py:779 -- posting discards the only durable review before delivery [BLOCK-MERGE] 3e13345 Adjudication (Opus 4.8) — is blocking on each finding proportionate? |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Sound root-cause fix — the shared write channel is removed, not re-matched — but the record must now fit one LLM response, which caps the biggest reviews. Watch
Suggestions
[DESIGN-REVIEWED] ea3d7aa |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of All evidence is in. The change replaces Code Review Sage's shared-file result handback with a response-bound tagged handoff and restores pooled concurrency; the base tree confirms the deleted serialization comments themselves named "per-dispatch staging whose path a sibling worker cannot guess" as the condition for restoring parallelism, which this PR meets — so the rewritten pins carry their own evidence. Two things don't earn their place as shipped: the unscoped-serial clamp protects a legacy file fallback whose worker-side producers this same PR removes (both prompt builders and SKILL.md now forbid disk writes), and 11 baselined files are wholesale black-reformatted, burying the transport change. First-Principles-Verdict: CONCERNS The serial clamp guards a legacy file fallback no prompt feeds anymore, and whole-file reformatting of 11 baselined files buries the actual change. Not justified as shipped
What this change shipsInventory (10 items) — 7 justifiedIntent: let independent claimed reviews run concurrently again by having each worker return its result inside its own dispatch response instead of through a shared file — an ADDITION.
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] ea3d7aa |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed Review detailsI have enough to complete validation. Let me verify my reconstruction of the PR-head Now I'll assess the two candidates against the falsification bar. Candidate 1 (retry-post unlinks the durable record before the poster dispatch): grounded. On the dashboard explicit-retry path ( Candidate 2 (records held in memory until the pool drains): this is the deliberate, load-bearing design of the PR — the deferred write exists precisely "so a sibling session never gets a filesystem window onto another worker's mutable handoff." A mid-run crash loses in-progress (not-yet-complete) reviews that would be re-run anyway; the fix would require the exact per-change filesystem persistence the PR intentionally removed for a security reason. By-design, recoverable, low harm — dropped. No new grounded 80+ findings surfaced in Step 2. No blocking issues; one advisory: the dashboard retry-post path deletes the only durable result record before a long poster dispatch. FINDING — sage_lib/review_driver.py (post_recorded, the [OPUS-REVIEWED] ea3d7aa |
c9246a6 to
b910950
Compare
9a0e01e to
e69bada
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
When you've addressed these, the pipeline will re-assess on its next cycle. |
e69bada to
51ceb11
Compare
|
Rebased onto current Nine conflict hunks across five files, all one architectural disagreement:
The resolution takes this branch's side throughout, which deletes that adoption machinery and its tests: with no shared result path left, there is nothing for those guards to protect. Also fixed: the branch was red at its own head. 779 tests in |
Bind reviewer and poster results to their dispatcher responses instead of a shared filesystem staging path: each worker returns its record inside its own dispatch response, which no sibling session can write. Validate the outer handoff envelope and keep GitHub read-back as delivery confirmation. The prose, help text and concurrency surface describe only mechanisms the code actually provides. A result capability is never checked, produced, or named outside a rejection guard, so no docstring, comment, or flag references one. The --concurrency flag is gone with it: it reached no execution path, since standalone runs have no run id and are clamped to 1 immediately after the value resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
51ceb11 to
3e13345
Compare
|
Adopting the split. #8143 shrinks to the run-lock narrowing plus The narrowing is only safe once records return inside each worker's own dispatch response, so I'll re-push #8143 as that narrowed slice right after #9077 lands, rebased onto whatever Until #9077 lands, that PR is the one worth review; nothing here needs another look until the narrowed push. |
|
Closing in favour of #9077, which implements the same change. Evidence. 9 shared non-infrastructure files on one mechanism: Why this one and not #9077. #9077 is the focused correctness fix and is mergeable; this branch is This is not a judgement on the work -- the two changes were written independently and this one is not the weaker of the pair, it is the one that does not need to land twice. If you disagree, or if #9077 turns out to miss something this branch handles, say so and I will reopen this. From a full relationship audit of every open PR against |
Problem / Motivation
Code Review Sage previously serialized independent run-scoped reviews because workers wrote through a shared result path. That protected result attribution, but it also prevented unrelated claimed reviews from using the existing bounded review pool concurrently.
Why it matters
Independent reviews unnecessarily queued behind each other, increasing turnaround time. Restoring concurrency must not let a worker's result be adopted by a different review dispatch.
What changed (motivation → approach → change)
Each worker now hands its record back inside its own dispatch response, tagged with
<code-review-sage-result>, and the driver reads it out of the response to the dispatch it made. That channel is point-to-point — no sibling can write it — so independent claimed reviews can use the bounded pool without cross-run attribution.The run lock now protects only claim acquisition. Run-scoped reviews delegate concurrency to the pool, while calls without a run scope are clamped to serial — they still write through the legacy shared result directory, where any worker can write any change's record. The standalone CLI is always in that mode, so it no longer offers a
--concurrencyflag: the value reached the clamp and was discarded, while the help text claimed it applied. The rebased route keeps failure-reason reporting intact in the lock-free control flow.Tests
<code-review-sage-result>tag in both initial and follow-up reviewer tasks, and that the prompt names no result file on disk.Manual verification
N/A — the concurrency and adoption boundary are exercised by deterministic backend and driver tests.
Related Issues
N/A.
Relationship to #9077 (read before merging either)
#9077 and this PR solve the SAME problem — the driver cannot prove a result record came from the worker it dispatched — with two different wire formats, and both rewrite the same
sage-review/SKILL.md"result" section and the same driver handback path. They conflict textually, and shipping both would give one contract two formats.This PR should land first and own the transport. The binding is a prerequisite for the parallelization here (a shared result path is exactly what makes concurrent reviews unattributable), and the response-bound
<code-review-sage-result>tag is sufficient on its own: the driver reads the record out of the response to the specific dispatch it made, so the channel is already point-to-point and a driver-issued capability token authenticates nothing further.#9077 is then rescoped to the part this PR does not cover: enforcing a coverage follow-up against the first pass IN THE DRIVER.
build_review_followup_taskhere asks the worker for a complete replacement record and preservesphase1by instruction only, so a follow-up can silently rewrite or drop first-pass findings. #9077'sbase_digestbinding, preserved first-pass metadata, append-only findings and recomputed counts close that, and layer cleanly on this transport.Checklist
feat: safely parallelize run-scoped reviews)Contribution License Agreement
The template's exact CLA wording has not yet been supplied by OSPO.