Skip to content

fix(chat): label purpose-less shell pills from the command, not the title - #8294

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
jingchaodev:feat/purposeless-pill-label
Sep 19, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
jingchaodev:feat/purposeless-pill-label

Conversation

@jingchaodev

@jingchaodev jingchaodev commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

In simplified-tool-names mode the pill label is the agent-authored __tool_use_purpose. kiro-cli's injection of that argument is inconsistent for built-in shell calls (allocated per spawned process; two sessions one minute apart were observed at 16/16 vs 0/22 execute calls carrying it). When it is absent, kiro-cli's auto-title for a bash call is a digest of argument fragments, and the pill renders it verbatim:

⊙ --title, --text, Three, 1. ...

Since #10009 the row derives its label from rawInput.command, but rule R0.0 in utils/toolCallTitle.ts (backendShellDescription) takes any non-stub title that differs from the command as the model's description of the call, and the argument digest passes that test. The description outranks the derived title in pickToolLabel, so the soup still wins and the command reaches only the tooltip. Verified against current main by running this PR's three ToolCallLine cases against the unmodified implementation: both purpose-less soup-title cases still render the soup.

Why it matters

Every session that lands on an untreated kiro-cli process renders unreadable step rows for its whole transcript; the reader cannot tell what any shell step did without expanding it. On current main the live kiro-cli row already carries the command on its title (_select_tool_title), so the soup survives mainly on persisted rows (restored sessions, old transcripts) and on any transport whose title is a fragment digest; those rows are where the label matters most, since the live turn is over.

What changed (motivation → approach → change)

Goal: the pill should be readable from ground truth (the command in the call's raw input), not from a title that is unreliable exactly when it is needed.

Approach considered and rejected: a parallel re-label path in ToolCallLine that bypasses the title pipeline (this PR's first shape, superseded by #10009's client-side derivation, which already owns that decision for every row). Also rejected: LLM back-fill of missing purposes (per-call cost and latency on the hot streaming path for chrome text). Chosen: teach R0.0 the difference between a description and a digest, then let #10009's derivation run.

  • utils/toolCallTitle.ts backendShellDescription (R0.0): a title whose every , -separated fragment (trailing …/... stripped) occurs verbatim in the whitespace-collapsed command is a digest OF the command, not a sentence ABOUT it, and returns undefined so derivation runs: a classified action when the command parses (List files in src for -la, src over ls -la src), the command itself in the code face when it is short, the binary digest when it is flood-length. A description the model wrote carries words the command does not contain, so it never matches; the check is case-sensitive so a one-word sentence (Inspect over git status) stays a description.
  • src/kiro_crew/tool_call_title.py backend_shell_description: the same guard (_is_argument_digest_of), so the channels agree with the dashboard. test/fixtures/tool_call_titles.json gains four cases that pin both sides (digest over a parseable command, digest over a refused $PY command, a single lifted fragment, a one-word sentence).
  • utils/toolLabel.ts deriveShellSummary: steps over wrappers (sudo), variable references ($PY) and interpreters (python3 script.py → script.py; python3 -c … keeps python3), and attaches one sub-command word to the first meaningful name, only for tools and scripts that take one (git, npm, make, docker, …, *.py, *.sh), so cat x stays cat. The observed oncall command digests to ledger.py ticket-log instead of cd. Two existing pins changed to strictly richer labels (make → make build, docker-compose, tee → docker-compose up, tee).

ToolCallLine.tsx and the locale catalogs are unchanged from main.

Tests

  • utils/toolCallTitle.test.ts + test/test_tool_call_title.py: fixture conformance on both sides with the four new cases (TS 269, Python 274).
  • toolLabel.test.ts: interpreter/varref/wrapper stepping; sub-command attaches to the first meaningful name only, and only for tools and scripts that take one.
  • ToolCallLine.test.tsx: an argument-digest title over a short $PY command renders the command verbatim in the code face with no soup on the row; a flood-length command renders its 80-character raw cut with the full command on the details tooltip; an agent-authored purpose still wins.

Manual verification

Screenshots below come from the fixture harness website/scripts/capture-purposeless-shell-pill.mjs driving the real built SPA with the persisted-row shape of the reporting session (meta.kind/input, no purpose); the harness asserts the three pill labels and that neither argument digest is on any pill before it shoots. Full vitest run (2122 files), tsc, eslint, i18n string lint, production build; backend fixture test, black/isort/flake8, mypy --platform linux; comment-history, brand-name, black and subprocess-encoding ratchets and the harness-parity gate against main, all green locally.

Screenshots / video

Dark: an agent-authored purpose (unchanged), a short soup-titled $PY command shown verbatim in the code face, a flood-length multi-line script shown as its binary digest (ledger.py ticket-deps, tee):

pill-label-pills-dark

Light theme

pill-label-pills-light

Related Issues

None open upstream for this; the root cause (inconsistent __tool_use_purpose injection) is filed with the kiro-cli team internally, and this change makes the dashboard robust to it either way. Builds on #10009.

Pattern harvest

Rule candidate: review-prompt
Pattern: "a title/summary that differs from the raw input is not thereby a description of it; when the summary is generated from the same input, check whether it is assembled from that input's own pieces before ranking it above a derivation from the input."

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable): N/A, the rule is documented in the two mirrored code comments and pinned by the shared fixture, as feat(chat): derive human-readable tool-call titles client-side #10009 does
  • No secrets, credentials, or internal references in the diff

@jingchaodev
jingchaodev requested review from a team and buluoray September 3, 2026 22:35
@dwu96

dwu96 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

1 similar comment
@iamwhatever

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from fdff9b2 to 537e2bc Compare September 3, 2026 22:55
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 3, 2026
@jingchaodev

Copy link
Copy Markdown
Contributor Author

CI triage note (head 537e2bc97): the one red CI check, Backend Tests (Windows) (1), is base-branch breakage: the same five test_autonudge_stop_auth.py tests fail on the same Windows shard on #8307 (an unrelated backend diff), while this PR touches only website/ and the Linux shards pass the file. No commits touch that test or its subject between this PR's base and main's tip. Will wait it out / rebase once main is green there.

@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from 537e2bc to 16fc501 Compare September 4, 2026 02:48
@jingchaodev

Copy link
Copy Markdown
Contributor Author

CI triage note (head 16fc50100): backend tests and PR Hygiene are green after rebasing past #8317. The remaining red, Dependency Audit / Audit Production Dependencies, is npm audit timed out after 120s (fail-closed infra guard, no vulnerability named) — currently failing on all 8 open PRs in the repo, so it is a registry/runner outage, not this diff. Will re-trigger once the audit lane recovers.

@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from 16fc501 to e5d58a6 Compare September 4, 2026 05:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 8b8eaba41d1b7605017ab413280e8f9c35afe45f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Spot-check real KAS/claude-acp shell descriptions: any comma-joined description whose every fragment appears verbatim in the command now silently demotes to the derived label.

[DESIGN-REVIEWED] 8b8eaba

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of 8b8eaba41d1b7605017ab413280e8f9c35afe45f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has cold-read the new pill labels (raw command face, ledger.py ticket-deps, tee digest); comprehension is unverified, though every changed face is shown.

Watch

  • The two fixed label faces — the verbatim cd backend && $PY ledger.py ticket-log … code-face pill and the ledger.py ticket-deps, tee digest (attachment-01/02) — replace argument soup and match the product's established purpose-less-shell convention, but whether a newcomer reads the comma-joined digest as "what the agent did" is unknown in this lane (fork, no blind read). Frequency: every purpose-less kiro-cli shell call; impact: friction, not failure. To verify comprehension, push the branch to this repository so the blind-read pass runs.

[UX-REVIEWED] 8b8eaba

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — 🟡 CONCERNS

Premise-level review of 8b8eaba41d1b7605017ab413280e8f9c35afe45f via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The 27-tool subcommand-attachment set rides beyond the fix: the observed defect exercises only SCRIPT_NAME_RE, and its sole support is symmetry with the script case.

Not justified as shipped

  • Item 4 — rides along, inherited: SUBCOMMAND_TOOLS (git, npm, make, … 27 entries in toolLabel.ts) has zero instances in the reported defect — the observed command (ledger.py ticket-log) matches SCRIPT_NAME_RE, and the set's own comment argues "like a tool's sub-command", the symmetry form; it also forces the two pin edits (make → make build, docker-compose, tee → docker-compose up, tee) that relabel every existing digest row for those tools.
    Subtraction: shrink takesSubcommand to SCRIPT_NAME_RE.test(base) and delete SUBCOMMAND_TOOLS, reverting the two changed pins in toolLabel.test.ts.
    Clears when: a reported unreadable digest naming one of those tools, or the set deleted.

What this change ships

Inventory (6 items) — 5 justified

Intent: make shell step rows readable when kiro-cli omits the purpose and titles the call with argument soup — a FIX.

  1. Purpose-less soup-titled shell pills now show a classified action, the command, or a binary digest — justified
  2. Channels agree: the Python mirror stops ranking the argument digest as a description — justified
  3. Shell digests name the script behind wrappers, $VAR heads and interpreters (ledger.py, not cd) — justified
  4. Digests attach a subcommand word for 27 listed tools, relabeling existing rows (make → make build) — rides along, inherited (symmetry with the script case; zero observed instances)
  5. New screenshot harness capture-purposeless-shell-pill.mjs — justified
  6. Four shared fixture cases pin both sides plus TS component/label tests — justified

[FIRST-PRINCIPLES-REVIEWED] 8b8eaba

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 8b8eaba41d1b7605017ab413280e8f9c35afe45f via the fork AI-review pipeline; updated in place on each push.

Review details

FINDING -- src/kiro_crew/tool_call_title.py:2034 -- mutating all to any leaves fixture conformance green -> Fix: add a mixed matching/nonmatching-fragment fixture.
[GPT-REVIEWED] 8b8eaba

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review (fork) — ✅ no blocking findings

Reviewed 8b8eaba41d1b7605017ab413280e8f9c35afe45f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings that block.

FINDING — website/src/utils/toolLabel.ts:538 — 'uv' sits in both INTERPRETERS and SUBCOMMAND_TOOLS, and the interpreter step-over (isInterpreter(base) && tokens[i+1] && !tokens[i+1].startsWith('-')) fires first, so uv run pytest / uv sync step past uv onto the subcommand and derive to Running: run / Running: sync (a meaningless word, and worse than the pre-diff Running: uv) instead of the intended uv run → Fix: drop 'uv' from INTERPRETERS (keep it in SUBCOMMAND_TOOLS), so its first bare word is read as a subcommand.

[OPUS-REVIEWED] 8b8eaba

@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from e5d58a6 to bffb326 Compare September 4, 2026 06:02
@jingchaodev

Copy link
Copy Markdown
Contributor Author

Disposition — GPT validation finding on e5d58a6fc (fixed on bffb3266f): correct — pillLabelText resolves the run_command frame through the catalog at call time, so uiLang belongs in the memo deps; without it a language switch left the pill in the previous language. Added with an exhaustive-deps disable (the linter cannot see through i18nT; same precedent as ActivityViewer/AssistantMessage). Tests 57/57, tsc/eslint/i18n clean.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 4, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Open PR relationship audit

This is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion.

Relationship findings

  • This PR is PARTIALLY_COVERED with PR #6435. Coverage is explicitly incomplete; this finding is not a completion or closure claim. Recommended action for PR #8294: KEEP. PR #6435 is the merged foundation this PR builds on, not a substitute for it: the merged code covers the flood-length-title case only, and none of the primary's three behaviors (command-sourced label, interpreter/wrapper/varref stepping with subcommand attachment, historical shell-ness) exist in current origin/main. Files: website/src/pages/chat/ToolCallLine.tsx, website/src/utils/toolLabel.ts.

No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit.

@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main 41dcadf2c by a maintainer as part of the 2026-09-08 open-PR audit. Old head bffb3266f, new head 947a34496.

Conflicts: none, clean rebase (no manual resolution, no behaviour change).

Gates run locally in an isolated worktree: npx tsc --noEmit -p website/tsconfig.json passed; vitest run src/test/ToolCallLine.test.tsx src/test/toolLabel.test.ts passed (57 tests); the src/i18n suite passed 664/665, with the single failure being navLabels.test.tsx unable to resolve yaml from a stale local node_modules (unrelated to this diff, and CI installs deps fresh).

Please review the rebased branch. Note that a maintainer push makes the maintainer the last pusher, so under this repo's last-push rule a second approver is needed. Reply here if anything looks wrong.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 8, 2026
@jingchaodev

Copy link
Copy Markdown
Contributor Author
  • Verify the , -fragment digest shape against more than one kiro-cli session; a genuine lowercase one-word description (fixture pins status) is now deliberately demoted: verified

The shape (--flag, --flag, FirstWord, 1. ...: argument fragments joined by , , tail cut with ...) is the one kiro-cli emits for a purpose-less execute_bash; the body's two observed sessions (16/16 vs 0/22 execute calls carrying __tool_use_purpose) are where it was recorded, and the harness fixture is that shape. The demotion of a one-word lowercase title that IS a token of the command is deliberate: status over git status tells the reader nothing Git status does not, and a one-word title the command does not contain (Inspect, fixture) is untouched. No change.

@jingchaodev

Copy link
Copy Markdown
Contributor Author

Round on cf1ff2a15 settled: 77 green, 1 red, all five lanes stamped.

  • Design ✅ PASS, First Principles ✅ PASS, GPT 5.6 ✅ no blocking findings, Opus 4.8 ✅ no findings, UX 🟡 CONCERNS (blind-read rider + the digest pill's prose face, both recorded above as maintainer calls: the face is upstream's rule for every digest pill and this PR does not change it).
  • The one red, Backend Tests (Windows) (4), is an xdist worker crash (worker 'gw0' crashed) while running test/test_ledger_edge_fanout.py::TestShutdownDrainsAll::test_shutdown_covers_all_sessions; the shard otherwise passed 12,602 tests. That test drains the ledger fan-out's background writers on shutdown and shares nothing with this diff, whose backend side is the pure tool_call_title.py guard and a JSON fixture. Not attributable; a maintainer re-run clears it, otherwise the same-tree retrigger window opens ~09:05 PDT.

Mergeable; the remaining blocker is the maintainer review.

@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from cf1ff2a to 0066b48 Compare September 16, 2026 19:37
@jingchaodev

Copy link
Copy Markdown
Contributor Author

Same-tree re-roll: 0066b48b2 carries the identical tree as cf1ff2a15 (tree c7937c9de, verified before the push), pushed only to re-run Backend Tests (Windows) (4), whose xdist worker crashed in test_ledger_edge_fanout.py (ledger fan-out drain, no file shared with this diff) after 12,602 passes in the shard. Nothing in the diff changed.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 16, 2026
@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from 0066b48 to 097ec43 Compare September 16, 2026 21:18
@jingchaodev

Copy link
Copy Markdown
Contributor Author
  • F1 website/scripts/capture-purposeless-shell-pill.mjs:122 -- the mc-chat-config seed init script is wiped by transcript-harness load()'s localStorage.clear(): fixed in 097ec4322

The mechanism is real: load() runs localStorage.clear() in its own init script on every navigation, so a seed registered ahead of it is discarded. The consequence claimed (simplified mode stays off, pillsReady() times out) does not follow: simplifiedToolNames is the DEFAULT (DEFAULTS in website/src/pages/chat/ChatSettings.tsx), so the app runs in that mode with an empty store, which is why this harness produced the attached captures deterministically at cf1ff2a15 and 0066b48b2. The seed was a no-op that documented a false premise. Fix: the seed is removed and replaced by a comment stating the default and the wipe; pillsReady already asserts the derived labels and the absence of the raw digests, so a flipped default fails the script loudly rather than capturing raw titles. Evidence: the harness re-run without the seed on the reviewed tree completes both captures (DARK shot taken / LIGHT shot taken). No shipped code changes.

@jingchaodev

Copy link
Copy Markdown
Contributor Author

Round on 0066b48b2 (same-tree re-roll): the Windows(4) worker crash did not recur; 1 red = GPT 5.6 BLOCK on the capture harness seed, fixed in 097ec4322 (record above). Rebased onto 28fee1199; one commit; the change is confined to the capture script, so the attached screenshots are unchanged. Full frontend suite (2146 files) and the fixture conformance on both sides pass on the rebased tree.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 16, 2026
@jingchaodev

Copy link
Copy Markdown
Contributor Author

Round on 097ec4322: 1 red, not attributable. Bundle Size Gate fails on chunk all by 4.7 KB, and the failing artifact is assets/all-CQ3u41MG.js at 11,903,674 B: the same content hash and byte size that main alone at 28fee1199 builds (this PR changes no catalog string; ToolCallLine.tsx and every locale file are byte-identical to main). Main itself crossed the 11620 KB ceiling this afternoon and the gate does not run on main, so the red surfaces on every PR's merge ref instead; tracked in #11388, with the convention raise carried by #11092 and #8985. Nothing in this diff can clear it; it clears when a raise lands on main. Every other check is green and all five lanes hold (GPT ✅ after the harness fix above).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 16, 2026
…itle

kiro-cli's injection of `__tool_use_purpose` is inconsistent for built-in
shell calls. When it is absent, kiro-cli titles the call with a digest of
the command's own argument fragments (`--title, --text, Three, 1. ...`),
and the row rendered that soup as the pill label: rule R0.0 in
utils/toolCallTitle takes any non-stub title that differs from
`rawInput.command` as the model's description, which outranks the
derived title in pickToolLabel.

A title whose every `, `-separated fragment (trailing ellipsis stripped)
occurs verbatim in the command is a digest OF the command, not a
sentence ABOUT it; R0.0 now returns undefined for it so the usual
derivation runs (a classified action, else the command in the code
face, else the binary digest). The Python mirror carries the same guard
and the shared fixture pins both sides with four new cases.

deriveShellSummary steps over wrappers (`sudo`), variable references
(`$PY`) and interpreters (`python3 script.py` -> `script.py`), and
attaches one sub-command word to the first meaningful name -- only for
tools and scripts that take one, so `cat x` stays `cat`. The observed
oncall command now digests to `ledger.py ticket-log` instead of `cd`.
@jingchaodev
jingchaodev force-pushed the feat/purposeless-pill-label branch from 097ec43 to 8b8eaba Compare September 17, 2026 22:59
@jingchaodev

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (2627b0407), pushed 8b8eaba41: same single commit, same content (7 files; ToolCallLine.tsx and the catalogs stay byte-identical to main). Purpose of the push: the Bundle Size Gate red on 097ec4322 was main's own all chunk crossing its old ceiling; main now carries the raise (12240 KB), so a head built on it clears the gate without this PR touching check-bundle-size.mjs. Local on the pushed tree: fixture conformance 274 (Python) and the full vitest suite green (two tree-scanning ratchet files timed out under concurrent load and pass alone; unrelated to this diff).

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after verification: PR Readiness success on this head, no active change requests or unresolved threads, mergeable against current main.

@bolichen97
bolichen97 merged commit cff7de5 into kirodotdev:main Sep 19, 2026
90 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 19, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…itle (kirodotdev#8294)

kiro-cli's injection of `__tool_use_purpose` is inconsistent for built-in
shell calls. When it is absent, kiro-cli titles the call with a digest of
the command's own argument fragments (`--title, --text, Three, 1. ...`),
and the row rendered that soup as the pill label: rule R0.0 in
utils/toolCallTitle takes any non-stub title that differs from
`rawInput.command` as the model's description, which outranks the
derived title in pickToolLabel.

A title whose every `, `-separated fragment (trailing ellipsis stripped)
occurs verbatim in the command is a digest OF the command, not a
sentence ABOUT it; R0.0 now returns undefined for it so the usual
derivation runs (a classified action, else the command in the code
face, else the binary digest). The Python mirror carries the same guard
and the shared fixture pins both sides with four new cases.

deriveShellSummary steps over wrappers (`sudo`), variable references
(`$PY`) and interpreters (`python3 script.py` -> `script.py`), and
attaches one sub-command word to the first meaningful name -- only for
tools and scripts that take one, so `cat x` stays `cat`. The observed
oncall command now digests to `ledger.py ticket-log` instead of `cd`.

Co-authored-by: Jingchao Cao <cjingcha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants