Skip to content

feat(agents): note under the create modal's template picker that the choice can change later - #8497

Merged
bolichen97 merged 1 commit into
mainfrom
feat/agents-modal-declutter
Sep 9, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/agents-modal-declutter

Conversation

@xuejinT

@xuejinT xuejinT commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

The Agent Template dropdown is the create modal's most consequential-looking field, and nothing tells a first-time user that the choice is reversible. Users stall on it — picking a template reads like a commitment, when in fact the binding can be changed at any time after the agent exists.

Why it matters

Hesitation at the first field of the create flow is friction exactly where the product wants momentum. A one-line reassurance removes the stall without adding any new UI surface.

What changed (motivation → approach → change)

Goal: tell the creator the template pick is not permanent, without promising capabilities that don't exist and without adding noise to the editor.

  • TemplateField gains a create-only editLaterNote prop. The create form passes it; the editor mounts the same component without it — in the editor the editable fields are themselves the answer, so the note would be noise there.
  • The note reads "Pick the closest starting point — you can switch this agent's template anytime after creating." It deliberately says switch the template, not edit the instructions/tools: on main today, switching the binding is exactly what the edit modal offers.
  • Copy says "this agent", not "the template": a template edit would imply blast radius onto other agents bound to it, which a binding switch does not have.
  • Localized in all 13 catalogs (12 translations + regenerated en-XA pseudo-locale).

This PR originally also removed the Session Color editor; per the review, that removal is split out to its own PR (see the branch feat/agents-session-color-removal) so the product question it raises gets its own discussion. This diff is now the note alone.

Tests

website/src/test/KiroCrewAgentsPage.templateEditLaterNote.test.tsx (new):

  • the note renders under the Agent Template field in the create sheet;
  • the note does not render in the edit sheet's template pane, which mounts the same TemplateField — pinning the create-only prop split the review asked to see asserted.

Manual verification

Captured via the gateway-free harness website/scripts/capture-template-edit-later-note.mjs (real built SPA, fixture-stubbed API). Its self-checks fail the run if the note is missing from create or leaks into the edit template pane, so the frames below cannot go stale silently.

Screenshots / video

Create modal — note under the template dropdown:

create modal with the edit-later note

Edit modal, template pane — same field, no note:

edit modal template pane without the note

Related Issues

no linked issue: UX polish item from design review of the Agents page; no tracking issue exists.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — N/A, UI copy only
  • No secrets, credentials, or internal references in the diff

@xuejinT
xuejinT requested review from a team and pepmach September 4, 2026 16:57
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 12635ed65c920e8545408710cd342a95f3f0b07a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Real friction, minimal fix at the right seam: create-only prop on the shared field, honest copy scoped to the binding, pinned by a create/edit split test.

[DESIGN-REVIEWED] 12635ed

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 12635ed65c920e8545408710cd342a95f3f0b07a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

All evidence is in hand. The blind reader correctly understood the note's meaning ("reassurance that the template choice isn't permanent" — exactly the PR's intent) and even connected it to the edit modal's template pane unprompted, so the copy works. Two residual issues: the reader thought the accent-purple text looked clickable ("the colour makes it look clickable, like a link… I might try clicking it"), and text-accent is indeed this codebase's interactive/link color (MarkdownRenderer links, AskAgentButton, hover states), so the static note carries a false affordance. Second, the diff also ships a member-flow variant string (template_edit_later_note_member, rendered when creating from the members roster per KiroCrewAgentsPage.tsx:993) that appears in no screenshot.

UX-Verdict: CONCERNS

The note reads perfectly — but its accent-purple styling is the product's link color, so static reassurance text presents a false click affordance.

Watch

  • Accent-colored note reads as a link: text-accent + sparkle is this codebase's interactive treatment (MarkdownRenderer links, AskAgentButton), and the blind reader said "the colour makes it look clickable, like a link — I might try clicking it." Every first-time creator sees it; a dead click is minor friction, once per user — but it also makes nice-to-know reassurance the loudest text in the modal while sibling hints are muted. Fix: keep the Sparkles icon, drop the text to the form's standard muted hint color (or a non-interactive emphasis token).

Evidence gaps

  • The member-flow variant ("switch this member's template…", rendered when formSubject === 'member', KiroCrewAgentsPage.tsx:993) appears in no committed screenshot; a capture of the members-roster create sheet would close it.

[UX-REVIEWED] 12635ed

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 12635ed65c920e8545408710cd342a95f3f0b07a — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

All checks complete. The change is small and conventional in every mechanical respect; the one contract-relevant finding is the provenance of the harm itself. Final review:

First-Principles-Verdict: CONCERNS

The stall this note removes is asserted, never evidenced — the description itself says "no tracking issue exists" — so the whole addition rests on one design-review opinion.

Not justified as shipped

  1. The create-modal note — inherited premise: "Users stall on it" is supported only by "UX polish item from design review … no tracking issue exists", the same unpointable shape the contract rejects for defects.
  2. Member-worded variant of the note — undeclared: the description never mentions it (it is justified on its own — "this agent's template" inside the Add crew member form would mislabel what the user is creating — but it must be declared).

What this change ships

Inventory (6 items) — 4 justified

Intent: reassure a first-time creator that the template pick in the create modal is reversible — an ADDITION.

  1. Create modal shows a note under Agent Template saying the pick can be switched after creating — inherited premise (stall asserted, unevidenced)
  2. The members-origin create form shows the same note worded "this member" — undeclared
  3. Editor's template pane shows no note (create-only editLaterNote prop) — justified
  4. Two strings added to all locale catalogs — justified
  5. New gateway-free screenshot harness for the note — justified
  6. Two PNG frames committed under temp-screenshots/ — justified

Watch

  • The note's harm has no checkable provenance: "Users stall on it — picking a template reads like a commitment" is the description's only support, and it concedes "no linked issue … no tracking issue exists". A one-line note is trivially deletable, so this is not a blocker — but the premise is a design-review opinion, not an observed failure. Clears when: the design-review finding, a user report, or any observed hesitation at that field is linked in the PR.
  • The copy promises "you can switch this agent's template anytime after creating" — true today (the edit modal's template pane mounts the same TemplateField, KiroCrewAgentsPage.tsx:1937) and pinned by the new test's edit-pane combobox assertion; nothing further needed, noted only so a future removal of the edit pane knows a UI promise depends on it. Clears when: it already holds — the vitest suite in this PR asserts the edit pane still owns the field.

[FIRST-PRINCIPLES-REVIEWED] 12635ed

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 12635ed65c920e8545408710cd342a95f3f0b07a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 12635ed

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 12635ed65c920e8545408710cd342a95f3f0b07a: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 12635ed65c920e8545408710cd342a95f3f0b07a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 12635ed

Verdict parsed from the review's SHA-scoped output markers for commit 12635ed65c920e8545408710cd342a95f3f0b07a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 12635ed65c920e8545408710cd342a95f3f0b07a: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 4, 2026
@xuejinT
xuejinT force-pushed the feat/agents-modal-declutter branch from 7f1ad4a to 1ad4af9 Compare September 4, 2026 17:46
@xuejinT

xuejinT commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=5d8d70850f5d — Disposition: fixed in 1ad4af9.

"change this agent's instructions, skills, and tools" is false because prompt/tools are read-only and skill edits affect every crew using the shared template -> Fix: promise only that the selected template can be changed after creation.

Correct — the wording promised edit capabilities that do not exist on this base. The note now reads "Pick the closest starting point — you can switch this agent's template anytime after creating", which is exactly what the edit modal supports. Updated in English + all 11 locales + pseudo-locale, re-captured the create-modal screenshot, and reconciled the PR body's description of the wording.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 4, 2026
@xuejinT
xuejinT force-pushed the feat/agents-modal-declutter branch from 1ad4af9 to 74abecf Compare September 4, 2026 22:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 4, 2026
@xuejinT
xuejinT requested a review from bolichen97 September 8, 2026 16:48
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 8, 2026
xuejinT added a commit that referenced this pull request Sep 8, 2026
…t modals

Design-owner-directed removal of the Session Color picker from both agent
modals. The field itself stays: a stored colour is loaded on open and
written back on save, so agents that already carry one keep their tint,
and server-side session tinting is untouched.

Reverses the UI half of #6106. Split out of #8497 at the maintainer's
request so the product question — keep a minimal clear-colour control,
land colour auto-assign first, or drop the feature outright — gets its own
review rather than riding a declutter PR.

Deletes SessionColorField, its i18n strings in all 13 catalogs, its dirty-
pane tracking, and its unit tests; the capture harness asserts no colour
control survives in either modal.
@CrysisDeu

Copy link
Copy Markdown
Contributor

@bolichen97 — the split you asked for has landed (head 571ce800a): this PR is now the template note + 13 catalog strings only, SessionColorField and its test are untouched, and KiroCrewAgentsPage.templateEditLaterNote.test.tsx asserts the note renders in Create and not in Edit. Your CHANGES_REQUESTED (Session Color removal) no longer applies to this diff — could you re-review or dismiss it? All 63 checks are green and PR Readiness has passed, so that review is the only thing holding this one.

@CrysisDeu
CrysisDeu dismissed bolichen97’s stale review September 8, 2026 20:47

Dismissing as stale: this review asked to split out the Session Color removal. The split landed (head 571ce80 is the template note only, with the create-yes/edit-no render test requested). Re-review was requested at 19:39 UTC with no response after 60 min; all checks green and PR Readiness passed.

@CrysisDeu

Copy link
Copy Markdown
Contributor

Dismissed the 09-05 CHANGES_REQUESTED as stale (owner action): its subject — the Session Color removal — was split out of this PR at 571ce80, and re-review went unanswered for 60 min. @bolichen97 happy to reinstate if anything in the remaining template-note diff still concerns you. Checks 63/63 green, Readiness passed, MERGEABLE.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 9, 2026
CrysisDeu pushed a commit that referenced this pull request Sep 9, 2026
…choice can change later

The Agent Template dropdown is the create modal's highest-stakes-looking
field: first-time users stall on it, assuming the pick is permanent. A
one-line note under the dropdown says the template can be switched anytime
after creating. Create-only via TemplateField's editLaterNote prop — the
editor renders the same field without it, since there the editable fields
are themselves the answer. Localized in all 13 catalogs.

Split out of #8497's original combined diff at the maintainer's request;
the Session Color removal now rides its own PR.
@CrysisDeu
CrysisDeu force-pushed the feat/agents-modal-declutter branch from 571ce80 to 8a7d950 Compare September 9, 2026 08:28
@CrysisDeu

Copy link
Copy Markdown
Contributor

Rebased onto main (571ce800a -> 8a7d95045) to clear the conflict; no semantic change -- @xuejinT FYI. Main merged #9515 (create-form fields now take a required subject: FormSubject); TemplateField keeps both that subject prop and this PR's editLaterNote, and BindingFields passes both. tsc / eslint / i18n-check pass locally. Still one commit, your authorship.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 9, 2026
CrysisDeu pushed a commit that referenced this pull request Sep 9, 2026
…choice can change later

The Agent Template dropdown is the create modal's highest-stakes-looking
field: first-time users stall on it, assuming the pick is permanent. A
one-line note under the dropdown says the template can be switched anytime
after creating. Create-only via TemplateField's editLaterNote prop — the
editor renders the same field without it, since there the editable fields
are themselves the answer. Localized in all 13 catalogs.

Split out of #8497's original combined diff at the maintainer's request;
the Session Color removal now rides its own PR.
@CrysisDeu
CrysisDeu force-pushed the feat/agents-modal-declutter branch from 8a7d950 to a615472 Compare September 9, 2026 08:42
@CrysisDeu

Copy link
Copy Markdown
Contributor

Pushed 8a7d95045 -> a615472e5 — @xuejinT FYI: after the rebase, main's #9515 test CrewRoster.test.tsx › ?new=1&from=members titles the form in the roster's words failed on this PR's merge ref — that flow pins queryByText(/this agent/) to null, and the new note says "switch this agent's template anytime". Fixed the way #9515 handles every other field string: the note now follows subject — new key template_edit_later_note_member ("…switch this member's template anytime…") in all 12 catalogs + regenerated en-XA; TemplateField picks it when subject === 'member'. Added a case to KiroCrewAgentsPage.templateEditLaterNote.test.tsx pinning the member wording. Translations are mine — please eyeball them. Still one commit, your authorship.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 9, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor

Backend Tests (3.12, 4) / (Windows) (4) red on the current head is inherited from main: test_workflows_app.py::test_main_boots_platform_before_binding_server fails on main itself at 67716d722 (semantic collision between #9413 and #9066, tracked in #9675). Nothing in this PR touches it; no rerun, will rebase once main carries the fix.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 9, 2026
…choice can change later

The Agent Template dropdown is the create modal's highest-stakes-looking
field: first-time users stall on it, assuming the pick is permanent. A
one-line note under the dropdown says the template can be switched anytime
after creating. Create-only via TemplateField's editLaterNote prop — the
editor renders the same field without it, since there the editable fields
are themselves the answer. Localized in all 13 catalogs.

Split out of #8497's original combined diff at the maintainer's request;
the Session Color removal now rides its own PR.
@CrysisDeu
CrysisDeu force-pushed the feat/agents-modal-declutter branch from a615472 to 12635ed Compare September 9, 2026 11:27
@CrysisDeu

Copy link
Copy Markdown
Contributor

Rebased onto main (a615472e5 -> 12635ed65) to pick up the #9675 fix (#9682); clean rebase, no semantic change -- @xuejinT FYI. The shard-4 reds should clear on this head.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 9, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now that the Session Color removal was split into #9494 as requested; what remains is the one-line reassurance under the template picker plus its 13 catalogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants