Repository navigation
feat(agents): note under the create modal's template picker that the choice can change later - #8497
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Real friction, minimal fix at the right seam: create-only prop on the shared field, honest copy scoped to the binding, pinned by a create/edit split test. [DESIGN-REVIEWED] 12635ed |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of All evidence is in hand. The blind reader correctly understood the note's meaning ("reassurance that the template choice isn't permanent" — exactly the PR's intent) and even connected it to the edit modal's template pane unprompted, so the copy works. Two residual issues: the reader thought the accent-purple text looked clickable ("the colour makes it look clickable, like a link… I might try clicking it"), and UX-Verdict: CONCERNS The note reads perfectly — but its accent-purple styling is the product's link color, so static reassurance text presents a false click affordance. Watch
Evidence gaps
[UX-REVIEWED] 12635ed |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All checks complete. The change is small and conventional in every mechanical respect; the one contract-relevant finding is the provenance of the harm itself. Final review: First-Principles-Verdict: CONCERNS The stall this note removes is asserted, never evidenced — the description itself says "no tracking issue exists" — so the whole addition rests on one design-review opinion. Not justified as shipped
What this change shipsInventory (6 items) — 4 justifiedIntent: reassure a first-time creator that the template pick in the create modal is reversible — an ADDITION.
Watch
[FIRST-PRINCIPLES-REVIEWED] 12635ed |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
7f1ad4a to
1ad4af9
Compare
Correct — the wording promised edit capabilities that do not exist on this base. The note now reads "Pick the closest starting point — you can switch this agent's template anytime after creating", which is exactly what the edit modal supports. Updated in English + all 11 locales + pseudo-locale, re-captured the create-modal screenshot, and reconciled the PR body's description of the wording. |
1ad4af9 to
74abecf
Compare
…t modals Design-owner-directed removal of the Session Color picker from both agent modals. The field itself stays: a stored colour is loaded on open and written back on save, so agents that already carry one keep their tint, and server-side session tinting is untouched. Reverses the UI half of #6106. Split out of #8497 at the maintainer's request so the product question — keep a minimal clear-colour control, land colour auto-assign first, or drop the feature outright — gets its own review rather than riding a declutter PR. Deletes SessionColorField, its i18n strings in all 13 catalogs, its dirty- pane tracking, and its unit tests; the capture harness asserts no colour control survives in either modal.
|
@bolichen97 — the split you asked for has landed (head |
Dismissing as stale: this review asked to split out the Session Color removal. The split landed (head 571ce80 is the template note only, with the create-yes/edit-no render test requested). Re-review was requested at 19:39 UTC with no response after 60 min; all checks green and PR Readiness passed.
|
Dismissed the 09-05 CHANGES_REQUESTED as stale (owner action): its subject — the Session Color removal — was split out of this PR at 571ce80, and re-review went unanswered for 60 min. @bolichen97 happy to reinstate if anything in the remaining template-note diff still concerns you. Checks 63/63 green, Readiness passed, MERGEABLE. |
…choice can change later The Agent Template dropdown is the create modal's highest-stakes-looking field: first-time users stall on it, assuming the pick is permanent. A one-line note under the dropdown says the template can be switched anytime after creating. Create-only via TemplateField's editLaterNote prop — the editor renders the same field without it, since there the editable fields are themselves the answer. Localized in all 13 catalogs. Split out of #8497's original combined diff at the maintainer's request; the Session Color removal now rides its own PR.
571ce80 to
8a7d950
Compare
|
Rebased onto main ( |
…choice can change later The Agent Template dropdown is the create modal's highest-stakes-looking field: first-time users stall on it, assuming the pick is permanent. A one-line note under the dropdown says the template can be switched anytime after creating. Create-only via TemplateField's editLaterNote prop — the editor renders the same field without it, since there the editable fields are themselves the answer. Localized in all 13 catalogs. Split out of #8497's original combined diff at the maintainer's request; the Session Color removal now rides its own PR.
8a7d950 to
a615472
Compare
|
Pushed |
|
Backend Tests (3.12, 4) / (Windows) (4) red on the current head is inherited from main: |
…choice can change later The Agent Template dropdown is the create modal's highest-stakes-looking field: first-time users stall on it, assuming the pick is permanent. A one-line note under the dropdown says the template can be switched anytime after creating. Create-only via TemplateField's editLaterNote prop — the editor renders the same field without it, since there the editable fields are themselves the answer. Localized in all 13 catalogs. Split out of #8497's original combined diff at the maintainer's request; the Session Color removal now rides its own PR.
a615472 to
12635ed
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving now that the Session Color removal was split into #9494 as requested; what remains is the one-line reassurance under the template picker plus its 13 catalogs.
Problem / Motivation
The Agent Template dropdown is the create modal's most consequential-looking field, and nothing tells a first-time user that the choice is reversible. Users stall on it — picking a template reads like a commitment, when in fact the binding can be changed at any time after the agent exists.
Why it matters
Hesitation at the first field of the create flow is friction exactly where the product wants momentum. A one-line reassurance removes the stall without adding any new UI surface.
What changed (motivation → approach → change)
Goal: tell the creator the template pick is not permanent, without promising capabilities that don't exist and without adding noise to the editor.
TemplateFieldgains a create-onlyeditLaterNoteprop. The create form passes it; the editor mounts the same component without it — in the editor the editable fields are themselves the answer, so the note would be noise there.maintoday, switching the binding is exactly what the edit modal offers.en-XApseudo-locale).This PR originally also removed the Session Color editor; per the review, that removal is split out to its own PR (see the branch
feat/agents-session-color-removal) so the product question it raises gets its own discussion. This diff is now the note alone.Tests
website/src/test/KiroCrewAgentsPage.templateEditLaterNote.test.tsx(new):TemplateField— pinning the create-only prop split the review asked to see asserted.Manual verification
Captured via the gateway-free harness
website/scripts/capture-template-edit-later-note.mjs(real built SPA, fixture-stubbed API). Its self-checks fail the run if the note is missing from create or leaks into the edit template pane, so the frames below cannot go stale silently.Screenshots / video
Create modal — note under the template dropdown:
Edit modal, template pane — same field, no note:
Related Issues
no linked issue: UX polish item from design review of the Agents page; no tracking issue exists.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)