Repository navigation
Conversation
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Opus 5.5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Two unrelated test files were rewritten and the description doesn't mention either. One of them now checks permissions through a private helper instead of the scenario path. Watch
[DESIGN-REVIEWED] 6dafbb2 Description read[DESCRIPTION-READ] db098889dfaa64852a0540263dfc0dbf3935b70f94f186399111b8c43fcb1afc That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge. FINDING — docs/system-specs/modules/session.md:106 — the added line [OPUS-REVIEWED] 6dafbb2 |
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The defect itself has no evidence on record: nothing measures or links the claim that Not justified as shipped
What this change shipsInventory (8 items) — 3 justifiedIntent: stop history extraction from making cron and maintenance jobs wait. FIX.
[FIRST-PRINCIPLES-REVIEWED] 6dafbb2 Description read[DESCRIPTION-READ] bc9384dfc7d4eac96c3943b95eb41b40e53ce96f36937c6e03b8145b62f33b77 That sha256 names the PR description this verdict read. Recompute it with |
bcb40fa to
7ae8904
Compare
7ae8904 to
f7e44aa
Compare
|
Rebased onto main Clean rebase — no conflicts. The diff is unchanged (9 files, +102/-30); the only drift main introduced was the removal of the Gates run locally on changed files only: Please review the rebase. A maintainer push makes the maintainer the last pusher, so a second approver is needed under the repo's last-push rule. Reply if anything looks wrong. |
f7e44aa to
3807d1f
Compare
3807d1f to
4c39ae9
Compare
b553d68 to
4f1e8d1
Compare
|
Open-PR triage (2026-10-05), checked against Verdict: DISTINCT, keep. No breaking change and no P0 found. Nothing on main or in another open PR moves history extraction off Two non-blocking items on the current head
Related, but not duplicates: #9900 (cross-process consolidation lease) and #14984 (merged; RSS recycling, which |
6c5a1b0 to
f07cdaf
Compare
f07cdaf to
ebb6436
Compare
ebb6436 to
6de55aa
Compare
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
|
Thank you @Premshay for this fix! It is now carried by #19733, rebased onto current main with your commit and authorship kept in the git history (plus a Closing this one in favour of #19733. Your branch is left untouched. |
Problem / Motivation
Goal: Long history consolidation no longer makes lightweight background jobs (cron, maintenance) wait behind it.
History consolidation uses the shared
_bgsession, coupling long memory extraction to latency-sensitive background micro-jobs.Why it matters
Lightweight maintenance queues behind consolidation even though it neither needs its context nor its admission path.
Not a goal
_bgsession's behaviour for the jobs that keep using it.What changed (motivation → approach → change)
History extraction runs on its own stateless
_consolidatesession instead of_bg, so its long turns no longer hold the semaphore the background micro-jobs share;_bgbehaviour is unchanged._PERSISTENT_KEYS: idle cleanup reclaims its process like any other session, and an active consolidation turn is never expired mid-turn (its semaphore is held). Recycling after a full context recycles its own provider._TELEMETRY_EXACT_KEYSentry ("_consolidate": "consolidation"), the same table that already names_bgand_hb; no new prefix rule.Backwards compatibility
Compatible: nothing that works today stops working —
_bgsessions keep the same behaviour and admission path, andsel._infer_sourcemaps the new_consolidatekey to the samebackgroundsurface, so attribution and spend accounting are unchanged.Removes nothing: the change is additive — one new session key plus its stateless-expiry entry; no key, kind, or entry point that main accepts is renamed, rejected, or removed.
Pattern harvest
Rule candidate: long-running maintenance needs a distinct admission identity from latency-sensitive background work.
Tests
python -m pytest -q test/test_session.py test/test_background_turn_accounting.py test/metrics/test_startup_channel_attrs.py— 448 passed; the history/consolidation/session-background files — 732 passed. New coverage: the exact-key telemetry label, separate keys for extraction and the cheap judge, idle expiry and re-creation without resume, an active consolidation surviving the sweep, and recycling its own provider.Manual verification
N/A — focused automated coverage is sufficient.
Related Issues
N/A.
Checklist
Contribution License Agreement
N/A — template placeholder; no CLA wording is supplied.