Repository navigation
Conversation
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify kiro-cli's Suggestions
[DESIGN-REVIEWED] 6601474 Description read[DESCRIPTION-READ] 1c21174994eebe4d1962b0e00cb3aa433e725059da48209bdb6dea68d4ec5fd7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify a bracketed id saved today actually applies at cron fire time — What this change shipsInventory (3 items) — 2 justifiedIntent: let users save cron/spawn model selections whose ids carry a provider qualifier like
Provenance checked: [FIRST-PRINCIPLES-REVIEWED] 6601474 Description read[DESCRIPTION-READ] cdd06c538af127bf398bf4e3e8dfa4c6d42963ed3718147fed140c12c8855e62 That sha256 names the PR description this verdict read. Recompute it with |
|
@Premshay Thanks for the patch. I checked it against What The remaining scope worth keeping is the narrower one: show one real entry point that rejects Two blockers before it can land: the branch is 130 commits behind Posted from the 2026-09-08 open-PR relationship audit (read-only, one auditor per PR); reply here if any of this is wrong. |
15f350a to
17f72a5
Compare
17f72a5 to
13a8a66
Compare
13a8a66 to
57817f6
Compare
|
Checked this against your note. The configured selections that carry a model id are gated by The branch now widens The description's "kept in sync" line referred to that earlier, wider patch; the corrected description goes with this head. Rebased onto current |
86d45af to
32615dd
Compare
|
Fixed in 32615dd: the unrelated website/scripts/restyle-baseline.json hunk is gone. The repaired branch has no website diff against its upstream base. |
|
Fixed in 32615dd: _MODEL_NAME_RE now accepts exactly one optional, nonempty trailing bracket qualifier. Regression tests reject empty, unbalanced, nested, repeated and non-trailing qualifiers through both spawn validation and the cron endpoint. All 43 focused tests pass. |
|
The Black baseline change is retained because test/test_model_selection.py is touched by the regression coverage and is now Black-clean. scripts/check_black_formatting.py requires removing newly clean files from the exemption list; restoring that entry would fail the ratchet. The formatting gate passes at 32615dd. This is limited to the touched test, with no frontend baseline changes. |
Configured model selections — cron job pins and per-spawn overrides — are validated by _MODEL_NAME_RE, which rejects provider-qualified ids such as gpt-6-astra[high] that the live kiro-cli model list advertises, so a user selecting one cannot save the job. Admit [ and ] in the charset; the leading-alphanumeric anchor still blocks CLI-flag injection. MODEL_ID_RE and its AcpRuntime rejection message stay on the narrower charset: no production call site passes model= to AcpRuntime.
32615dd to
6601474
Compare
|
Verified unchanged head 6601474. The current PR description passes the repository hygiene check, so the earlier missing-section report is stale. Qualified-model validation and cron approval tests plus the exact reported third-turn routing node: 44 passed on Linux. The third-turn node also passes on clean upstream 5ca51b0. This does not reproduce the Windows failure or establish a baseline Windows failure; that remains unresolved. No code or branch rewrite was needed for the stale hygiene finding. |
|
Further triage of the exact Windows failure at head 6601474: job https://github.com/kirodotdev/KiroCrew/actions/runs/36839359625/job/110297329572 reports only two receipt rows in test_a_third_turn_routes_from_the_base_model_again, and its captured log includes “decisions: could not append log row: could not acquire exclusive file lock: still held after waiting 0.50s (limit 0.5s); refusing to proceed unserialized”. It also reports the fixture AsyncMock's non-iterable OAuth drain result. I traced the decision receipt through the bounded log append/commit-event path and inspected the test's _settle helper: it awaits or cancels the slot task; it does not synchronize the decision log's background file operation. This narrows the investigation to native-Windows receipt/file-lock behavior, but does not prove the cause of that lock timeout. The PR does not change these decision-log/test-helper files. The previously passing exact Linux test is not Windows verification. No portable deterministic defect has been established here, and no timing threshold, lock guard, or assertion was weakened. Next verification needs the Windows 3.12 shard environment with instrumentation identifying the lock holder and append-task completion. The PR-description hygiene finding remains already addressed. |
|
Current hygiene is already verified on unchanged head 6601474: PR Hygiene job 110317817746, created after the failed 09:02 job, passed at 10:02 UTC. Its workflow run reports this exact head SHA. The older failure remains visible in the rollup but is not evidence that the current description is malformed. The current body also passes the repository description checker locally. Updated only the Tests evidence and unchecked the blanket existing-tests-pass checkbox to record the unresolved Windows result; Goal, Why it matters, and Not a goal remain unchanged. No source or branch change. The remaining Windows shard 1 failure is test/test_decisions_model_route_ratchet.py::test_a_third_turn_routes_from_the_base_model_again: the third decision row is absent, alongside |
Widen the shared cron/subagent _MODEL_NAME_RE to accept exactly one optional non-empty trailing bracket qualifier (e.g. gpt-6-astra[high]). Empty, unbalanced, nested, repeated or non-trailing qualifiers and shell metacharacters remain rejected. MODEL_ID_RE and ACP runtime validation are unchanged. The touched test file is Black-clean, so its baseline exemption is removed. Fixes #17891 Replaces #9054 by @Premshay Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com>
|
Thank you for this fix, @Premshay! Your |
Widen the shared cron/subagent _MODEL_NAME_RE to accept exactly one optional non-empty trailing bracket qualifier (e.g. gpt-6-astra[high]). Empty, unbalanced, nested, repeated or non-trailing qualifiers and shell metacharacters remain rejected. MODEL_ID_RE and ACP runtime validation are unchanged. The touched test file is Black-clean, so its baseline exemption is removed. Fixes #17891 Replaces #9054 by @Premshay Co-authored-by: cixuuz <26782336+cixuuz@users.noreply.github.com> Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com>
Problem / Motivation
Goal: Cron and subagent model selections can use the provider-qualified ids (such as
gpt-6-astra[high]) that the model picker itself offers.Provider-qualified effort variants such as
gpt-6-astra[high]are rejected when a dashboard cron or a subagent spawn records a model selection, despite being safe model identifiers advertised by kiro-cli's own model list.Why it matters
Cron and spawn model selections whose ids carry a provider qualifier cannot be saved or applied.
Not a goal
MODEL_ID_REor theAcpRuntimemodel validation.What changed (motivation → approach → change)
The shared spawn and cron
_MODEL_NAME_REaccepts one optional, nonempty trailing bracket qualifier. Unbalanced, nested, repeated, empty and non-trailing qualifiers remain rejected, as do shell metacharacters.MODEL_ID_REand ACP runtime validation are unchanged.The unrelated frontend restyle-baseline edit is removed. The touched model-selection test is Black-clean, so the required formatting ratchet removes its baseline exemption.
Backwards compatibility
Compatible: existing unqualified ids match the new pattern unchanged; the pattern only adds the bracket-qualifier class.
Pattern harvest
Rule candidate: when a provider protocol qualifies a value with a bounded suffix, extend a constrained allowlist rather than bypassing validation.
Tests
Verified locally on the repaired branch:
Broader backend run previously reported 49,499 passes, 135 failures and 112 skips. All 135 failed identifiers were rerun against clean upstream base
6819b80069d1bf56c4263be5c453d54cad82de34: 134 failed there too; the remaining session-control case passed on both that base and this repair branch. The full backend suite is not claimed green.Full mypy checked 1,995 source files and reported one Python 3.14 compatibility error at
src/kiro_crew/cli.py:448(asyncio.PidfdChildWatcher). A focused mypy run against the same CLI file on the clean base reproduces that error.Current-head Windows evidence: shard 1 failed
test_a_third_turn_routes_from_the_base_model_again: the third decision-log row was missing after an exclusive file-lock timeout (0.5 seconds). The exact test passes on Linux at this head and clean based8fa6a527e927504b399246332cd243d7b450e2f; its test and decision-log implementation are byte-identical there. This does not establish a Windows baseline failure or a flaky result. Native Windows reproduction is still needed to identify the lock holder.The failed PR Hygiene job read an older description missing
**Goal:**and## Not a goal. The current body contains both and passes the repository's description checker.Manual verification
N/A — focused automated coverage is sufficient.
Related Issues
N/A.
Checklist
Contribution License Agreement
N/A — template placeholder; no CLA wording is supplied.