Repository navigation
Conversation
|
Intent: Let a scheduled cron job optionally bind to a project directory, so both the Schedule page's agent picker and fire-time execution can use that project's own |
Design Review (Opus 5.5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Chat resolution changes along with the cron feature: directory-bound chat slots lose a crew's private memory, and that change can't be reverted alone. Watch
Suggestions
[DESIGN-REVIEWED] e389382 Description read[DESCRIPTION-READ] 2dc683e2585db6fa17ca7a56ef764532653bcf98b379e937c1da9bd5eedbfe00 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS A typo in the project path says the agent "isn't defined in this project" when the real problem is that the path doesn't exist. Watch
Suggestions
[UX-REVIEWED] e389382 Description read[DESCRIPTION-READ] 7d38c6cf9a047e81b943c93d23e6a70fc1d39e82555bb7844bd73623e40e6ed1 That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The shared resolver now lets a project file beat a crew alias in every directory-bound chat, not just in cron jobs. That is the chat change Not justified as shipped
What this change shipsInventory (10 items) — 7 justifiedIntent: a scheduled job runs as the agent you picked or skips with a reason, and can use a checkout's agents. This is an ADDITION plus a FIX.
[FIRST-PRINCIPLES-REVIEWED] e389382 Description read[DESCRIPTION-READ] dd7dc29c7541573917dc8455abfa8e31d7eea77b7901df6194c25120332c41be That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed 2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/dashboard/websocket_hub.py:185 -- Slot summaries expose project-bound output to non-owners
BLOCKING -- src/kiro_crew/slack/gateway.py:6244 -- Project overrides conflict with persistent execution records
[BLOCK-MERGE] e389382 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 (fenced): cross-user information exposure. The slot projection copies a cron row's text into F2 (fenced): every fire of an affected persistent job aborts, and the job stays stuck until someone edits it. If the session's record already belongs to a different execution, a bind without replace raises "session already belongs to another execution" ( |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings block this merge. Two advisory issues remain. FINDING — website/src/components/JobForm.tsx:16151 (diff line) — FINDING — src/kiro_crew/dashboard/messaging_api/notifications.py:4074 (diff line) — for a non-owner, the handler filters [OPUS-REVIEWED] e389382 |
d27f62b to
d48d067
Compare
|
|
|
|
|
|
|
|
|
d48d067 to
b1147c7
Compare
|
|
|
|
Rebased:
Why the AI review lanes have not been publishing. The authentic-diff step in every fork review workflow fails closed above 1,000,000 bytes, before any code is read. This PR's diff was 1,013,138 — 13,138 over — so GPT, Opus, Security Scope, Design, First Principles and UX were all exiting in 94-102s without reviewing (UX reports that as success, titled "skipped — no UI surface"). The diff is now 993,813 bytes, 6,187 under the cap. How the bytes were freed — test consolidation only, no feature code removed and no test deleted:
A stale spec citation to one of the merged-away test files was caught by docs-lint and repointed to the merged file. Verified on this head: mypy clean (2,183 files), flake8/black/isort clean, isort tripwire 0, docs-lint clean, |
|
Landing order, so reviewers aren't reviewing a half that will change. @bolichen97's triage note flagged that this PR and #10107 both add Why that way round: #10107 uses What changes here after #10107 merges: The cost, stated plainly: the endpoint read then answers 503 @Zedmor @dodgeblaster — the cron-side logic is the part worth your review time; the endpoint half is scheduled to change and I'll push that swap once #10107 is in. I can't make it now: |
|
Fixed: span=d9f6439f8c84 — The finding was exact: the heading sat at byte 7,564 while the lane reads only the first 8,000, so just 436 bytes of the section were visible and all of it was prose. The section now opens with the reader list, measured to close inside the window:
Those are every caller of Verified on the published body rather than a local draft: the section now starts at byte 7,441, leaving 559 bytes, and all five lines close inside the window under LF and worst-case CRLF — an earlier attempt passed under LF and cut the fifth line under CRLF. Bytes for this were freed by compressing four verbose passages in |
|
Fixed: span=9a36abcd2692 — the description overclaimed; the code was right. Scoped the guarantee and gave the reason. I checked the code before rewording, and the finding is correct: both fire paths gate the named skip on So the description was the defect, not the gate. It now reads:
That takes the first of the two offered exits — scope the guarantee and state the reason — rather than widening the skip to recurring unbound jobs, which would be the behaviour change the code comment deliberately avoids. |
|
Accepted and deferred: span=8ebb37a6b9cb — the finding is correct. "Unbind the member" names no control, and I am not rebutting that. I checked rather than argued. The message is Two reasons this is a defer rather than a fix on this head:
Recorded for the same round as those fixes: reword the second remedy to name an action the UI offers, or add the control. Not forgotten, and not disputed. |
|
Rebutted: span=33b0b942bc0a — the The observation is accurate: in attachment-03 Those axes are independent, and the combination the finding reads as noise is the informative case: a project-supplied agent whose provenance is still Kiro Crew's own format is genuinely It is also the pre-existing convention rather than something this PR introduced: If the concern is visual density rather than correctness, that is a picker-wide question about showing provenance at all — it applies equally to every configured row on |
|
Both blocking findings are FIXED in F2 — - if not bound_windows:
- return list(history), FalseThe report named the mechanism exactly: retention keeps 100 records per job, so pruning removes a bound run's record while its transcript rows survive, after which an empty F1 — The adjudication's note that neither disclosure table listed Verification. The regression tests fail against unpatched On diff size. The fix cost 18,013 bytes against 6,187 of headroom under the 1,000,000-byte cap that kept every lane from reading this PR until the previous head. Rather than trim the fix, I paid for it by splitting out the isolated |
|
Open-PR triage (origin/main Rebase needed. The merge base Breaking change, declared but not yet signed off. The First-Principles review already raised the first point below. I am adding the second, which has not been raised by anyone other than the author:
A maintainer needs to accept both flips explicitly before merge. I found no P0 at this head. The fenced GPT finding F1 (transcript replay to a non-owner) is now handled by Overlaps (not duplicates):
Recommendation: REBASE + MERGE-DISCUSSION. Keep this PR open; it is not superseded. |
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: @mbajaj92, checking in on this PR for #8952 (also referenced from #13349). What blocks it today at Do you still plan to finish it? If there is no reply within 7 days, a maintainer may take the PR over to land the change. |
|
Thanks for this PR. It now conflicts with main. Could you rebase onto the latest main and resolve the conflicts? We will review it again once it is rebased and CI is green. |
Code change approver recommendation: A person should decideWhy: the decider raised 2 possible problems and estimates a 60% chance that this change introduces a defect; a person should check them. Large PR that lets scheduled jobs bind to a project directory, records a template namespace for the agent, and blocks agent- and app-driven activation of project-bound jobs. The backend gates are wired into every activation path I found, the compare-and-swap checks hold under the store lock, and import is handled correctly. Two defects remain. (1) The Schedule form's project-roster check resets a stored configured-alias agent on any project-bound job as soon as the form opens, and the next unrelated save rewrites the job's agent. The server and the PR's own backend test treat that pairing as valid, and no test covers it. (2) The new narrow exception catch in CronSDK.set_enabled drops the SEL 'denied' audit for missing jobs, because cron.py:1134 still raises a plain PermissionError; the existing test passes vacuously. No test, lint or build jobs had run on this head. Things to check (possible problems the decider raised; at this confidence many turn out to be fine):
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Current head |
|
Rebased: main moved in Ops Mission Control rotation/configuration, the cron run contract, and locale catalogs since this head went green ( The approver's PATCH namespace concern is fixed in |
|
Conflict-resolved head |
|
Rebased: main moved in the cron run registry and lifecycle files since this head went green ( The conflict resolution keeps upstream's interrupt alert and this PR's fresh manual-run admission. The newer |
|
Rebased: main moved in the cron trigger and scheduling files since this head went green ( The conflict keeps upstream's status-returning trigger helper and this PR's |
|
Conflict-resolved head |
|
The three re-sync budget is now spent. Main moved another 56 commits and the next conflict is in The 17 fork workflows also still require maintainer approval. |
|
@bolichen97, could you comment exactly |
Problem / Motivation
Goal: A scheduled job runs as the agent you picked -- or skips and says why -- and can use the agents a checkout ships.
A scheduled job names an agent. If that name stopped resolving, the job did not
fail — it ran under the default agent instead, and said nothing. The Schedule
page kept showing the name you picked, so a job could run as the wrong agent for
weeks and look green the whole time.
There was also no way to point a job at a checkout. A repo that ships its own
.kiro/agents/could not lend those agents to a job, so the agent that knows arepo was unreachable from the schedule.
Why it matters
Silent substitution is the worse half. A job that runs the wrong agent produces
plausible output, so nobody looks. The failure is invisible exactly when it
matters most — an unattended job, running while you are not there.
Not a goal
reached by a chat slot only where one is already bound to a directory.
on
kiro-cli, whose project-first lookup the change matches.ships; it does not create, edit or install one.
What changed (motivation → approach → change)
Scheduled message jobs can bind to a Project directory and run with that
checkout as their working directory. The owner-only Schedule form validates the
directory through the shared portability and sensitive-path checks, then loads
its
.kiro/agents/into the agent picker. Non-owner views do not receive thehost path.
The selected custom-agent namespace is stored as
agent_kind="template"oncreate and when an edit explicitly picks a catalog template. PATCH never infers
that marker from a project binding; omitting it preserves the stored namespace.
A same-named Bot cannot replace the template the person selected, while locked
and unchanged configured aliases still resolve normally. Save-time and fire-time
checks reject a missing agent, including every member of an agent sequence,
rather than silently substituting the default.
The edit form keeps its mounted project path as the comparison baseline. A PATCH
that validates a stored project or agent carries that value into the locked
write; concurrent changes return
409 stale_requestinstead of composing anunchecked pair.
Imported project-bound jobs are revalidated on this host and restored paused.
Only the owner Schedule page and CLI can resume or manually run them; an enabled
job continues its ordinary schedule. Messaging commands, MCP cron tools,
CronSDK, app REST enable/run routes, and Ops Mission Control rotation armingrequire the job to remain unbound. Manual-run callers await fresh-store admission
before reporting success. Dedicated refusal types distinguish this policy from
filesystem and store permission errors. Ops reports any partial changes from a
concurrent binding race.
App writers can clear a stale project binding but cannot add one. The cron, App
Kit, Crew Mode, messaging, and Ops Mission Control specifications and App Kit API
reference define these ownership rules. The Schedule form copy is translated in
every shipped locale, including the pseudo locale.
src/kiro_crew/cron.pysrc/kiro_crew/cron_servicesrc/kiro_crew/cron_trigger.pysrc/kiro_crew/portability_vetting.pysrc/kiro_crew/slackwebsite/src/componentswebsite/src/i18nwebsite/src/typesBackwards compatibility
Breaking: Agent- and app-controlled activation of an existing project-bound job
is now refused. Owner actions from the Schedule page and CLI remain allowed.
Writer sweep on upstream/main @
c0760706ddb44fe9bf209eb82a0779fcb154484d:messaging.commands:cron_command_replymarks resume as requiring an unbound job.mcp_cron:_call_tool_innermarks resume and trigger as requiring an unbound job.apps.cron_sdk:CronSDK.set_enabled,set_enabled_async, andrun_job_asyncenforce the same rule for app-owned jobs.
dashboard.handlers.cron_jobs:api_cron_enableanddashboard.handlers.cron_runs:api_cron_runenforce it for app-token REST calls.ops_mission_control.backend.rotation:apply_tiersenforces it while arming arotation and records truthful partial results if an earlier change landed.
Reader:
src/kiro_crew/messaging/commands.py:cron_command_reply-- cron -- unbound resume still works; project-bound resume returns the owner remedy (test_messaging_cannot_resume_a_project_bound_job).Reader:
src/kiro_crew/mcp_cron.py:_call_tool_inner-- cron -- unbound resume/run still works; project-bound activation returns the shared refusal (test_mcp_cron_security_wiring.py).Reader:
src/kiro_crew/apps/cron_sdk.py:CronSDK-- app -- unbound app jobs retain enable/run; project-bound rows are refused and audited (test_cron_sdk.py).Reader:
src/kiro_crew/dashboard/handlers/cron_jobs.py:api_cron_enable-- app -- owner Schedule activation remains allowed while app-token activation is refused (test_r12_cron_owner_gate.py).Reader:
src/kiro_crew/dashboard/handlers/cron_runs.py:api_cron_run-- app -- owner manual run remains allowed while app and agent triggers recheck the synchronized binding (test_cron_trigger.py,test_r12_cron_owner_gate.py).Reader:
src/kiro_crew/apps/builtins/ops_mission_control/backend/rotation.py:apply_tiers-- app -- unbound rotation jobs still arm; project-bound rows stop arming with accurate partial reporting (test_store_and_gate_arming.py).Tests
manual-trigger, and Ops rotation tests cover validation and activation gates.
test_dashboard_cron_project_path.pycovers owner-only path visibility,project catalog selection, client-declared PATCH namespace persistence,
configured-alias preservation, concurrency conflicts, and app restrictions.
test_cron_project_path.pycovers store persistence, same-name templatedispatch, missing-agent failures, and fresh-snapshot manual-run refusals.
test_dashboard_cron_update_agent.pyandtest_cron_update_member_recapture.pykeep existing PATCH contracts on theproduction async lookup seam.
JobForm.projectAgent.test.tsxcovers project-agent loading, explicit templateselection, path changes, stale selection reset, and request ordering.
node IDs fail on clean current main, leaving zero branch-only failures.
chunk-cycle gates passed on the rebased tree.
Manual verification
An isolated-gateway Playwright probe reached the Schedule page with the project
fixture. The final capture could not reuse the probe's one-time startup sign-in,
and the host security policy correctly refused minting another credential. The
preview gateway was stopped cleanly. The form behavior is also covered by the
focused browser tests and production build above.
Screenshots / video
Pending: the obsolete screenshots were removed because they show mechanisms and
copy that are not in this rewrite. A fresh Schedule-form screenshot must be
attached after an interactive dashboard sign-in; no credential or captured
sign-in URL is included in this PR.
Related Issues
Closes #8952
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
I agree to the repository's Apache-2.0 contribution terms.