Skip to content

fix(sidebar): dim folder and New-menu writes while the gateway is offline - #9485

Closed
rnoack1 wants to merge 1 commit into
kirodotdev:mainfrom
rnoack1:fix/gate-rename-while-gateway-offline
Closed

rnoack1 wants to merge 1 commit into
kirodotdev:mainfrom
rnoack1:fix/gate-rename-while-gateway-offline

Conversation

@rnoack1

@rnoack1 rnoack1 commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

This description was rewritten at 9e81502f to match the diff. The previous text
described a session-rename fix that is not in this branch — it was carved out into
#10920 when this PR was split. Both review lanes were right to call that out; see
Scope and provenance below for where each piece went.

Problem / Motivation

With the gateway offline, the sidebar's folder menus and the New-chat caret menu stayed fully live. Every row looked clickable, a double-click on a folder name opened a rename editor, and picking a create row appeared to start a session. None of those writes could reach the gateway, so each gesture was a dead click that gave no reason — while the session rows beside them were already visibly dimmed and refusing.

A folder rename attempted offline was worse than silent: the notice read "Folder update failed", a failure claim for a request that was never sent, and it offered an Ask the agent hand-off into a composer whose Send is itself offline-disabled.

Why it matters

The sidebar taught two different rules on one surface. A user who learned that a dimmed session row means "not now" had no reason to read a full-weight Delete folder as unavailable, so the only way to discover it was to click it and watch nothing happen. Dimming is a promise that the undimmed rows beside it are usable; leaving these ungated made that promise false.

The false "Folder update failed" title is a correctness problem rather than a polish one: it reports a server rejection that did not occur, so a reader cannot distinguish "your change was refused" from "you are offline".

What changed (motivation → approach → change)

The rule, applied uniformly: gate the gateway write at its sink, and leave an affordance that only reaches cached state at full weight.

Entry guards, so no misleading editor opens:

  • folder-name onDoubleClick in both views (list and board/column), refusing with a gateway-offline notice instead of opening the editor
  • the Rename item in both folder ⋯-menus

Sink refusals on the folder-menu writes — Rename, New subfolder, the two ephemeral create rows, Folder settings, Hide when empty, Delete folder — and on all four New-chat caret rows (plain, autopilot, incognito, temporary). Each carries opacity-40 text-muted, offlineProps(...) for the tooltip and accessible name, and onSelect + preventDefault.

One row in those menus stays ungated, and it is a gap rather than a decision: Move to folder. FolderMoveSubmenu.tsx is not in this diff and reads no connection flag at this base, so it renders at full weight beside its dimmed siblings — the precise inconsistency the section above argues against. It is gated in #10911, which owns that file; gating it from here would duplicate a component rather than a one-line primitive. Called out so a reviewer does not read this menu's dimming as complete.

Refusals use onSelect, never onClick. Radix keys menu close on onSelect, so an onClick that returns early suppresses the action but lets the menu close anyway — taking the reason row with it, which reads exactly like the action having happened.

A standing reason row, appended last. A natively disabled row carries data-[disabled]:pointer-events-none, so it fires no event and can never open its own tooltip — an explanation gated on activation cannot reach it by construction. Each gated menu therefore renders one role="status" row from the new OfflineMenuReason. It is appended after the last item because the row mounts when the gateway drops, and anywhere above the items it would shift every row — Delete folder included — under a mid-aim pointer.

The folder refusal no longer lies. A new folderActionOffline flag drops the folder_update_failed title, withholds the Ask the agent hand-off (askAgent={connected}), and retires the notice on the disconnected→connected transition only — so a genuine rejection raised while connected still stays put. All three mutation onError handlers clear the flag, so a real failure never inherits the offline presentation.

Offline verbs are catalogue keys, not English literals. utils.offline.gateway_offline_reconnect is localized but interpolates {{action}}, so passing 'switch sessions' produced a half-English sentence — a ja reader got …switch sessionsするには再接続してください. Eight verbs (change_folder_settings, create_folders, create_sessions, delete_folders, hide_folders, rename_folders, resume_sessions, switch_sessions) are added under utils.offline in 13 catalogues — the 12 locales plus en.manual.json, since utils.offline is a manual namespace and absent from the codemod-generated en.json — following the submit_comments key already there as precedent. Two existing raw literals ('switch sessions', 'resume sessions') are converted to lookups. Each locale supplies the grammatical form its own template demands: a nominalised noun phrase after German für …, a bare infinitive after Spanish para, a sa-hen stem before Japanese するには. The reason row's own string, components.sessionActionsMenu.offline_reason, is added to the 12 locales and to en.json. utils/offline.ts's doc comment is corrected to require a catalogue lookup, since it previously showed a raw English verb as the example.

One restyle: the history row's offline dim moves opacity-50 → opacity-40 so "dimmed" reads as a single state across the sidebar.

Scope and provenance

This is unit 3 of a 6-way split of this PR's original +4224-line change, which was 2.8× the 1500 added-line cap. The split was measured per path against the merge base, not estimated. Where each piece went:

Unit Where it lives
Folder + New-menu gating this PR (+459)
Session rename gate (useRenameSlot, the _title_epoch server guard) #10920
Shared rejected-write notice (utils/actionFailure.ts) #10910
Session menu, tag popover, colour panel, export #10911
Artifacts/Library table #10832
Screenshot capture harness not yet opened — imports symbols absent from main

Sibling sizes are deliberately not quoted here: those PRs have taken review feedback since the split and their counts move independently of this one.

Two ErrorNotice.tsx props here have no consumer in this diff, and that is deliberate. wrapAction has one caller and className on ErrorNoticeMenuItemComponent has none. The file is carried byte-identical from #10920, where both have their consumers, so the two units merge without a conflict. Trimming them here would make one unit of a split diverge from another purely to satisfy a per-unit consumer count. OfflineMenuReason.tsx is carried the same way. First Principles flagged both — the finding is accurate; this is the reason.

Tests

7 new cases in ChatSidebar.folderSettingsOffline.test.tsx, plus updates to five existing suites (ephemeralCreate, createMenu, boardFolderRename, folderEphemeralCreate, and the ChatSidebar integration suite).

What they pin, rather than merely exercise:

  • Dim and suppression, separately. A gated row is asserted aria-disabled and asserted to open no modal and issue no write — dimming without suppression is the exact failure this sweep exists to prevent.
  • The dim is visible, not only semantic. One case asserts the rows read as dimmed rather than being aria-disabled alone, with a connected control in the same file asserting the same row carries no dim — so the gate is proven not to be blanket.
  • Menu survival. A refused row is asserted to leave the menu open, which is what distinguishes onSelect suppression from an onClick early return.
  • The notice's three properties at once: it claims no update failure, offers no hand-off, and retires on reconnect.
  • Fixture discipline. createTestStore() models a disconnected dashboard, so any suite asserting a write reaches the server now seeds connected explicitly rather than inheriting the default. That is what the five existing-suite updates are.

Full frontend suite at this head: 2110 files, 33728 passed, 0 failed, with tsc and ESLint clean and the i18n gate at 19/19 checks pass (run with I18N_BASE_REF supplied — without it four diff-scoped checks silently do not run and a clean result is not coverage).

Manual verification

The offline folder menu was driven by hand in both views and in the New-chat caret menu: rows dim, the reason row renders last, a refused row leaves the menu open, and a folder double-click raises the title-less notice which clears on reconnect.

Known open items, deliberately not fixed in this revision — the push gate returns DENY conflict_rebase_budget_spent (a review request has been churned past for 6.5 days and further shas do not move that), so these are reported rather than patched:

  1. Accessible-name gap. The list-view folder menu's Incognito/Temporary rows call offlineProps(connected, …create_sessions) with no label argument, while their board-view twins pass one — so those two rows announce only "gateway offline" and not "{label} disabled — gateway offline". Raised by the UX lane; verified at ChatSidebar.tsx:6681-6682 against the board twins at :6190-6191. Two-argument fix.
  2. Duplicate class. The history row's offline branch emits text-muted twice (ChatSidebar.tsx:8757), a harmless artefact of the opacity-50→opacity-40 edit.
  3. offlineVerbKeys.test.ts is not in this PR. That repo-wide scan gate fails here on verbs owned by the sibling units (ChatInput.tsx, SessionTabStrip.tsx), so it can only pass once the last of them lands and belongs to that unit. Until then the English-literal rule is enforced by review rather than by CI.

Screenshots / video

One frame here shows this PR's own surface, and it is pinned to this HEAD (9e81502f):

Sidebar folder menu, gateway offline: the write rows are dimmed with the local show/hide toggle left at full weight, and the reason row sits last, below Delete folder

Two surfaces this PR changes have no frame, and I am declaring that rather than implying coverage: the New-chat caret menu offline state, and the folder double-click refusal notice. The UX lane is correct to list both as gaps.

On the evidence mechanism — an unresolved policy question, not an oversight. Nine further frames sit committed under temp-screenshots/offline-rename-gate/. They were captured for the original undivided change, so they show the sibling units' behaviour (session rename, session menu, tag popover, artifacts menu, the rejected-write notice) and this description no longer embeds them as evidence for code that is not here. Committing review media at all deviates from .gitignore:99-105, which says it is uploaded as a GitHub attachment and never committed — and the attach route is mechanically unavailable on this machine: gh is 2.96.0 and --attach arrived in 2.99. The Design and UX lanes BLOCK on attachments specifically, which no edit from here can satisfy. The committed files have been left byte-identical rather than deleted, because removing them would settle that open question by taking the disputed action. A maintainer with gh ≥ 2.99 can attach and drop the files.

The harness that regenerates these frames is unit 6 above, deferred because it imports symbols absent from main. Note that nothing under website/capture/ is type-checked — tsconfig.app.json is include: ["src"] — so a green build does not cover it.

Related Issues

Pattern harvest

Rule candidate: review-prompt
Pattern: a disabled affordance whose explanation is gated on an interaction the disabling itself suppresses

Dimming a control and suppressing its handler is only half a refusal; the half that reaches the user is the reason, and the usual place to put it — a title or tooltip on the row — is unreachable precisely because the row is disabled. data-[disabled]:pointer-events-none on the menu primitive means a natively disabled row fires no event, so no hover, focus or click can ever open its own explanation. The failure is silent and reads as a broken click rather than as an unavailable action.

What would catch the next one: when a review sees a control gated on connectivity, permission or feature flag, ask where the reason renders and what event has to fire for it to appear. If the answer is an event the gate itself suppresses, the explanation has to be standing — rendered as a sibling that does not depend on activation. The generalisation beyond offline gating is any disabled + title pair on a primitive that sets pointer-events-none.

Checklist

  • At most two commits (one here), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality (2110 files, 33728 passed, 0 failed)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (utils/offline.ts's verb contract corrected)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 8, 2026
@dwu96

dwu96 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@rnoack1
rnoack1 marked this pull request as ready for review September 8, 2026 16:07
@rnoack1
rnoack1 requested review from a team and bolichen97 September 8, 2026 16:07
@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — 🟡 CONCERNS

Design-level review of 464c7beaca03195f98338506b9f2972bcab7843b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Description at this head contradicts the diff — Move-to-folder is declared deferred to #10911 yet this revision gates it, and the "known open items" are already fixed.

Watch

The description (rewritten at 9e81502f) is stale for HEAD 464c7be and now asserts the opposite of the code in load-bearing places: it says "FolderMoveSubmenu.tsx is not in this diff and reads no connection flag… It is gated in #10911, which owns that file", while this diff adds offline/offlineTitle to that component and wires it at both call sites; "known open items" 1–2 (missing label args on the list-view Incognito/Temporary rows, duplicate text-muted) are fixed in this diff; the reason-row key is named components.sessionActionsMenu.offline_reason in prose but is utils.offline.menu_reason in code; and the ChatInput.tsx/SessionTabStrip.tsx verb-key conversions land here while the prose attributes those verbs to sibling units. A reviewer or the #10911 author acting on this text will double-gate the submenu or approve believing gaps remain — the in-code justification ("#10911 is CONFLICTING and a day stale, so the dim lands here") is a unilateral ownership takeover recorded only in a comment.
Clears when: the description's "one ungated row", "known open items", and screenshot-gap paragraphs are updated to this head, and #10911 is rebased (or annotated) so exactly one PR owns the FolderMoveSubmenu gate.

[DESIGN-REVIEWED] 464c7be

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of 464c7beaca03195f98338506b9f2972bcab7843b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No blind reader has cold-read the offline dimming, reason row, or refusal notice — comprehension is unverified in this fork lane, capping at CONCERNS.

Watch

  • Every gated control and state is shown (attachments 01–06) but read by no first-time reader; a maintainer wanting the cold read can push the branch to this repository.
  • The description's "One row stays ungated: Move to folder … gated in fix(sidebar): dim session-menu writes while the gateway is offline #10911" is stale — the diff dims it (offline={!connected} on FolderMoveSubmenu, visible dimmed in attachment-01/05). A reviewer acting on the description will mis-review; update that paragraph.
  • The dimmed, aria-disabled "Move folder to" trigger still opens a submenu of full-weight target rows; after the reason row teaches "dimmed actions need a connection", those undimmed targets read as live and the refusal only lands after a pick. Mitigated by the notice naming moving — a human should confirm that reads acceptably in the browser.

[UX-REVIEWED] 464c7be

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 464c7beaca03195f98338506b9f2972bcab7843b via the fork AI-review pipeline; updated in place on each push.

Review details

FINDING -- website/src/components/FolderMoveSubmenu.tsx:32 -- "offline" adds move-folder gating that the stated scope explicitly excludes -> Fix: remove the move-specific guards, prop wiring, and catalog key.
FINDING -- website/src/components/ChatInput.tsx:4839 -- composer send/optimize/continue localization is outside the stated folder/New-menu unit -> Fix: revert these call sites and their catalog keys.
[GPT-REVIEWED] 464c7be

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 464c7beaca03195f98338506b9f2972bcab7843b via the fork AI-review pipeline; updated in place on each push.

Review details

One advisory finding: renameCommit's offline bail leaves the rename editor mounted on the onBlur path, stranding the folder row as an input for the rest of the outage.

FINDING — website/src/pages/ChatSidebar.tsx:7127 — the new if (!connected) { setFolderOfflineNotice(…); return } returns above setEditingId(null), and the same callback is bound as onBlur: () => renameCommit(folder.id, editName) (ChatSidebar.tsx:7779, :8345), so when the gateway drops with an editor open (the scenario this hunk exists for) clicking away re-raises the notice and keeps editingId set — and the editing branch at :8342 renders only glyph + <Input> + count, so that folder's collapse toggle, ⋯ menu and quick-create + are unreachable until reconnect or until the user refocuses the input and presses Escape; an emptied name (!name.trim()), which online just closes the editor, is likewise announced as an offline refusal for a path that sends nothing → Fix: bind the two onBlur props to a handler that calls setEditingId(null) while offline (leaving Enter as the only path that holds the draft), and move the !connected bail below if (name.trim()).

[OPUS-REVIEWED] 464c7be

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — 🟡 CONCERNS

Premise-level review of 464c7beaca03195f98338506b9f2972bcab7843b via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The description states the opposite of the diff: "FolderMoveSubmenu.tsx is not in this diff" and the row "stays ungated" — the diff gates that exact row.

Not justified as shipped

  • Item 6 — undeclared: description says "FolderMoveSubmenu.tsx is not in this diff and reads no connection flag" and calls the ungated row "a gap rather than a decision"; the diff adds offline/offlineTitle to that file and dims the trigger. The gating fits the goal — the framing is what's stale (same rewrite also names components.sessionActionsMenu.offline_reason where the diff ships utils.offline.menu_reason, and describes an ErrorNotice.tsx carry that is not in this diff).
    Subtraction: delete the stale "One row in those menus stays ungated…" and ErrorNotice-carry paragraphs from ## What changed.
    Clears when: the ## What changed section is rewritten to match HEAD 464c7be.
  • Item 7 — undeclared: offline folder collapse now flips only the cached flag and never persists — a persistence-semantics change argued only in a code comment, absent from ## What changed.
    Clears when: the behavior (local-only offline collapse, discarded on reconnect refetch) is stated in the description.
  • Item 8 — rides along: ChatInput.tsx send/optimize/continue tooltips converted to catalogue lookups and the Optimize offline name changed to "Optimize prompt"; the composer is outside the sidebar scope the description declares, though it is the same raw-literal defect the PR names.

What this change ships

Inventory (10 items) — 7 justified

Intent: FIX — stop offline sidebar folder/create controls from taking dead clicks and raising a false "Folder update failed".

  1. Folder ⋯-menu writes (rename, subfolder, creates, settings, hide, delete) dim and refuse offline, menu staying open — justified
  2. All New-chat caret rows and the split button's primary segment dim/refuse offline with a notice — justified
  3. Double-click folder rename refuses offline; an already-open editor keeps its typed draft — justified
  4. A standing "dimmed actions need a connection" status row appended to gated menus — justified
  5. Offline refusals show a neutral status notice, no "Folder update failed", no Ask-agent hand-off, retired on reconnect — justified
  6. Move-to-folder submenu trigger dims offline — undeclared: the description affirmatively says this row stays ungated and its file untouched
  7. Folder collapse/expand works offline via a cached-only flip that never persists — undeclared
  8. Composer send/optimize/continue offline tooltips localized; Optimize offline name now "Optimize prompt" — rides along, outside the declared sidebar scope
  9. Thirteen utils.offline keys added across 13 catalogues, all consumed in-diff — justified
  10. Offline dim unified at opacity-40 across session, history rows — justified

[FIRST-PRINCIPLES-REVIEWED] 464c7be

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 8, 2026
@rnoack1
rnoack1 force-pushed the fix/gate-rename-while-gateway-offline branch from b1006cd to add7f10 Compare September 9, 2026 01:03
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 9, 2026
@rnoack1
rnoack1 force-pushed the fix/gate-rename-while-gateway-offline branch from add7f10 to 219ad8a Compare September 9, 2026 02:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 9, 2026
@rnoack1
rnoack1 force-pushed the fix/gate-rename-while-gateway-offline branch from 219ad8a to 9ff95fb Compare September 9, 2026 04:13
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 9, 2026
@rnoack1
rnoack1 force-pushed the fix/gate-rename-while-gateway-offline branch from 68ca6d2 to f495f27 Compare September 9, 2026 09:13
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 9, 2026
@rnoack1
rnoack1 force-pushed the fix/gate-rename-while-gateway-offline branch from f495f27 to 51d1fcf Compare September 9, 2026 09:41
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 9, 2026
@rnoack1
rnoack1 force-pushed the fix/gate-rename-while-gateway-offline branch from 51d1fcf to 649a5b7 Compare September 9, 2026 11:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 9, 2026
@dwu96

dwu96 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@chenmingwei23

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author.

Assessment: Substantive review lanes (GPT, Opus, Design, First Principles) all pass. Blockers are mechanical: (1) merge conflict against current main — rebase; (2) UX Readiness blocked because the PR description narrates code not in this diff (session-rename fix, tag popover, etc.) and pins screenshots to a stale SHA — rewrite the body to match the actual diff (offline folder/create-menu gating only) and re-attach frames at HEAD; (3) a11y nit: list-view Incognito/Temporary rows call offlineProps without the label arg the column-view twins pass — add it.

If you'd prefer I don't touch this PR, add the pr-no-autofix label.

…line

Items in the folder and New-chat menus now dim, refuse at the sink and carry one
reason row per menu; a folder rename refused offline claims no update failure.

Copy link
Copy Markdown
Contributor

PR triage (2026-10-05): REBASE + merge discussion

Checked against origin/main@a97659dfc3, with this PR's merge base at dceaca3a95 (1070 commits behind):

  • Not superseded. main still has no offline gating on the folder ⋯ menus or the New-chat caret rows. On main, ChatSidebar.tsx calls offlineProps only on the session row and the history row, and nothing under pages/chat-sidebar/ reads connected. OfflineMenuReason, folderActionOffline and the utils.offline.{rename_folders,delete_folders,create_sessions,menu_reason,…} keys are not on main either.

  • Rebase needed. A trial merge (git merge-tree) conflicts in ChatSidebar.tsx, ChatInput.tsx and test/ChatSidebar.createMenu.test.tsx. Since this branch was cut, ChatSidebar.tsx was split into pages/chat-sidebar/* owners (refactor(website): split ChatSidebar into composed chat-sidebar owners #15094), so the folder-menu hunks will need re-homing, not just re-applying.

  • Overlaps with sibling split units (not duplicates, but they will collide):

    Please agree on one owner for the shared primitives (OfflineMenuReason, FolderMoveSubmenu gating, the dropdown-menu offline prop, the shared utils.offline keys) and land them first. Otherwise each unit's catalogue and component edits conflict with the others'. The description also still says FolderMoveSubmenu.tsx "is not in this diff", but it is.

  • No breaking change and no P0 found. The offline prop on DropdownMenuItem is additive. Opus's advisory finding (the renameCommit offline bail on onBlur leaves the editor mounted) is still open; it is UX, not P0.

Recommendation: keep, rebase onto current main, and coordinate the shared primitives with #10911 / #10832.

@iamwhatever

Copy link
Copy Markdown
Contributor

Thank you @rnoack1 for this fix. Main has moved a lot since (ChatSidebar.tsx was split into chat-sidebar owners in #20524), so the change has been carried forward in #20749, which keeps your authorship on the commit, Fixes #20736, and is now green. Closing this one in favour of it; your branch is left in place. #10832 can build on the same offline primitive next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants