Repository navigation
style(agents): template pane drops its panel box for the house header-and-divider style - #9933
Conversation
|
Intent: Align the Agent Template pane (merged in #8307) to the crew editor's shared pane style — no panel box, sticky header row with one divider, standard dropdown trigger, house label/hint scale. Visual only. |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Aligning one foreign-looking pane to the dialog's house style is a real seam, and option D — sticky header, divider, no walls — is the proportionate fix. Suggestions
[DESIGN-REVIEWED] 71de0b1 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of All evidence is reconciled. The blind reader correctly identified the restyled dropdown trigger, the header layout, and the changes popover; the scrolled screenshots confirm the sticky-header fix renders cleanly. The one thing static evidence cannot show is the Built-in↔Customized chip swap whose animation this diff modifies (removing UX-Verdict: CONCERNS Restyle reads cleanly cold — the only hole is no recording of the Built-in→Customized chip swap whose animation this diff changes. Evidence gaps
[UX-REVIEWED] 71de0b1 |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All checks done. The screenshots are convention-mandated ( First-Principles-Verdict: CONCERNS A third repair rides along undeclared: the chip swap loses its Not justified as shipped
What this change shipsInventory (7 items) — 6 justifiedIntent: make the agent-template pane look like the rest of the crew editor dialog — a FIX (visual seam), mostly by deletion.
Label-scale claim verified: WatchThe description says "No behavior changed, so no new tests" and "two repairs ride along," but the diff ships a third: removing [FIRST-PRINCIPLES-REVIEWED] 71de0b1 |
dc65857 to
bc98c50
Compare
self-added: yes
|
self-added: yes
|
|
|
|
|
|
bc98c50 to
176a995
Compare
self-added: yes
On the evidence gap: the publish-name label restyle is the same 11px/tracking-wider label class swap visible on every label in all eight shots; the naming dialog is not among the harness's captured states. |
|
|
|
|
Note on the two red checks (head 176a995):
|
|
Bundle Size Gate root cause (bisected on plain main, no branch code involved):
First breach is #9785; #9787/#9810/#9812 add the rest. Every PR rebased on current main inherits this red. Fix belongs on main: a lazy |
…-and-divider style The Agent Template pane was the only crew-editor pane wrapped in its own bordered panel, with a dashed-underline selector and its own label and hint sizes. Align it to the shared pane vocabulary (option D of the design review): selector row stays a sticky header with one divider under it, standard bordered dropdown trigger, house field labels (11px / tracking-wider) and hints (11.5px / muted). Behavior is unchanged.
176a995 to
71de0b1
Compare
…-and-divider style (kirodotdev#9933) The Agent Template pane was the only crew-editor pane wrapped in its own bordered panel, with a dashed-underline selector and its own label and hint sizes. Align it to the shared pane vocabulary (option D of the design review): selector row stays a sticky header with one divider under it, standard bordered dropdown trigger, house field labels (11px / tracking-wider) and hints (11.5px / muted). Behavior is unchanged.
Problem / Motivation
The Agent Template pane (merged in #8307) is the only pane in the crew editor dialog wrapped in its own bordered panel box. It also uses a dashed-underline template selector and its own label and hint sizes. Every other pane sits directly on the dialog surface with plain field labels. The pane reads as a foreign widget inside its own editor.
Why it matters
The crew editor is one dialog. When one pane draws its own walls and uses its own type scale, users perceive two different products in one screen. Aligning it removes that seam at zero behavior cost.
What changed (motivation → approach → change)
A design review compared four alignment options. Option D won: keep the sticky selector header, drop the panel walls.
The panel border and rounded box are gone; the pane now shares the dialog's own surface. The selector row stays a sticky header, and one divider under it marks where the selection ends and its definition begins. The dashed-underline selector becomes a standard bordered dropdown trigger. Field labels move to the house scale (11px,
tracking-wider) and hints to 11.5px muted. Removing the panel walls exposed two overflow gaps the box used to hide, so two repairs ride along: a::beforecover on the sticky header stops scrolled fields bleeding through the scroll container's top padding, and the changes popover now opens inward (align="end") so it stays inside the dialog. Onlywebsite/src/components/crew/AgentTemplateDetail.tsxchanges, plus the screenshots below.Tests
No behavior changed, so no new tests. The pane's existing 28-test suite (
website/src/test/AgentTemplateDetail.test.tsx) passes unchanged, which locks in that the restyle did not alter structure or behavior.tsc --noEmitis clean.Manual verification
Rendered the pane locally in all three states — built-in template, own customized copy, and the changes popover — at full and scrolled positions. Screenshots below are from that session.
Screenshots / video
Built-in template, header and fields:
Own customized copy with the Customized chip:
Standard dropdown trigger open:
More states (scrolled, popover, own template)
Related Issues
no linked issue: follow-up restyle agreed during the #8307 design review; no tracked issue exists.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)