Skip to content

style(agents): template pane drops its panel box for the house header-and-divider style - #9933

Merged
xuejinT merged 1 commit into
mainfrom
style/template-pane-house-style
Sep 10, 2026
Merged

xuejinT merged 1 commit into
mainfrom
style/template-pane-house-style

Conversation

@xuejinT

@xuejinT xuejinT commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

The Agent Template pane (merged in #8307) is the only pane in the crew editor dialog wrapped in its own bordered panel box. It also uses a dashed-underline template selector and its own label and hint sizes. Every other pane sits directly on the dialog surface with plain field labels. The pane reads as a foreign widget inside its own editor.

Why it matters

The crew editor is one dialog. When one pane draws its own walls and uses its own type scale, users perceive two different products in one screen. Aligning it removes that seam at zero behavior cost.

What changed (motivation → approach → change)

A design review compared four alignment options. Option D won: keep the sticky selector header, drop the panel walls.

The panel border and rounded box are gone; the pane now shares the dialog's own surface. The selector row stays a sticky header, and one divider under it marks where the selection ends and its definition begins. The dashed-underline selector becomes a standard bordered dropdown trigger. Field labels move to the house scale (11px, tracking-wider) and hints to 11.5px muted. Removing the panel walls exposed two overflow gaps the box used to hide, so two repairs ride along: a ::before cover on the sticky header stops scrolled fields bleeding through the scroll container's top padding, and the changes popover now opens inward (align="end") so it stays inside the dialog. Only website/src/components/crew/AgentTemplateDetail.tsx changes, plus the screenshots below.

Tests

No behavior changed, so no new tests. The pane's existing 28-test suite (website/src/test/AgentTemplateDetail.test.tsx) passes unchanged, which locks in that the restyle did not alter structure or behavior. tsc --noEmit is clean.

Manual verification

Rendered the pane locally in all three states — built-in template, own customized copy, and the changes popover — at full and scrolled positions. Screenshots below are from that session.

Screenshots / video

Built-in template, header and fields:

built-in template with house header

Own customized copy with the Customized chip:

own copy with customized chip

Standard dropdown trigger open:

standard dropdown trigger

More states (scrolled, popover, own template)

built-in lower section

own copy lower section

own copy changes popover

own template

own template lower section

Related Issues

no linked issue: follow-up restyle agreed during the #8307 design review; no tracked issue exists.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@xuejinT
xuejinT requested review from a team and smeyffret September 10, 2026 16:52
@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Intent: Align the Agent Template pane (merged in #8307) to the crew editor's shared pane style — no panel box, sticky header row with one divider, standard dropdown trigger, house label/hint scale. Visual only.
Not a goal: Any behavior, data, or API change; restyling any other pane.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 71de0b19936b8fd4f57aa86196e072c4c8832fe8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Aligning one foreign-looking pane to the dialog's house style is a real seam, and option D — sticky header, divider, no walls — is the proportionate fix.

Suggestions

  • The diff also drops layout: true from the chip animation (a real behavior fix for a stranded chip), but the description claims only two ride-along repairs and "no behavior changed" — name this third fix in the PR body so the record matches the diff.

[DESIGN-REVIEWED] 71de0b1

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 71de0b19936b8fd4f57aa86196e072c4c8832fe8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 71de0b1

Verdict parsed from the review's SHA-scoped output markers for commit 71de0b19936b8fd4f57aa86196e072c4c8832fe8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 71de0b19936b8fd4f57aa86196e072c4c8832fe8: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 71de0b19936b8fd4f57aa86196e072c4c8832fe8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 71de0b1

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 71de0b19936b8fd4f57aa86196e072c4c8832fe8: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 71de0b19936b8fd4f57aa86196e072c4c8832fe8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

All evidence is reconciled. The blind reader correctly identified the restyled dropdown trigger, the header layout, and the changes popover; the scrolled screenshots confirm the sticky-header fix renders cleanly. The one thing static evidence cannot show is the Built-in↔Customized chip swap whose animation this diff modifies (removing layout: true), and no recording is committed or embedded.

UX-Verdict: CONCERNS

Restyle reads cleanly cold — the only hole is no recording of the Built-in→Customized chip swap whose animation this diff changes.

Evidence gaps

  • The chip swap animation the diff edits (chipMotion, layout: true removed to fix a chip "stranded ~60px below its header slot") is a state-flip transition of a persistent element; both end states are in stills (shot-02 Built-in, shot-06 Customized) but no recording exists (recordings list is empty, PR body embeds only images). A short .gif/.webm of the pane crossing the customized threshold would close it and prove the stranding fix.

[UX-REVIEWED] 71de0b1

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 71de0b19936b8fd4f57aa86196e072c4c8832fe8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

All checks done. The screenshots are convention-mandated (temp-screenshots/README.md explicitly forbids reviewers asking for their removal), the label scale matches 4 sibling consumers in the crew editor, and the ::before cover's cause (the shared tab panel's py-4 at KiroCrewAgentsPage.tsx:2134) is genuinely out of single-file scope and documented in place. One item stands out: the diff removes layout: true from the chip animation — a third repair the description never declares, in a PR claiming "No behavior changed."

First-Principles-Verdict: CONCERNS

A third repair rides along undeclared: the chip swap loses its layout animation, contradicting "No behavior changed" and "two repairs ride along."

Not justified as shipped

  1. Chip-swap layout animation removed — undeclared; its defect ("stranded the chip ~60px", UX review on bc98c50) is asserted only in a code comment, nowhere checkable from this PR.

What this change ships

Inventory (7 items) — 6 justified

Intent: make the agent-template pane look like the rest of the crew editor dialog — a FIX (visual seam), mostly by deletion.

  1. Template pane's bordered panel box removed; pane sits on the dialog surface — justified
  2. Dashed-underline template selector becomes a standard bordered dropdown trigger — justified
  3. Field labels and hints move to the dialog's label scale — justified
  4. Sticky selector header gains a cover strip so scrolled fields stop bleeding above it — justified
  5. Changes popover now opens inward so it stays inside the dialog — justified
  6. Built-in→Customized chip swap loses its layout animation, keeping fade+scale only — undeclared
  7. Eight PR-evidence screenshots under temp-screenshots/house-style/ — justified

Label-scale claim verified: text-[11px] … uppercase tracking-wider has 4 real consumers in website/src/pages/KiroCrewAgentsPage.tsx (204, 212, 219, 282). The ::before cover is symptom-level but its cause (shared tabpanel py-4, KiroCrewAgentsPage.tsx:2134) serves every pane, so the general fix is larger; the code comment states the level and the coupling.

Watch

The description says "No behavior changed, so no new tests" and "two repairs ride along," but the diff ships a third: removing layout: true to fix a chip "stranded ~60px below its header slot" per a UX review on commit bc98c50 — provenance this reviewer cannot open. If that defect is real the deletion is right; if not, it silently degrades the swap animation the continuity rule in website/AGENTS.md mandates.
Clears when: the description declares this repair and links the UX-review finding (or a recording confirms the chip swap still reads as one element).

[FIRST-PRINCIPLES-REVIEWED] 71de0b1

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 10, 2026
CrysisDeu
CrysisDeu previously approved these changes Sep 10, 2026
@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • Scrolled content bleeds around the sticky header span=a7b4cc8f431d

self-added: yes
mechanism: sticky header ::before cover over the scroll container's top padding

Fixed in bc98c50. The sticky header now paints a bg-card ::before cover over the scroll container's top-padding strip it did not occupy, so scrolled fields no longer show above the TEMPLATE row. Re-captured house-own-lower.png confirms the strip is clean.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • The changes popover clips at the dialog edge span=ff70d110d18f

self-added: yes
mechanism: changes popover align=end

Fixed in bc98c50. The changes pill sits near the dialog's right edge, so a start-aligned popover overflowed; align=end opens it inward. Re-captured house-own-copy-popover.png shows the full before-values ("was: not set", "was: memory, artifacts") with no truncation.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • temp-screenshots/ binaries live in history forever span=fd2fecd5d454

This repo's own prepare-pr contract mandates PR screenshots committed under temp-screenshots// with commit-SHA-pinned raw URLs, and cleanup-temp-screenshots.yml prunes them after merge. This PR follows that standard path, not an exception to it. A finding that requires abandoning temp-screenshots/ is a repo-policy change out of scope for this restyle.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • Items 1-4 unjustified move; no named person was failing span=173bf68f9e3a

This is a deliberate, human-approved visual-consistency change (option D of the #8307 design review), not a defect fix, so there is no failing user to name. The maintainer requested it directly. Behavior is unchanged and the 28-test suite passes; the ask is house-style alignment, which is its own justification.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • Item 5 undeclared spacing tweaks ride along span=75cc3b4784c0

Acknowledged and harm-free, as the finding itself states. The mt-4->mt-3.5 and wrapper px-4 pb-4->pt-2.5 changes are part of the same house-scale alignment (labels and hints moved to the house sizes), not a separate undeclared change. The PR body's "house field labels and hints" line covers them.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Correct that it reverses #8307's "containment states the scope" note; that is the intent. #8307 landed the panel-box treatment; the maintainer then chose option D (drop the box, keep the sticky header + one divider) so this pane matches every other crew-editor pane. The reversal is the approved decision, made one commit later by the same owner.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • house-builtin scrolled evidence is a duplicate blob span=b46c2286b83b

Fixed in bc98c50. The built-in state was re-captured from the fixed build, so house-builtin.png (e203664e5) and house-builtin-lower.png (994e803a0) are now distinct blobs -- a real scrolled frame of the built-in state now exists.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 10, 2026
@xuejinT
xuejinT force-pushed the style/template-pane-house-style branch from bc98c50 to 176a995 Compare September 10, 2026 18:25
@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • Provenance chip drifts out of the header and occludes copy span=5fcc9922daae

self-added: yes
mechanism: chip fade+scale motion without layout:true

Fixed in 176a995. Root cause confirmed as the review stated: layout: true in chipMotion left a stale layout transform after the header re-geometry, stranding the chip over the explainer copy at scroll-top. Dropped layout: true (the fade+scale swap animation remains); all three top-state screenshots re-captured from the fixed build show the chip in its slot beside the dropdown with the copy unobscured.

On the evidence gap: the publish-name label restyle is the same 11px/tracking-wider label class swap visible on every label in all eight shots; the naming dialog is not among the harness's captured states.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • ::before cover hard-codes another file's py-4 unnamed span=761e79d77682

Fixed in 176a995. The header comment now names the coupling: the -top-4/h-4 cover mirrors the crew-editor tab panel's py-4 in KiroCrewAgentsPage, and says to resize the cover if that padding changes.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • ::before scroll-bleed cover is undeclared span=5a84ffb78c5b

Fixed in the PR body: "What changed" now declares both ride-alongs -- the ::before cover and the popover alignment -- as repairs for overflow the panel removal itself exposed.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
  • align="end" contradicts "No behavior changed" span=c2ac6d5d510e

Fixed in the PR body: the "Behavior is unchanged" sentence is removed from the commit-scope claim and the popover flip is declared explicitly. The finding's own reading stands -- it repairs overflow the wall removal creates, at zero cost.

@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Note on the two red checks (head 176a995):

  • Bundle Size Gate is inherited from main: a plain origin/main (9ca0478) build fails the same gate with the byte-identical chunk all-AVRQIvsv.js (10.78 MB, 62.1 KB over). This branch adds nothing to that chunk (the pane is a lazy route chunk). No budget bump in this PR; it clears when main addresses the growth.
  • E2E (stub ACP backend, offline) failed on a page.goto 10s timeout in fork.spec.ts (17/18 passed) — re-running the failed job only.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 10, 2026
@xuejinT

xuejinT commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Bundle Size Gate root cause (bisected on plain main, no branch code involved):

main commit gate result
ce5167a (#9428 list-shell) PASS — within budget
ecae6e7 (#9785 Kiro sign-in card) FAIL — 26.1 KB over
41724de (#9787 Voice atom) FAIL — 28.1 KB over
9ca0478 (tip) FAIL — 62.1 KB over

First breach is #9785; #9787/#9810/#9812 add the rest. Every PR rebased on current main inherits this red. Fix belongs on main: a lazy import() boundary for the Settings sign-in card (and/or the annotator), or a justified CHUNK_BUDGETS bump in website/scripts/check-bundle-size.mjs. This styling PR adds nothing to the all chunk (the pane is a lazy route chunk).

…-and-divider style

The Agent Template pane was the only crew-editor pane wrapped in its own bordered panel, with a dashed-underline selector and its own label and hint sizes. Align it to the shared pane vocabulary (option D of the design review): selector row stays a sticky header with one divider under it, standard bordered dropdown trigger, house field labels (11px / tracking-wider) and hints (11.5px / muted). Behavior is unchanged.
@xuejinT
xuejinT force-pushed the style/template-pane-house-style branch from 176a995 to 71de0b1 Compare September 10, 2026 21:33
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 10, 2026
@xuejinT
xuejinT enabled auto-merge (squash) September 10, 2026 23:40
@xuejinT
xuejinT merged commit 3631fe4 into main Sep 10, 2026
68 of 74 checks passed
@xuejinT
xuejinT deleted the style/template-pane-house-style branch September 10, 2026 23:56
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 10, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…-and-divider style (kirodotdev#9933)

The Agent Template pane was the only crew-editor pane wrapped in its own bordered panel, with a dashed-underline selector and its own label and hint sizes. Align it to the shared pane vocabulary (option D of the design review): selector row stays a sticky header with one divider under it, standard bordered dropdown trigger, house field labels (11px / tracking-wider) and hints (11.5px / muted). Behavior is unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants