Repository navigation
chore: move mood-music to its v0.2.0 commit - #82
Merged
Merged
Conversation
Re-pins mood-music to 12b4c50ea2, the app repository's main after its PR 2 (search fixes) and PR 3 (music buddy and Memory tab). Updates the curator note to describe the app as pinned and to name the core frame-sources PR.
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. |
Opus 5 Review — ✅ no blocking findingsOpus 5 completed its review of This comment is updated in place on each push. |
App Readiness Review — ✅ no blocking findingsEvery app repository this PR adds or re-pins passed the blocking readiness rules at Rules: Review detailsNo findings. mood-music @ 12b4c50ea2fa540f2a6428de5ee37df1c7ce904dNo findings. [APP-READINESS-REVIEWED] 6426e37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-pins
mood-musicfrom1e1a2f81ed(v0.1.0, app PR #1) to12b4c50ea2fa540f2a6428de5ee37df1c7ce904d(v0.2.0), the currentmainofiamwhatever/kirocrew-app-mood-music.
Clicking Sync installs the pinned ref, so until this lands users keep getting v0.1.0.
The entry's
noteis updated where it was wrong: the app now has a buddy chat and aMemory tab, its backend now calls two lookup APIs, it now declares
sessionApproval,and the frame-sources seam is kirodotdev/KiroCrew#37157
(merged 2026-11-16 00:17 UTC; in no tagged release yet, latest is v0.13.0-rc.1).
No other entry is touched.
What changed in the app between the two refs
aabb643), search fixes: the DJ agent spec gainsallowedTools: [web_search, web_fetch](and drops its ignored
skillskey) so its own two tools run without an approval stall;when a prompt is still pending, the page says where to answer it; the page reads the
agent's reply even when it renames fields.
12b4c50), music buddy: explore-first picks (anchor / explore / deep,each explore pick cites a page as evidence), a buddy chat on the page with Allow once /
Deny buttons for a pending tool prompt (this is what adds
sessionApproval), and a Memorytab to view, edit, pin and forget what the app remembers. New backend routes
(all owner-only):
POST /verify-picks,POST /memory,PUT /memory/{id},DELETE /memory/{id},POST /memory/clear-stale,POST /memory/used,PUT /settings.New
backend/verify.pyre-checks each pick against two fixed URLs only:https://www.youtube.com/oembed?...andhttps://api.bilibili.com/x/web-interface/view?...(no redirects, no cookies, capped body, 6 s deadline).
Permission and tool differences (
app.json,agents/dj.json), complete1e1a2f8)12b4c50)version0.1.00.2.0permissions.sessionApprovaltrue(new, PR #3)permissions.api/api/apps/mood-music,/api/apps/mood-music/*,/api/chat,/api/chat/*permissions.storage/networktrue/trueui.frameSourceshttps://www.youtube-nocookie.comtoolsweb_search,web_fetchallowedToolsweb_search,web_fetch(new, PR #2)skillskey["mood-music"]skillsstill listsskills/mood-music)crons,setuphooks,mcpServersNotes on the two new grants:
sessionApprovallets the app send messages to, answer tool prompts on, and setNormal/Reads/Trust approval mode for the owner's local sessions (per
docs/app-kit/manifest-reference.md). The app's code uses it for one call:POST /api/chat/slots/{its own slot}/approvefrom its page's Allow once / Denybuttons (
ui/src/api.ts), and never asks for Trust. Per the core docs, an update thatnewly adds this flag leaves the app disabled until the owner consents again on its
detail page, so users syncing to v0.2.0 will see that prompt.
allowedToolsauto-approves only the agent's ownweb_search/web_fetch.Verified
git rev-parse origin/main=12b4c50ea2fa540f2a6428de5ee37df1c7ce904d;read
app.jsonat both refs and diffedapp.json,agents/dj.jsonandbackend/.12b4c50:ui/dist/index.mjs,skills/mood-music/SKILL.md,backend/routes.py,assets/icon.png,assets/hero-*.pngexist (R1);permissionsis an object andskillsentries are strings (R2).python tools/validate.py: OK (3 pre-existing warnings on other apps).python tools/format.py --check: normalized.pytest tests/ -q: 521 passed, 1 failed on the first run(
test_publish_fails_closed_without_a_key); it passed on rerun both on this branch andon untouched
main, so it is a local flake unrelated to this data-only change.