Skip to content

chore: move mood-music to its v0.2.0 commit - #82

Merged
iamwhatever merged 1 commit into
mainfrom
chore/mood-music-0.2.0
Nov 16, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
chore/mood-music-0.2.0

Conversation

@iamwhatever

Copy link
Copy Markdown
Collaborator

What

Re-pins mood-music from 1e1a2f81ed (v0.1.0, app PR #1) to
12b4c50ea2fa540f2a6428de5ee37df1c7ce904d (v0.2.0), the current main of
iamwhatever/kirocrew-app-mood-music.
Clicking Sync installs the pinned ref, so until this lands users keep getting v0.1.0.

The entry's note is updated where it was wrong: the app now has a buddy chat and a
Memory tab, its backend now calls two lookup APIs, it now declares sessionApproval,
and the frame-sources seam is kirodotdev/KiroCrew#37157
(merged 2026-11-16 00:17 UTC; in no tagged release yet, latest is v0.13.0-rc.1).
No other entry is touched.

What changed in the app between the two refs

  • App PR feat(dist): Add the S3 publish lane and apps.crew.kiro.dev layout #2 (aabb643), search fixes: the DJ agent spec gains allowedTools: [web_search, web_fetch]
    (and drops its ignored skills key) so its own two tools run without an approval stall;
    when a prompt is still pending, the page says where to answer it; the page reads the
    agent's reply even when it renames fields.
  • App PR Sign the registry with a KMS key instead of a PEM secret #3 (12b4c50), music buddy: explore-first picks (anchor / explore / deep,
    each explore pick cites a page as evidence), a buddy chat on the page with Allow once /
    Deny buttons for a pending tool prompt (this is what adds sessionApproval), and a Memory
    tab to view, edit, pin and forget what the app remembers. New backend routes
    (all owner-only): POST /verify-picks, POST /memory, PUT /memory/{id},
    DELETE /memory/{id}, POST /memory/clear-stale, POST /memory/used, PUT /settings.
    New backend/verify.py re-checks each pick against two fixed URLs only:
    https://www.youtube.com/oembed?... and https://api.bilibili.com/x/web-interface/view?...
    (no redirects, no cookies, capped body, 6 s deadline).

Permission and tool differences (app.json, agents/dj.json), complete

Field v0.1.0 (1e1a2f8) v0.2.0 (12b4c50)
version 0.1.0 0.2.0
permissions.sessionApproval absent true (new, PR #3)
permissions.api /api/apps/mood-music, /api/apps/mood-music/*, /api/chat, /api/chat/* unchanged
permissions.storage / network true / true unchanged
ui.frameSources https://www.youtube-nocookie.com unchanged
agent tools web_search, web_fetch unchanged
agent allowedTools absent web_search, web_fetch (new, PR #2)
agent skills key ["mood-music"] removed (the manifest's top-level skills still lists skills/mood-music)
crons, setup hooks, mcpServers none none

Notes on the two new grants:

  • sessionApproval lets the app send messages to, answer tool prompts on, and set
    Normal/Reads/Trust approval mode for the owner's local sessions (per
    docs/app-kit/manifest-reference.md). The app's code uses it for one call:
    POST /api/chat/slots/{its own slot}/approve from its page's Allow once / Deny
    buttons (ui/src/api.ts), and never asks for Trust. Per the core docs, an update that
    newly adds this flag leaves the app disabled until the owner consents again on its
    detail page, so users syncing to v0.2.0 will see that prompt.
  • allowedTools auto-approves only the agent's own web_search / web_fetch.

Verified

  • Cloned the app repo, git rev-parse origin/main = 12b4c50ea2fa540f2a6428de5ee37df1c7ce904d;
    read app.json at both refs and diffed app.json, agents/dj.json and backend/.
  • At 12b4c50: ui/dist/index.mjs, skills/mood-music/SKILL.md, backend/routes.py,
    assets/icon.png, assets/hero-*.png exist (R1); permissions is an object and
    skills entries are strings (R2).
  • python tools/validate.py: OK (3 pre-existing warnings on other apps).
  • python tools/format.py --check: normalized.
  • pytest tests/ -q: 521 passed, 1 failed on the first run
    (test_publish_fails_closed_without_a_key); it passed on rerun both on this branch and
    on untouched main, so it is a local flake unrelated to this data-only change.

Re-pins mood-music to 12b4c50ea2, the app repository's main after its PR 2 (search fixes) and PR 3 (music buddy and Memory tab). Updates the curator note to describe the app as pinned and to name the core frame-sources PR.
@github-actions

Copy link
Copy Markdown

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 6426e37e2f0521be98630a29b91ae55d4d0be7fd and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6426e37

@github-actions

Copy link
Copy Markdown

Opus 5 Review — ✅ no blocking findings

Opus 5 completed its review of 6426e37e2f0521be98630a29b91ae55d4d0be7fd and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6426e37

@github-actions

Copy link
Copy Markdown

App Readiness Review — ✅ no blocking findings

Every app repository this PR adds or re-pins passed the blocking readiness rules at 6426e37e2f0521be98630a29b91ae55d4d0be7fd.

Rules: review/app-readiness-rules.md (base-branch snapshot). This comment is updated in place on each push.

Review details

No findings.

mood-music @ 12b4c50ea2fa540f2a6428de5ee37df1c7ce904d

No findings.

[APP-READINESS-REVIEWED] 6426e37

@iamwhatever
iamwhatever merged commit 50d8fd3 into main Nov 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant