Skip to content

feat: list code-review-sage from its own repository - #87

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
feat/pin-code-review-sage
Nov 17, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
feat/pin-code-review-sage

Conversation

@bolichen97

Copy link
Copy Markdown
Collaborator

What

Flips code-review-sage in catalog/official-registry.json from a builtin source to a git source in its own KiroCrewCaptain repository, pinned at the commit Kiro Crew's adoption pin table names for it in kirodotdev/KiroCrew#38478:

App Repository ref Version
code-review-sage https://github.com/KiroCrewCaptain/kirocrew-app-code-review-sage 711261d196f5ea4fa8027bbaa0e4991b11f3d402 0.9.5

The row gets the same note the other adopted apps carry, naming Kiro Crew 0.14.0, and its Kiro Crew org author gains the https://github.com/KiroCrewCaptain URL. No other row changes.

The commit is the head of the repository's main, with green CI on ubuntu, macOS and Windows plus the reproducible-bundle, README and internal-content jobs. Its manifest declares permissions.chatLaunch (the follow-up chat its review panel opens, App Kit level 10, kirodotdev/KiroCrew#37492), exactly as the wheel copy does; a Kiro Crew without that seam ignores the key and the panel only continues follow-ups that already exist.

Merge condition: right after the Kiro Crew pin PR

The Kiro Crew PR is kirodotdev/KiroCrew#38478. It adds the pin row and moves the wheel version. This PR is not set to auto-merge: the driver merges it once kirodotdev/KiroCrew#38478 has landed.

  • This PR merged first: no Kiro Crew build pins code-review-sage yet, so a host that has the built-in is not moved, and the catalog entry and that host's install disagree until the pin lands.
  • The Kiro Crew PR merged first: a nightly host adopts at this commit while the published catalog still lists code-review-sage as builtin, which gives an adopted record no install source for an update or a reinstall until this one lands.

Verification

  • tools/format.py: already normalized.
  • tools/validate.py: OK. The 3 warnings were already there, on other apps.
  • pytest tests/: 522 passed (with the jsonschema[format] validators installed, so the date-time and uri checks are active).
  • Kiro Crew's scripts/adoption_pin.py compute at this commit with --min-sdk-level 10 prints the pin PR's row byte for byte, and on the pin PR's tree the code-review-sage row measures ok over the network.
  • The pin PR's upgrade smoke ran update and reinstall of the adopted app against the published catalog with only this row changed: both reached the pinned commit and kept the app's data.

Flip code-review-sage from a builtin source to a git source in its own
KiroCrewCaptain repository, pinned at the commit Kiro Crew's adoption
pin table names for it in kirodotdev/KiroCrew#38478, with the note the
other adopted apps carry and the org author URL.
@github-actions

Copy link
Copy Markdown

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of a00f026b762f310fc509e873154356038a4d07d4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a00f026

@github-actions

Copy link
Copy Markdown

Opus 5 Review — ✅ no blocking findings

Opus 5 completed its review of a00f026b762f310fc509e873154356038a4d07d4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a00f026

@github-actions

Copy link
Copy Markdown

App Readiness Review — ✅ no blocking findings

Every app repository this PR adds or re-pins passed the blocking readiness rules at a00f026b762f310fc509e873154356038a4d07d4.

Rules: review/app-readiness-rules.md (base-branch snapshot). This comment is updated in place on each push.

Review details

I verified each rule against the checkout.

No findings.

code-review-sage @ 711261d196f5ea4fa8027bbaa0e4991b11f3d402

No findings.

[APP-READINESS-REVIEWED] a00f026

@KiroCrewCaptain
KiroCrewCaptain merged commit f25ce5b into main Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants