Repository navigation
feat: list crew-companion from its own repository - #91
Merged
Merged
Conversation
Switch crew-companion from a builtin source to a git source in KiroCrewCaptain/kirocrew-app-crew-companion at the commit Kiro Crew's adoption pin table names for it (kirodotdev/KiroCrew#39004). Lands right after that pin PR.
5 tasks done
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. |
App Readiness Review — ✅ no blocking findingsEvery app repository this PR adds or re-pins passed the blocking readiness rules at Rules: Review detailsNo findings. crew-companion @ 2eb2e98469149ea740d7f82b6df701dbf872c9a3No findings. [APP-READINESS-REVIEWED] 99ad597 |
Opus 5 Review — ✅ no blocking findingsOpus 5 completed its review of This comment is updated in place on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flips crew-companion in
catalog/official-registry.jsonfrom abuiltinsource to agitsource in its ownKiroCrewCaptainrepository, pinned at the commit Kiro Crew's adoption pin table names for it in kirodotdev/KiroCrew#39004:ref2eb2e98469149ea740d7f82b6df701dbf872c9a3The row gets the same
notethe other adopted apps carry, naming Kiro Crew 0.14.0, and itsKiro Creworg author gains thehttps://github.com/KiroCrewCaptainURL. No other row changes.The commit is the head of the repository's
main, with green CI on ubuntu, macOS and Windows plus the reproducible-bundle, README and internal-content jobs. Its manifest declares the same permissions as the built-in it replaces, and adesktopblock with the four windows the built-in's desktop shell code drew (the avatar on every display, a background notification window, the panel and the gallery), which the desktop app's window host serves (App Kit level 7).Merge condition: right after the Kiro Crew pin PR
The Kiro Crew PR is kirodotdev/KiroCrew#39004. It adds the pin row and moves the wheel version. This PR is not set to auto-merge: the driver merges it once kirodotdev/KiroCrew#39004 has landed.
builtin, which gives an adopted record no install source for an update or a reinstall until this one lands.Verification
tools/format.py: already normalized.tools/validate.py: OK. The 3 warnings were already there, on other apps.pytest tests/: 522 passed (with thejsonschema[format]validators installed, so thedate-timeandurichecks are active).scripts/adoption_pin.py computeat this commit with--min-sdk-level 7prints the pin PR's row byte for byte, and on the pin PR's tree every row, this one included, measuresokover the network.