Repository navigation
chore(catalog): re-pin mood-music to v0.2.5 - #93
Merged
Merged
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. |
Opus 5 Review — ✅ no blocking findingsOpus 5 completed its review of This comment is updated in place on each push. |
App Readiness Review — ✅ no blocking findingsEvery app repository this PR adds or re-pins passed the blocking readiness rules at Rules: Review detailsNo findings. mood-music @ 25f879978b373377657b38f9901c3efc0b2ed9f0No findings. [APP-READINESS-REVIEWED] e6602bb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-pins
mood-musicfromeb312ed2ca43ec90799484b96b70178b72ad9497(v0.2.4, catalog PR #90) to25f879978b373377657b38f9901c3efc0b2ed9f0(v0.2.5), the merge commit ofapp PR #9 and the current
mainofiamwhatever/kirocrew-app-mood-music.
Clicking Sync installs the pinned ref, so until this lands users keep getting v0.2.4.
The entry's
notedrops "YouTube in page, bilibili in tab" and says songs play in the Crewbrowser. It is 286 characters. No other entry is touched. The registry has no separate version
field; the version comes from the app's
app.jsonat the pinned ref.Still needs Kiro Crew with kirodotdev/KiroCrew#38333
v0.2.5 keeps
permissions.browserSites,permissions.mcpTools: ["browser"]and the/api/browser/mediaroute fromkirodotdev/KiroCrew#38333. A Kiro Crew build
without that PR does not know these fields. v0.2.5 now says so on the page ("update Kiro Crew")
instead of falling back to another player.
What changed in the app (v0.2.4 -> v0.2.5, app PR #9)
and the bilibili "open in a new tab" link are removed, and so is the player choice in settings
(
PUT /settingsno longer takesplayer).source); with no link, the buddy findsthe song by searching that site in the Crew browser when it plays. A link that is sent is still
checked in
backend/links.pyas before.the app page, or the browser turned off by policy.
Permission and tool differences vs v0.2.4 (
app.json,agents/dj.json)Read from both refs with
git show <ref>:app.json/git show <ref>:agents/dj.json.eb312ed)25f8799)version0.2.40.2.5ui.frameSourceshttps://www.youtube-nocookie.compermissions.api/api/browser/mediapermissions.mcpTools["browser"]permissions.browserSiteshttps://search.bilibili.com/all,https://www.bilibili.com/video/BV*,https://www.youtube.com/results,https://www.youtube.com/watchpermissionssessionApproval,hiddenSessions,storage,networktruetoolsweb_search,web_fetch,@kirocrew-core/browserallowedToolsweb_search,web_fetchmodel,mcpServers{}crons,setuphooks,mcpServersSo v0.2.5 removes one capability (the YouTube frame source) and adds none. In
agents/dj.jsononly
descriptionandprompttext change, to drop the other players.The browser is still the user's own: on macOS, Kiro Crew's browser drives the user's own Chrome
with their sign-ins. The hard limit is the four
browserSitespatterns enforced by Kiro Crew,which the user approves once on the app's page.
Verified
gh pr view 9 -R iamwhatever/kirocrew-app-mood-music: MERGED at 2026-11-18T16:51:20Z, mergecommit
25f879978b373377657b38f9901c3efc0b2ed9f0.git rev-parse origin/mainin the app repois the same commit;
app.jsonthere says"version": "0.2.5".25f8799: UI (typecheck, test, reproducible bundle), Tests (ubuntu / macos /windows, Python 3.12), README standard: all success.
25f8799:ui/dist/index.mjs,skills/mood-music/SKILL.md,backend/routes.py,agents/dj.json,assets/icon.png,assets/hero-light.png,assets/hero-dark.png,assets/screenshot-main.pngexist.python tools/validate.py: OK (3 pre-existing warnings on other apps).python tools/format.py --check: all 3 files normalized.pytest tests/ -q: 522 passed.