Repository navigation
chore(catalog): re-pin mood-music to v0.2.6 - #94
Merged
Merged
Conversation
Opus 5 Review — ✅ no blocking findingsOpus 5 completed its review of This comment is updated in place on each push. |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. |
App Readiness Review — ✅ no blocking findingsEvery app repository this PR adds or re-pins passed the blocking readiness rules at Rules: Review detailsNo findings. mood-music @ 3b01f06f37c37e0cfd14687ce315bb9bf0d8ca3fNo findings. [APP-READINESS-REVIEWED] 4fb52e1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-pins
mood-musicfrom25f879978b373377657b38f9901c3efc0b2ed9f0(v0.2.5, catalog PR #93) to3b01f06f37c37e0cfd14687ce315bb9bf0d8ca3f(v0.2.6), the merge commit ofapp PR #10 and the current
mainofiamwhatever/kirocrew-app-mood-music.
Clicking Sync installs the pinned ref, so until this lands users keep getting v0.2.5.
The entry's
notenow says the page shows the buddy's browser, that the buddy chat is hidden andnow kept in Crew memory, lists the new grants (
chatSlots,browser:view), and namesKiroCrew#39018. It is 300 characters (the schema maximum). No other entry is touched. The registry
has no separate version field; the version comes from the app's
app.jsonat the pinned ref.Needs Kiro Crew with kirodotdev/KiroCrew#39018
v0.2.6 uses three Kiro Crew changes, all merged to
main:ctx.chat_slots.open(state, key, hidden=True), the hidden chat the backend opens itself.BrowserView.906ee87027):permissions.browser, the "view" grant and the live view for an app's own slot. It is the newest of the three, so a Kiro Crew build that has it has all three.The view also needs App browser access on in Settings > Developer > Feature previews, then
"view" approved on the app's page. On an older Kiro Crew the page says to update Kiro Crew: the
buddy's chat answers
old_host, and the browser box says it cannot show the browser here yet.What changed in the app (v0.2.5 -> v0.2.6, app PR #10)
BrowserViewfor the buddy's chat, so the person can watch the buddy search and open a song, and take the tab over. The page never reads frames; the picture is Kiro Crew's.ctx.chat_slots(backend/buddy.py,POST /buddy,POST /buddy/send), hidden from the session lists. Before, the page opened it withPOST /api/chat/slots.memory_mode: 'temporary';ctx.chat_slots.opentakes no memory mode, so the chat is a normal one and what is said there can go into lasting memory. The app's own taste store (Memory tab) is unchanged.Permission and tool differences vs v0.2.5 (
app.json,agents/dj.json)Read from both refs with
git diff 25f8799 3b01f06 -- app.json agents/dj.json.25f8799)3b01f06)version0.2.50.2.6permissions.chatSlotstrue(new)permissions.browser["view"](new: the page may show the buddy's browser)permissions.hiddenSessionstruepermissionssessionApproval,storage,networktruepermissions.api/api/browser/mediapermissions.mcpTools["browser"]permissions.browserSitesconfigurationagents/dj.jsoncrons,setuphooks,mcpServersSo v0.2.6 adds two grants (
chatSlots,browser: ["view"]) and removes none. "view" lets thepage show the browser picture of the app's own chat only; it gives no new browser verbs to the
agent, and the four
browserSitespatterns are still the hard limit.Screenshots
Taken with the app's own
capture/capture.pyfrom an isolated gateway (loopback only, throwawayhome, stub model) on Kiro Crew
mainat906ee87027(includes #39018), with app3b01f06installed from a clone. App browser access is on, and
browserSitesplusbrowser: ["view"]were approved through the enable call. The queue is seeded through the app's own
POST /queue.The "Kiro Crew's browser" box (top right) is the real host
BrowserViewwith access granted. Itshows "No page is open in this chat yet." because no model turn ran: the stub model does not
drive the browser, so there is no live page to show. A shot of a live page needs a signed-in model
turn driving a set-up browser, which this capture did not run. These are not mock-ups.
The images are on the
pr-assets/catalog-0.2.6branch of the app repo. It is not for merge andcan be deleted after review.
Verified
gh pr view 10 -R iamwhatever/kirocrew-app-mood-music: MERGED at 2026-11-18T22:06:31Z, mergecommit
3b01f06f37c37e0cfd14687ce315bb9bf0d8ca3f.git rev-parse origin/mainin the app repo isthe same commit;
app.jsonthere says"version": "0.2.6".3b01f06: success.gh pr view 39018 -R kirodotdev/KiroCrew: MERGED 2026-11-19T16:54:53Z,906ee870275f. #39246 and #39020 MERGED.python tools/validate.py: OK (3 pre-existing warnings on other apps).python tools/format.py --check: all 3 files normalized.pytest tests/ -q: 522 passed.