Repository navigation
CI: add a sanitizer build job (ASan, UBSan, LSan) and fix IMAP parser leaks - #364
Merged
Merged
Conversation
Build the library and tests with -fsanitize=address,undefined, and make UndefinedBehaviorSanitizer errors fatal, so that memory errors, leaks and undefined behaviour reached by the test suite fail the build. Leaks in third-party libraries are suppressed in tests/lsan.supp.
IMAPParser::get() allocated the component, and only freed it if parsing returned false. If parsing threw instead (eg. when reading a literal from the socket failed), the component and all the partially parsed components above it were leaked. Hold it in a std::unique_ptr until parsing succeeds. Also fix the IMAPParser tests which did not free the parsed responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.