Skip to content

fix: allow InCallService to detect outgoing calls in dialing state - #157

Closed
mvanhorn wants to merge 1 commit into
kitsumed:mainfrom
mvanhorn:fix/153-incallservice-ivr-dialing-detection
Closed

mvanhorn wants to merge 1 commit into
kitsumed:mainfrom
mvanhorn:fix/153-incallservice-ivr-dialing-detection

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

Motivation

It addresses the behavior reported in issue #153.

What changed

fix: allow InCallService to detect outgoing calls in dialing state

Validation

The local test run for the ShizuCallRecorder AppPreferences change to app/src/main/java/com/kitsumed/shizucallrecorder/data/AppPreferences.kt, app/src/main/java/com/kitsumed/shizucallrecorder/services/callDetection/incall/InCallService.kt and app/src/main/java/com/kitsumed/shizucallrecorder/ui/screens/SettingsScreen.kt and the other changed files could not complete in this environment.

Fixes #153

AI was used for assistance.

@kitsumed

Copy link
Copy Markdown
Owner

I'm not really a fan of this as I told in the issue itself, and we have a workaround that will come in next release via notification based detection.

That said, if you find a reliable way to detect that the call is connected/ongoing while in a dialing state, I am open to improving the InCallService detection, but for this current PR I'm really not a fan since it add more toggle for a very unique issue and change the InCallService behavior in a way that make it unstable/prone to false positive once the toggle is enabled. Since we have another solution coming soon, I don't really see the need of having it that way.

I guess a part of the issue is also how our AppPreference saving currently is done, in the next rework, if I ever get to it, I plan on making settings per modes and kind of have them connected in some ways. Unsure of how yet since I'm not there yet. Basically each detection mode would have child-settings directly connected, some modes could share some settings, at least that's how I see it.

@kitsumed kitsumed closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Carrier Outgoing calls to to IVR systems are not detected when using InCallService

2 participants