Skip to content

fix(ring): forward alloc and std to rind-ring - #4

Merged
kixelated merged 1 commit into
mainfrom
ring-forward-features
Nov 15, 2026
Merged

kixelated merged 1 commit into
mainfrom
ring-forward-features

Conversation

@kixelated

@kixelated kixelated commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The ring shim now forwards alloc and std to rind-ring and takes rind-ring without its defaults, so each feature a dependency asks of ring reaches rind-ring.

kixel-ai/rind#783 makes rind-ring gate RSA on alloc and impl std::error::Error for error::Unspecified and error::KeyRejected on std, matching ring 0.17. Today the shim depends on rind-ring with its defaults (alloc, no std) and its own std changes nothing, so once that rind-ring ships, a patched tree where some crate needs ring/std for those impls would stop compiling. This lands first: the rind-ring already on crates.io declares both features as no-ops, so forwarding changes nothing until the gating release.

Public API

None for the shim. With the next rind-ring release, the shim's alloc and std features start doing what ring's do.

Validation

  • cargo fmt --all --check; cargo clippy --workspace --all-features -- --deny warnings; cargo clippy --workspace --no-default-features with rind-ring patched to the rind#783 checkout.
  • cargo tree -e features -i rind-ring --features std shows rind-ring feature "std" through the shim's std; with --no-default-features, rind-ring gets no features.
  • rind's sh/patch.sh (quinn-proto, rustls, and rcgen on ring through this shim) passes with rind#783's rind-ring.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Summary by CodeRabbit

  • Refactor
    • Updated how optional allocation and standard-library support are configured for the cryptography component. Default feature behavior remains unchanged.

rind-ring is gating RSA on `alloc` and the errors' `std::error::Error`
impls on `std`, as ring does. The shim took rind-ring's defaults and
dropped both features, so a dependency asking ring for `std` would lose
those impls once that rind-ring ships. Forwarding works with the rind-ring
already published, which declares both features.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The ring shim now forwards its alloc and std features to rind-ring. The dependency disables default features. The default features of the shim remain unchanged.

Changes: Feature forwarding

Layer / File(s) Summary
Feature forwarding and dependency configuration
ring/Cargo.toml
The alloc and std features now forward to rind-ring. The rind-ring dependency disables default features. The shim’s default features remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to d5c62

The ring shim now forwards its alloc and std features to rind-ring and no longer inherits rind-ring's default features. No public API change is intended, and no merge-blocking risk was found.

Architecture risk: Low · up to d5c62

The change affects 1 system.

Changed systems: ring

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — ring (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in ring/Cargo.toml: The feature declaration now forwards alloc to rind-ring/alloc and std to rind-ring/std; the other feature values and defaults remain unchanged. The comments now state that these features enable RSA and std::error::Error support in rind-ring, while the remaining features have no effect.
  • observed — Modified behavior in ring/Cargo.toml: The rind-ring dependency now sets default-features = false; previously it used the dependency’s default feature selection.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: the ring shim now forwards the alloc and std features to rind-ring. The raw summary and PR objectives both describe this as the main change, so the title matches the change…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the ring shim now forwards the alloc and std features to rind-ring. The raw summary and PR objectives both describe this as the main change, so the title matches the changeset. The title uses the conventional fix(ring): prefix and stays under one line.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 1
  • Waived: $0.25 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2dd10905-87f9-4134-8723-22dfdbb12971
Commits

Reviewing files that changed from the base of the PR and between 432febf and d5c6261.

Files selected for processing: 1

  • ring/Cargo.toml

Limit details: You’ve used all 10 included reviews currently available.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the single-file diff to ring/Cargo.toml.

  • Feature forwarding: alloc now enables rind-ring/alloc, and std enables alloc plus rind-ring/std.
  • Dependency defaults: rind-ring is taken with default-features = false. The shim's own default = ["alloc", ...] still turns on rind-ring/alloc, so default builds are unchanged.
  • Comment: Updated to say which features reach rind-ring.

I couldn't check from here that the published rind-ring 0.17 declares alloc and std as no-op features, as the PR description says. If it doesn't, resolution would fail, so that's worth confirming before merge.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated merged commit 38cf22a into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant