Repository navigation
fix(ring): forward alloc and std to rind-ring - #4
Conversation
rind-ring is gating RSA on `alloc` and the errors' `std::error::Error` impls on `std`, as ring does. The shim took rind-ring's defaults and dropped both features, so a dependency asking ring for `std` would lose those impls once that rind-ring ships. Forwarding works with the rind-ring already published, which declares both features. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the single-file diff to ring/Cargo.toml.
- Feature forwarding:
allocnow enablesrind-ring/alloc, andstdenablesallocplusrind-ring/std. - Dependency defaults:
rind-ringis taken withdefault-features = false. The shim's owndefault = ["alloc", ...]still turns onrind-ring/alloc, so default builds are unchanged. - Comment: Updated to say which features reach
rind-ring.
I couldn't check from here that the published rind-ring 0.17 declares alloc and std as no-op features, as the PR description says. If it doesn't, resolution would fail, so that's worth confirming before merge.
claude-sonnet-5-5 | 𝕏

Summary
The
ringshim now forwardsallocandstdto rind-ring and takes rind-ring without its defaults, so each feature a dependency asks of ring reaches rind-ring.kixel-ai/rind#783 makes rind-ring gate RSA on
allocandimpl std::error::Errorforerror::Unspecifiedanderror::KeyRejectedonstd, matching ring 0.17. Today the shim depends on rind-ring with its defaults (alloc, nostd) and its ownstdchanges nothing, so once that rind-ring ships, a patched tree where some crate needsring/stdfor those impls would stop compiling. This lands first: the rind-ring already on crates.io declares both features as no-ops, so forwarding changes nothing until the gating release.Public API
None for the shim. With the next rind-ring release, the shim's
allocandstdfeatures start doing what ring's do.Validation
cargo fmt --all --check;cargo clippy --workspace --all-features -- --deny warnings;cargo clippy --workspace --no-default-featureswith rind-ring patched to the rind#783 checkout.cargo tree -e features -i rind-ring --features stdshowsrind-ring feature "std"through the shim'sstd; with--no-default-features, rind-ring gets no features.sh/patch.sh(quinn-proto, rustls, and rcgen on ring through this shim) passes with rind#783's rind-ring.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Summary by CodeRabbit