Repository navigation
chore(quest): matches TypeScript has already narrowed - #109
Conversation
From #100's report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: a482da4
No actionable bugs found in this documentation-only quest. It accurately separates test-induced narrowing from #100's construction-time widening, and requiring both native-Rust differential tests and TypeScript checking is the right direction.
Implementation guidance for quest/m2/ts-narrow-test.md:16–19: keep folding conditional on the variant fact still being valid (including intervening reassignment, writes through aliases, and loop paths). Targeted widening is the simpler fallback when proving that would require broader dataflow machinery; include a changed-variant-between-matches regression alongside the unchanged/copy cases.
Verification: inspected the quest, related tsc-shapes plan, and #100's proposed lowering changes. No implementation changes are included here; I did not run tests or independently reproduce TS2367.
A follow-up quest the maintainer chose from #100's report: an inner match on a value an enclosing match already decided fails
tsc(TS2367), which #100's construction-time widening doesn't cover.Consumer: moq, whose translated output must type-check.
Public API: none.
(written by Opus 5.5)
🤖 Generated with Claude Code
https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn