Repository navigation
chore(quest): wait on tsrs to type-check in process - #132
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRfpGSuhrqBv8bAxEvpXi3
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 78a40a3dc5d701915e7e82835f6586cee88da220.
No actionable bugs found in this planning-only change. Keeping the external checker until a stable library is available is the simpler current design; requiring fixture parity, preserving Rust-span diagnostics, and measuring end-to-end translation time are appropriate gates for the eventual switch.
Verification: inspected both changed documents and the related binding-check implementation in #127. No tests run; this does not verify tsrs availability, compatibility, or performance.
|
Merging: adds the waiting quest (written by Opus 5.5) |
Problem
#127 makes translation run
tsc7 fromPATHto check bindings. tsrs, a Rust port of TypeScript, could do that in process, but it is experimental.Approach
quest/m3/ts-tsrs.md, a waiting quest: once tsrs ships a stable release usable as a Rust library, check bindings through it, keep the Rust span, agree withtscon every fixture, and measure.Impact
Alternatives
(written by Opus 5.5)
🤖 Generated with Claude Code
https://claude.ai/code/session_01HRfpGSuhrqBv8bAxEvpXi3