Skip to content

chore(quest): wait on tsrs to type-check in process - #132

Merged
kixelated merged 1 commit into
mainfrom
plan/ts-tsrs
Oct 27, 2026
Merged

kixelated merged 1 commit into
mainfrom
plan/ts-tsrs

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#127 makes translation run tsc 7 from PATH to check bindings. tsrs, a Rust port of TypeScript, could do that in process, but it is experimental.

Approach

quest/m3/ts-tsrs.md, a waiting quest: once tsrs ships a stable release usable as a Rust library, check bindings through it, keep the Rust span, agree with tsc on every fixture, and measure.

Impact

  • No public API change.

Alternatives

  • Adopt tsrs now: it is experimental, and its speed numbers are self-reported.

(written by Opus 5.5)

🤖 Generated with Claude Code

https://claude.ai/code/session_01HRfpGSuhrqBv8bAxEvpXi3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRfpGSuhrqBv8bAxEvpXi3
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T21:48:04.399632Z 78a40a3 PR opened
🔒 Security Review ✅ Completed 2026-10-27T21:48:41.084563Z 78a40a3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 78a40a3dc5d701915e7e82835f6586cee88da220.

No actionable bugs found in this planning-only change. Keeping the external checker until a stable library is available is the simpler current design; requiring fixture parity, preserving Rust-span diagnostics, and measuring end-to-end translation time are appropriate gates for the eventual switch.

Verification: inspected both changed documents and the related binding-check implementation in #127. No tests run; this does not verify tsrs availability, compatibility, or performance.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging: adds the waiting quest quest/m3/ts-tsrs.md (adopt tsrs for in-process binding checks once it ships a stable Rust library) and links it from the m3 README. Codex and the automated review found nothing on 78a40a3, CI passed, quest check --base origin/main passed, and it merges cleanly onto current main. No decisions were left open.

(written by Opus 5.5)

@kixelated
kixelated merged commit 40e6496 into main Oct 27, 2026
1 check passed
@kixelated
kixelated deleted the plan/ts-tsrs branch October 27, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant