Skip to content

chore(quest): drop ts-scalar-ice, fixed within #130 - #162

Merged
kixelated merged 3 commits into
mainfrom
quest/m2/ts-scalar-ice
Oct 28, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m2/ts-scalar-ice

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Proposes deleting quest/m2/ts-scalar-ice.md. The crash it plans to reproduce was fixed inside #130 itself, before the ICE report was found.

Findings

  • The report came from the same commit that fixed it: a31650f6 ("ok_or's error with an enum in it reached an unreachable take-apart; that ok_or now stays an object") added both ok_or_error and the report. The report's line numbers match that commit's parent, where scalar_call passed ok_or's error to scalar_operand without checking it.
  • The input isn't lost. That commit added fixture cases to ts/fixtures/lang/src/splits.rs (second, and split_first().ok_or(err) with an enum error). On current main, removing the ok_or_error guard makes lang panic with the report's backtrace: take_apart (the Shape::Enum arm) ← scalar_source ← scalar_operand ← scalar_call. With the guard, the lang snapshot and differential tests pass.
  • I checked every other checked by find_scalars assumption in scalar.rs against def_ok, producer, ok_or_error, and walk. Each one is guarded by the same rule. The one mismatch is that ok_or_error accepts an Operand::RuntimeChecks error that scalar_operand treats as unreachable. It can't be reached: the driver passes -Zub-checks=no, which folds ub_checks() to const false in the translated crate (checked in MIR, both inline and through a local), and std never passes it to ok_or. Following the rule to reproduce bugs before fixing them, I left it alone.

Decisions

  • Delete the quest (maintainer, 2026-10-28): the goal already holds on main, and the existing fixture proves it. The unreachable RuntimeChecks mismatch stays as is, since there is no crash to reproduce.

Public API: none.

Checks: quest check ok; just ts test --test fixtures lang passes on main, and fails with the report's backtrace when the guard is removed.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 27, 2026 23:55
Quest-Claim: 77de3a41c99e0263
#130's own a31650f added the ok_or_error guard and the splits.rs fixture
that crashes without it, with the same backtrace as the committed report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Byte-slice locals that crash the translator chore(quest): drop ts-scalar-ice, fixed within #130 Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 28, 2026 15:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T15:24:48.032317Z 47a2d9e Draft marked ready
🔒 Security Review ✅ Completed 2026-10-28T15:25:33.987345Z 47a2d9e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 47a2d9e

No actionable bugs found. Deleting this stale quest and its index entry is appropriate: a31650f added both the ok_or_error guard and the enum-error fixture cases, and those remain in the reviewed tree. This is simpler than maintaining a second task for an already-covered crash; the deletion changes no runtime code or public API.

Verification: static inspection of the deletion, original fix, current scalar guard, retained splits fixture and driver flags. I did not run the reported reproducer, differential tests or quest checks.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing: the maintainer decided to delete the quest. Merged main without conflicts; Codex reviewed head 47a2d9e with a thumbs-up and no findings; CI passed.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit c70c53e into main Oct 28, 2026
1 check passed
@kixelated
kixelated deleted the quest/m2/ts-scalar-ice branch October 28, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant