Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .claude/skills/quest-grill/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
name: quest-grill
description: Settle open decisions through an interactive interview with the user. Use when the user invokes /quest-grill or wants unsettled thinking challenged before action.
---

Run `quest skill grill` and follow its output.
If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first.
7 changes: 0 additions & 7 deletions .claude/skills/quest-ready/SKILL.md

This file was deleted.

7 changes: 7 additions & 0 deletions .claude/skills/quest-review/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
name: quest-review
description: Review a PR's branch locally with the other vendor's model, then mark it ready for review.
---

Run `quest skill review` and follow its output.
If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first.
11 changes: 3 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,9 @@ Open a draft PR while working, run `just check` and `just test` before every pus

# Reviews

AI agents review pushes on their own. Never explicitly request a review.

For each finding:

- If you don't agree with it, reply to the finding and move on.
- If it's a relatively easy improvement, fix it and push.

Queue a PR only after a review from a reviewer other than Grok has no findings, or every finding is fixed or replied to.
Review each PR locally with `/quest-review`, as the quest guide describes; merging never waits on an online reviewer, and never request one.
The PR body's `## Review` record counts as the required review when it names the head being merged, and so does a recorded skip of a change too trivial to review.
Address online reviewers' findings already posted on that head before merging: fix them, or reply where you disagree.

# Follow-ups

Expand Down
8 changes: 8 additions & 0 deletions REVIEW.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Review

Be adversarial: assume the change is wrong until the diff and its tests show otherwise.

- Generated output must match native Rust exactly, including integer widths and overflow, drop order, laziness, and error paths. Ask for the differential case that proves it.
- An unsupported construct must be refused with a source span, never a silent fallback or a runtime guess.
- A test must fail without the change it covers.
- Report real defects only; leave style to `just check` and AGENTS.md.
8 changes: 4 additions & 4 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# The quest CLI, which also serves the quest guide and skills the stubs in
# .claude/skills call. Bump the rev to upgrade them.
quest = {
url = "github:kixelated/quest/943cecaf58a2722dd05f27ab468972c5fe9b714d";
url = "github:kixelated/quest/01d051cf5dca8cd29c664bf8bcbcab63cdc76445";
inputs.nixpkgs.follows = "nixpkgs";
inputs.flake-utils.follows = "flake-utils";
};
Expand Down
7 changes: 1 addition & 6 deletions quest/m0/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,4 @@

## Goal

Urgent fixes to anything a consumer already depends on, and adopting local
reviews. Otherwise empty while nothing is released.

## Required

- [Adopt local reviews](/quest/m0/local-review.md) - PRs are reviewed locally by the other vendor's model before they are pushed, and merging never waits on an online reviewer
Urgent fixes to anything a consumer already depends on.
23 changes: 0 additions & 23 deletions quest/m0/local-review.md

This file was deleted.