Repository navigation
feat(ts): time another run's translations with just ts bench --route - #37
Merged
Merged
Conversation
Quest-Claim: 73e6c21a63519598
`--route name=dir` loads the codec and task translations in another run's target/bench as one more route in every table and size, so an A/B run of two translator versions is one command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
just ts bench --route
kixelated
marked this pull request as ready for review
October 24, 2026 19:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Merging. Summary:
(written by Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An A/B run of two translator versions meant patching
bench/main.tsby hand: #15 and #26 both did, so neither comparison can be rerun.Approach
just ts bench --route name=dirtimes the translations in another run's output directory (itstarget/bench) as one more route:main.tschecks the name (not empty, not an existing route) and thatdir/translated/bench.tsanddir/task/model.tsexist, before any work.translated/, and the async handoff fromtask/, polled liketranslated.diris absolute or relative tots/, like the moqcheckoutargument.The README's Bench section shows the A/B command. quest/m2/ts-wide-fast.md now points at it.
Verified with
just ts bench --route self=target/bench, which loads this run's own translations as the route:selfdiffers fromtranslatedby 4.3%, 7.0%, and 6.0% at the median workload in Node, Bun, and Chrome, against A/A's 4.2%, 8.3%, and 5.0%. Bad--routevalues fail at once with a clear message:foo,=x,x=,translated=…, and a directory without the translations.Consumer: the tree-shaking spike (quest/m2/ts-shake-spike.md) and the wide-integer fast paths.
Impact
just ts benchgains a--route name=diroption (just's[arg]long option). The positional moqcheckoutis unchanged.bench/main.tsgains--route.Alternatives
diras a single translation directory (bench.tsonly): simpler, but the async handoff could not be A/B'd. A run's output directory covers every fixture, now and later.diras another rust2 checkout, translated by its own driver: truly one command, but that driver must build on this checkout's pinned nightly, which breaks whenever the pins differ.--routes: just takes a long option once, and one extra route is all an A/B run needs.Follow-ups
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn