Repository navigation
perf(ts): return a Result of numbers alone in a slot #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
603f05a
chore(quest): claim quest/m2/ts-byte-views/README.md
kixelated f8b1cdc
perf(ts): return a Result of numbers alone in a slot
kixelated 3a24e34
Merge remote-tracking branch 'origin/main' into quest/m2/ts-byte-view…
kixelated ad1cc2f
chore(ts): update results' snapshot for #381's merge
kixelated 480c35d
Merge base into PR 385, preserving both generated Result maps
ac0c1ff
chore(ts): regenerate core/result.ts's snapshot for #384's merge
kixelated 423e32f
Merge remote-tracking branch 'origin/main' into fix-pr-385-ci
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/rust2
Length of output: 12114
Script executed:
Repository: moq-dev/rust2
Length of output: 1420
Correct the numbers-only Result rule in the migration note.
The sentence at
ts/MIGRATE.md:12says a Result "of numbers alone" returns its error orundefinedand leaves theOkparts in the slot. The next sentence, at lines 13-14, says a Result whose firstOkpart is a number returns that number, orundefined, and writes the error to the slot. The generated code follows the second rule for numbers. Migrators who follow line 12 will read the error from the return value and the number from the slot, which is wrong.Describe the two shapes separately:
u8,u16,varint): return the number, orundefinedon error. Write the error to the slot.bool): return the error, orundefinedon success. Write the value to the slot.Suggested fix
Committable suggestion