Skip to content

chore: bump the rustc nightly to 2026-11-12, with a canary on the newest - #729

Merged
kixelated merged 15 commits into
mainfrom
quest/m0/nightly-bump
Nov 13, 2026
Merged

kixelated merged 15 commits into
mainfrom
quest/m0/nightly-bump

Conversation

@kixelated

@kixelated kixelated commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Bumps the nightly every driver links from nightly-2026-10-15 to nightly-2026-11-12 (rustc 1.102.0, 3ef0c22cd), with flake.lock's rust-overlay bumped to name it. Ports driver/, ffi/, go/, and ts/ to the new compiler and std, and adds a canary job to nightly.yml that runs every module on the newest nightly, so the next bump's breaks show up before that bump starts. Implements quest/m0/nightly-bump.md and schedules its next run for 2026-12-24.

Summary

rustc internals

  • GenericArgsRef is gone. GenericArgs is now a Copy value with no range Index (use as_slice / as_tcx_slice); derefs applied with cargo fix --broken-code.
  • ParamEnv::caller_bounds() is now an accessor: .all_clauses(tcx).iter().
  • LayoutData::align is a plain Align.
  • Tool attributes are Attribute::Tool(AttrItem), so rust2-lint reads its budget through tcx.tool_attrs and parses the arguments with MetaItemKind::list_from_tokens.
  • Doc comments are read through AttributeExt::doc_str_and_fragment_kind. Both /// and #[doc = ".."] still become DocComment, so the result is the same.

Expansion and std changes. Only the differential tests caught these.

  • Derived Debug:
    • debug_struct_field{N}_finish and debug_struct_fields_finish now take the type's and fields' names joined by spaces. A name with no space is a tuple struct's.
    • An enum with five or more fieldless variants now calls debug_c_like_enum_write_str(names, byte_offset).
    • New runtime helpers mirror std: fmtDebugFields / fmtDebugEnum (ts) and debugFields / debugEnum (go). The go codec fixture's thiserror enum reached slice::Split through std's new path, so go refused it until this mapping existed.
  • vec![x; n] now calls vec::from_elem_global.
  • panic!(), unreachable!(), unimplemented!(), and todo!() with no message now call core::panicking::*_default_msg.
  • String: FromIterator<char> starts from with_capacity(size_hint().0), which changes capacities. Covers the generic collect (new stringFromChars) and ts's from_utf16_lossy.
  • str::EscapeDefault has specialized Extend / FromIterator / ToString that reserve by its flat map's parts, plus ten bytes before each \u{..}. Mirrored exactly (stringExtendEscapeDefault); the capacity fixture gains four cases (ops 49–52) for it.
  • Fuse forwards advance_back_by, so a Take under a Chain now trims its source from the back.
  • Skip::advance_by(0) takes no step while it still skips, so an iterator that is not fused is not seen ending early. The iters fixture gains iters::unfused, which runs a non-fused iterator through Skip and Fuse.
  • std::vec::from_elem is now a stable, deprecated wrapper over from_elem_global, so ts maps both, and capacity's op 24 calls it.
  • EscapeDebug's Display/Debug drops its literal char once it has been yielded.
  • IoSlice::advance now panics mid > len from split_at. Ready rewords both of its panics.
  • Pattern is an unsafe trait and Allocator is stable as of 1.100, so the ffi reject fixture is updated for both.

Canary. A new canary job ("Newest nightly") in nightly.yml:

  • sh/canary.sh updates rust-overlay, then points ts/rust-toolchain.toml at the newest nightly that ships every component and target the file lists (selectLatestNightlyWith).
  • It then runs check and test for driver, ffi, go, and ts; each step runs even when an earlier one fails.
  • continue-on-error, and report does not wait on it, so it fails no merge and opens no issue.

Review fixes (this round).

  • sh/canary.sh selects with the profile the dev shell builds: the file's profile, else default, as fromRustupToolchainFile does. Before, it checked minimal, so it could pick a nightly the shell then failed to build.
  • The canary's module steps run only when its Toolchain step succeeded. Otherwise they would run on the pinned nightly and read as a pass.
  • String: Extend now specializes on the argument's own type, as std does. Before, the translator checked the IntoIter type, so a wrapper whose into_iter is a str::EscapeDefault got std's reservation for EscapeDefault itself (Codex found this). capacity op 53 covers it. The capacity caller now drives ops 48–53: it stopped at 47, so ops 48–52 never ran. Without the fix, the differential run shows 22 differences.
  • Merged main. chore(deps): bump the nix group with 2 updates #738 had bumped rust-overlay to a 2026-11-05 revision, which does not name nightly-2026-11-12, so flake.lock keeps main's other inputs and this branch's rust-overlay revision (2026-11-12).

Quest. quest/m0/nightly-bump.md is rewritten for its next run: scheduled 2026-12-24, with this run's findings carried forward.

Code snapshots (128 expected/ files) move for two reasons:

  • rustc's MIR shape: block and loop layout, break labels, temp numbering.
  • The derived-Debug calls above.

Every fixture's differential run against native Rust passes, so behavior did not move.

go/ port cost, for weighing whether to keep it: 41 lines added and 35 removed over 7 files, all derived Debug or mechanical renames. ts/ took 380 added and 302 removed over 36.

Public API: none. Wire: none.

Validation

Choices made without asking

  • Code snapshots regenerated. The quest said "a fixture whose expected output moves is a finding to explain in the PR, not to regenerate". I read that as differential output, which did not change. Code snapshots necessarily move with rustc's MIR shape, so I regenerated them after the differential runs passed and explained the causes above. The rewritten quest states it that way.

  • The canary runs each module's checks and tests, not only builds. Most of this run's cost was std behavior that only the differential tests caught, so a build-only canary would have missed it.

  • The canary updates the rust-overlay input before choosing, so it tests the newest nightly rather than the newest one the pinned lock names.

  • ts runtime keeps fmtDebugStructFields / fmtDebugTupleFields for its own impls. They drop the length assertion that mirrored std's removed assert_eq!.

  • This round's review ran Codex alone. opencode is still out of quota. Three rounds: one finding (above), then 10/10 with no findings on efd1d29 and again on the merge head f380be9.

  • The previous round's review ran Codex alone, in a new session. opencode is out of quota. Its round-1 findings (Fuse's clearing branch untested; no unimplemented!() fixture) are both fixed in 131e926: iters::unfused cases 1 and 2, and panics case 36. Codex's round-1 findings (Skip's zero advance; vec::from_elem) are fixed in the same commit. quest review would not resume Codex while opencode's findings were unsettled, so --new started a fresh Codex review of the whole change.

  • Newly stable std APIs are not mapped here. A std-diff audit found that String::into_chars, slice split_once / rsplit_once, and Rc/Arc::is_unique became stable. No translator supported them before, and an unsupported one is still a compile-time refusal, so nothing regresses. Mapping them is coverage work, not part of this bump.

Follow-ups

None.

Caused by

No single PR: an upstream compiler and std change.

Models

Size: M
Implementer: Claude, claude-opus-5-5, unknown effort
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, S)

Review

Rewritten by quest review after each round.

  • Head: f380be9

  • Base: origin/main at cf1f0f9

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1d624-0dff-7280-9672-18892eae8729, round 3

  • Score: 10/10, The merge preserves the previously reviewed branch changes and rust-overlay pin, with no new issues found by inspection; builds and tests were not run.

  • Findings: none

Summary by CodeRabbit

  • New Features

    • Added a nightly canary workflow to run driver, FFI, Go, and TypeScript checks.
    • Improved generated debug output for structs, tuples, and enums, and added an iterator edge-case test.
    • Added more string collection options for escaped characters.
  • Bug Fixes

    • Fixed iterator advancement and collection-loop behavior in edge cases.
    • Corrected slice-advance bounds handling and alignment reporting.
    • Updated task completion errors for clearer messages.
  • Maintenance

    • Updated the Rust nightly toolchain and compiler compatibility.

Summary by CodeRabbit

  • New Features

    • Added support for collecting and extending strings from default-escaped characters.
    • Expanded iterator compatibility, including additional handling for fused and non-fused iterators.
  • Bug Fixes

    • Corrected several iterator and collection operations that could skip work or produce incorrect results.
    • Improved slice advancement checks and memory-alignment handling.
  • Improvements

    • Updated generated debug formatting for structs and enums.
    • Updated support for a newer Rust nightly release.

Quest-Claim: 2157d1a20ef95679
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The PR advances the Rust nightly pin to 2026-11-12 and adds a canary job that selects a matching nightly and runs checks across the driver, FFI, Go, and TypeScript. It updates compiler integrations and runtimes, adds iterator coverage, and refreshes generated fixtures.

Changes: Nightly update and compiler compatibility

Layer / File(s) Summary
Canary workflow and recurring bump plan
.github/workflows/nightly.yml, sh/canary.sh, ts/rust-toolchain.toml, quest/m0/nightly-bump.md
The workflow adds a canary job that selects a compatible nightly and runs checks and tests across the driver, FFI, Go, and TypeScript. The pinned nightly changes to nightly-2026-11-12. The quest plan records the recurring six-week schedule and findings from the run.
Rust compiler API updates
driver/src/bin/rust2-lint/mono.rs, ffi/src/collect.rs, go/src/lower/*, ts/src/lower/*
Compiler integrations use GenericArgs and updated rustc attribute, caller-bound, and layout APIs. TypeScript lowering also updates mappings for default-message panics, from_elem_global, and str::EscapeDefault.
Runtime and formatter updates
go/runtime/rt_fmt.go, ts/runtime/rs.ts, ts/runtime/rs/*
The runtimes add shared debug-field and enum formatting helpers, string constructors for character and escape-default iterators, and iterator support changes. ioSliceAdvance adds a check for advances beyond the slice length.
Iterator coverage and generated outputs
ts/fixtures/lang/iters/*, ts/fixtures/lang/capacity/*, ts/fixtures/*/expected/*
The iterator fixture adds Flicker and unfused coverage. Capacity fixtures add five escape-default string operations. Generated outputs use the updated formatting and string helpers; other fixtures include compiler-output changes to loops, helper placement, and iteration behavior.

Estimated code review effort: 4 (Complex) | ~60 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant NightlyWorkflow
  participant CanaryScript
  participant RustOverlay
  participant ToolchainFile
  participant CheckJobs
  NightlyWorkflow->>CanaryScript: Select compatible nightly
  CanaryScript->>RustOverlay: Update flake input
  CanaryScript->>ToolchainFile: Write selected channel
  NightlyWorkflow->>CheckJobs: Run driver, FFI, Go, and TypeScript checks
Loading
Security architecture risk: Minimal · up to f380b

The inspected changes preserve existing rejection controls and state ownership. The experimental toolchain runs separately from the pinned checks and does not receive repository-write permission. No introduced security or failure-containment regression was established.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The newest-nightly path adds execution of an updated toolchain within the canary job's workspace. Its declared authority does not include repository or issue writes, and its results do not feed the separately privileged reporting step.

Trust Boundaries and Controls

  • inferred — The inspected public-entrypoint signals do not establish a new remotely reachable interface or a bypass of lowering rejection controls. Translator retains its existing refusal path, and the added Escaped export serves the capacity fixture rather than introducing service authority.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names two changes: the rustc nightly bump to nightly-2026-11-12 and a canary job on the newest nightly. The objectives and raw summary confirm both. The rustc nightly bump is the main change…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names two changes: the rustc nightly bump to nightly-2026-11-12 and a canary job on the newest nightly. The objectives and raw summary confirm both. The rustc nightly bump is the main change, since the toolchain pin, driver/ffi/go/ts ports, and fixture updates make up most of the diff. The canary is a real but secondary addition in nightly.yml and sh/canary.sh. The title is short, specific, and follows the conventional-commit style.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 347cdcb1-497c-430e-aeeb-38b5591f336b
Commits

Reviewing files that changed from the base of the PR and between 7b55fb2 and f380be9.

Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock
Files selected for processing: 18

  • .github/workflows/nightly.yml
  • sh/canary.sh
  • ts/fixtures/lang/capacity/caller.ts
  • ts/fixtures/lang/capacity/expected/capacity.Escaped$strings.ts
  • ts/fixtures/lang/capacity/expected/capacity.ts
  • ts/fixtures/lang/capacity/src/capacity.rs
  • ts/fixtures/lang/counts/expected/counts.ts
  • ts/fixtures/lang/pointers/expected/pointers.ts
  • ts/runtime/rs.ts
  • ts/runtime/rs/task.ts
  • ts/src/lower/collections.rs
  • ts/src/lower/copy.rs
  • ts/src/lower/iter.rs
  • ts/src/lower/mir/call.rs
  • ts/src/lower/mir/origin.rs
  • ts/src/lower/mod.rs
  • ts/src/lower/pointer.rs
  • ts/src/lower/task.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

kixelated and others added 8 commits November 12, 2026 17:55
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and Allocator stable

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s, and IoSlice::advance to 1.102's std

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fault, Fuse::advance_back_by, and EscapeDebug's Debug

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Bump the rustc nightly, on a schedule chore: bump the rustc nightly to 2026-11-12, with a canary on the newest Nov 13, 2026
kixelated and others added 3 commits November 13, 2026 02:54
… cover the unfused paths

Skip takes no step when advanced by none while it still skips. std::vec::from_elem
is now a stable deprecated wrapper over from_elem_global, so both map. The iters
fixture gains an unfused iterator through Skip and Fuse, and panics covers
unimplemented!() with no message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…earnings

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 13, 2026 11:11

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues. There are two rough edges in the new canary job; the port itself looks right.

Reviewed changes

I reviewed the whole bump. That covers the rustc port across driver/, ffi/, go/, and ts/, the runtime mirrors of std 1.102, the new fixture cases, the canary job, and the rescheduled quest. I spot-checked the regenerated expected/ code snapshots rather than reading them line by line: the differential runs against native are what prove their behavior.

  • Mechanical rustc port: GenericArgsRef becomes GenericArgs, caller_bounds().all_clauses(tcx).iter() replaces the iterator, layout.align becomes a plain Align, and doc_str_and_fragment_kind reads doc comments. rust2-lint reads Attribute::Tool(AttrItem) through tcx.tool_attrs and MetaItemKind::list_from_tokens.
  • Derived Debug: new fmtDebugFields / fmtDebugEnum (ts) and debugFields / debugEnum (go) handle the space-joined names and the byte offset of debug_c_like_enum_write_str. The caller-site needles are retargeted.
  • std behavior mirrors: the PR maps vec::from_elem_global, the *_default_msg panics, and stringFromChars. str::EscapeDefault's specialized Extend / FromIterator / ToString get their own path. It also covers Fuse::advance_back_by, Skip::advance_by(0), EscapeDebug's literal char, IoSlice::advance, and the Ready messages. New cases cover each of these (iters::unfused, capacity op 24 and ops 49–52, panics case 36).
  • ffi reject fixture: unsafe impl Pattern, and the allocator_api feature is dropped now that Allocator is stable.
  • Canary: sh/canary.sh updates rust-overlay and points ts/rust-toolchain.toml at the newest nightly that has every listed component. The new continue-on-error job runs every module's check and test on it, and report does not wait on it.
  • Quest: quest/m0/nightly-bump.md is rewritten for its next run on 2026-12-24 and carries this run's findings forward.

I did not run the suite locally, because the 2026-11-12 nightly isn't in this environment. This review relies on the just gate / just ci results in the PR description.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread sh/canary.sh Resolved
Comment thread .github/workflows/nightly.yml Resolved
kixelated and others added 3 commits November 13, 2026 09:55
… when its toolchain step fails

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… not its IntoIter

The capacity caller now drives every strings op, 48 to 53, which it skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-2026-11-12

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. Both canary findings from the last review are fixed, and the new Extend change matches std.

Reviewed changes

This run covers the commits since 7b55fb2: the canary fixes, a fix to how String's Extend specializes, and a merge of main.

  • Canary toolchain profile: sh/canary.sh now selects the nightly with t.${file.profile or "default"}. That is the same profile fromRustupToolchainFile builds for the dev shell, so the canary can no longer pick a nightly the shell can't build.
  • Canary step gating: the Toolchain step gets id: toolchain, and every module step requires steps.toolchain.outcome == 'success'. A failed toolchain selection no longer runs the modules on the pinned nightly.
  • String's Extend specialization: string_extend now takes (source, iter) and checks for EscapeDefault on the source type. At 3ef0c22cd, std's SpecExtendChars dispatches on I itself, while FromCharIterSpec (FromIterator<char>) dispatches on I::IntoIter. So collect correctly keeps passing (from, from). Capacity op 53 tests a wrapper whose into_iter returns an EscapeDefault.
  • Merged main: rust-overlay stays at 8bbfc858, the PR's newer rev that provides nightly-2026-11-12.

I still haven't run the toolchain locally, because nightly-2026-11-12 isn't installed in this environment.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit bde9578 Nov 13, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m0/nightly-bump branch November 13, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant