Repository navigation
feat(ffi)!: Rust takes owned buffers, and bindings pass Rust's bytes back uncopied #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
60a0ca7
chore(quest): claim quest/m1/ffi-export/owned-bufs.md
kixelated 4456d6a
feat(ffi): Rust takes a passed buffer that has an owner, and buf_clon…
kixelated cfe5920
docs(ffi): the buffer rule names what Rust takes, and fmt
kixelated 9399ed5
wip(ffi): Swift and Go pass Rust's buffers back without a copy
kixelated a628adb
wip(ffi): owned-bufs binding checkpoint
kixelated 5278978
wip(ffi): owned-bufs binding checkpoint
kixelated ac789c7
wip(ffi): owned-bufs binding checkpoint
kixelated bda7e77
wip(ffi): owned-bufs binding checkpoint
kixelated 49baa2e
Merge branch 'owned-bufs-cpp' into quest/m1/ffi-export/owned-bufs
kixelated 178cf0c
wip(ffi): Dart forwarder test catches a copy
kixelated 4597f74
fix(ffi): moq's Go programs pass rt.Bytes
kixelated 0911519
feat(ffi)!: Kotlin passes bytes once copied, and Rust's own back unco…
kixelated b57b7b7
Merge branch 'owned-bufs-kotlin' into quest/m1/ffi-export/owned-bufs
kixelated 0bbd4a8
feat(ffi): Python passes a copy once and Rust's bytes back in place
kixelated 6c249de
style(ffi): rustfmt the core's glue.rs
kixelated 850eec0
Merge branch 'owned-bufs-python' into quest/m1/ffi-export/owned-bufs
kixelated 36de37e
Merge branch 'owned-bufs-dart' into quest/m1/ffi-export/owned-bufs
kixelated 39709a5
Merge branch 'owned-bufs-swift-go' into quest/m1/ffi-export/owned-bufs
kixelated 0b129fc
fix(ffi): moq's Kotlin programs pass Bytes
kixelated 29fa953
chore(quest): owned-bufs keeps Kotlin's encoded bytes and the re-measure
kixelated c6a6db5
feat(ffi)!: Swift's bytes are Bytes, which pass Rust's buffer back un…
kixelated 60c7474
feat(ffi): Kotlin's bytes and text in a call cross once
kixelated b10360f
fix(ffi): Swift's test waits on nothing a task may still hold
kixelated 2feb13c
perf(ffi): Rust takes a whole buffer as is, without promoting it to s…
kixelated 534ef66
perf(ffi): Dart copies its short bytes on the stack, as before
kixelated e5310c8
chore(quest): owned-bufs finishes; bytes-write keeps Swift's and Dart…
kixelated 7f2f6f9
Merge origin/main into quest/m1/ffi-export/owned-bufs
kixelated 07331b2
fix(ffi): Python keeps Rust's bytes a call reads in place; C++ shares…
kixelated 2ee6c0f
fix(ffi): keep Rust's bytes from leaking or freeing early around a call
kixelated c4fc3bc
merge: reconcile owned buffers with base async start
941766a
merge: origin/main, with numeric slices as blocks
kixelated d2dd36b
style: rustfmt under the pinned toolchain
kixelated a6eb7de
fix(ffi): Kotlin's flattened records pass the arrays their rest names…
kixelated 1091c9a
style(ffi): one format for the Go driver's imports
kixelated 0a9a4ac
fix(ffi): C++ holds a hoisted kept closure in a unique_ptr until the …
kixelated 141b4c1
Merge origin/main into quest/m1/ffi-export/owned-bufs
kixelated 75fd966
fix(ffi): C++ holds a hoisted future in a unique_ptr until the call
kixelated 56d3f1e
Merge remote-tracking branch 'origin/main' into quest/m1/ffi-export/o…
kixelated 3a54baa
docs(ffi): qualify no-copy claims, refresh bench comparisons, keep fo…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.