Skip to content

chore(quest): typed copies, char and vec!, Firefox bench, narrower bench reruns - #80

Merged
kixelated merged 1 commit into
mainfrom
plan/followups2
Oct 26, 2026
Merged

kixelated merged 1 commit into
mainfrom
plan/followups2

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans follow-ups from #74, #78, and #79. The moq side (slow tests, nested Options) is in a linked moq PR.

Quests

  • m2 ts-copy [S]: copying a Copy aggregate shares its references. Today it deep-copies them, which is a silent miscompile found in fix(ts): translate what MIR refused and THIR did not #78's review.
  • m2 ts-char-vec [S]: translate char and vec![x]. moq-net has 6 refused char switches and 17 refused vec! sites.
  • m2 ts-bench-firefox [S]: add SpiderMonkey to just ts bench.
  • m3 bench-rerun [S]: a push reruns the build bench only when it changes a bench input since the last benched head.

Decisions

  • ✅ TS follow-ups: typed copy, char with vec![x], and Firefox in the bench.
  • ✅ Option<Option<_>>: rewrite moq's 3 functions instead of representing it (moq quest).
  • ✅ Bench reruns: diff against the last benched head, without per-job filtering. The benches are already split by project (build vs FFI).
  • ✅ taplo .tmp/ exclude: fixed directly in its own PR, with no quest.

Public API: none in this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn

…nch reruns

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T16:36:46.069533Z 6a6bab3 PR opened
🔒 Security Review 🔄 Running since 2026-10-26T16:35:51.575196Z 6a6bab3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 6a6bab359c1993b80e4fc1ff5d2287b05fa098fe.

No new actionable findings in this planning-only change. Type-guided copies address the underlying identity problem; reusing the browser benchmark harness and avoiding per-job benchmark filtering keep the proposed changes appropriately small. The char/vec plan explicitly preserves Rust semantics and calls for differential coverage.

The previously acknowledged borrowed-payload copy defect remains present in ts/src/lower/body.rs:101-105: quest/m2/ts-copy.md records the follow-up, not a fix. No duplicate inline finding.

Verification: GitHub-only inspection of all six changed files, the copy lowering, browser harness, build-benchmark workflow, and related review discussion. Tests, quest lint, census, and benchmarks were not run.

(Written by Codex)

@kixelated
kixelated merged commit 0497954 into main Oct 26, 2026
1 check passed
@kixelated
kixelated deleted the plan/followups2 branch October 26, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant