Repository navigation
chore(quest): typed copies, char and vec!, Firefox bench, narrower bench reruns - #80
Conversation
…nch reruns Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 6a6bab359c1993b80e4fc1ff5d2287b05fa098fe.
No new actionable findings in this planning-only change. Type-guided copies address the underlying identity problem; reusing the browser benchmark harness and avoiding per-job benchmark filtering keep the proposed changes appropriately small. The char/vec plan explicitly preserves Rust semantics and calls for differential coverage.
The previously acknowledged borrowed-payload copy defect remains present in ts/src/lower/body.rs:101-105: quest/m2/ts-copy.md records the follow-up, not a fix. No duplicate inline finding.
Verification: GitHub-only inspection of all six changed files, the copy lowering, browser harness, build-benchmark workflow, and related review discussion. Tests, quest lint, census, and benchmarks were not run.
(Written by Codex)
Plans follow-ups from #74, #78, and #79. The moq side (slow tests, nested Options) is in a linked moq PR.
Quests
ts-copy[S]: copying aCopyaggregate shares its references. Today it deep-copies them, which is a silent miscompile found in fix(ts): translate what MIR refused and THIR did not #78's review.ts-char-vec[S]: translatecharandvec![x]. moq-net has 6 refusedcharswitches and 17 refusedvec!sites.ts-bench-firefox[S]: add SpiderMonkey tojust ts bench.bench-rerun[S]: a push reruns the build bench only when it changes a bench input since the last benched head.Decisions
charwithvec![x], and Firefox in the bench.Option<Option<_>>: rewrite moq's 3 functions instead of representing it (moq quest)..tmp/exclude: fixed directly in its own PR, with no quest.Public API: none in this PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn