Skip to content

chore: bump quest to v0.18.0 - #857

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest-bump
Nov 17, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest-bump

Conversation

@moq-bot

@moq-bot moq-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the quest input, github:moq-dev/quest, from 4249857 to release v0.18.0 (1ab7d70): https://github.com/moq-dev/quest/releases/tag/v0.18.0

Changes: moq-dev/quest@4249857...1ab7d70

quest init and quest check --fix with the new quest changed nothing else.

Review

Skipped: pin bump, no repository code changed; CI's quest check is the gate.

Opened by quest land watch, which replaces this branch with each newer bump.

@moq-bot
moq-bot Bot enabled auto-merge November 17, 2026 10:10
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c73e75a5-9155-4351-b4b2-9c26aeada5f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 871eb85bba4e3f1acf0a67cc3154410aae50541b.

Hold the record-sender rollout across mixed versions, if enabled. v0.17.3 adds required gated and shell fields to the strict SessionRecord parser (release diff). A v0.17.2 receiver rejects new uploads with the extra keys, and a v0.17.3 receiver rejects old uploads without them, even when the correct new field values would be null. Leave senders and receivers on compatible versions, or first ship a parser that accepts both shapes. This is separate from the inherited remote quest status compatibility and watcher logging concerns. A lockfile bump does not establish any of those services have upgraded. Static review.

@moq-bot
moq-bot Bot disabled auto-merge November 17, 2026 10:17
@moq-bot moq-bot Bot changed the title chore: bump quest to v0.17.3 chore: bump quest to v0.18.0 Nov 17, 2026
@moq-bot
moq-bot Bot enabled auto-merge November 17, 2026 10:17

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 12f369602c5e4b93beacffb745959df68ea48253.

Keep remote forge clients and server on compatible schemas. v0.18.0 adds a required base field inside the strict OpenPull shape used by /forge/pulls and /forge/held (upstream change). New clients reject older responses that omit it, while older clients reject newly emitted fields. This extends the earlier mixed-version problem beyond status. Local GitHub-only use does not hit this response schema. Do not treat the passing lockfile check as validating a hosted forge rollout; stage support for both shapes or version these endpoints before mixing releases. Static review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the flake.lock pin bump for the quest input.

  • quest pin: moves rev, narHash and lastModified to v0.18.0 (1ab7d70). No repository code changed. (The PR title and body say v0.18.0, while the first commit's subject says v0.17.3. The second commit supersedes it.)

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 17, 2026
@moq-bot
moq-bot Bot disabled auto-merge November 17, 2026 10:25
Merged via the queue into main with commit 5f1120f Nov 17, 2026
8 checks passed
@moq-bot
moq-bot Bot deleted the quest-bump branch November 17, 2026 10:32
@codspeed

codspeed Bot commented Nov 17, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.6%

2 warnings

⚠️ 37 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 81 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ ready 5.6 s 6.8 s -17.25%
⚡ loop 11.9 s 10 s +19.4%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing quest-bump (12f3696) with main (68a39eb)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant