Repository navigation
chore: bump quest to v0.18.0 - #857
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 871eb85bba4e3f1acf0a67cc3154410aae50541b.
Hold the record-sender rollout across mixed versions, if enabled. v0.17.3 adds required gated and shell fields to the strict SessionRecord parser (release diff). A v0.17.2 receiver rejects new uploads with the extra keys, and a v0.17.3 receiver rejects old uploads without them, even when the correct new field values would be null. Leave senders and receivers on compatible versions, or first ship a parser that accepts both shapes. This is separate from the inherited remote quest status compatibility and watcher logging concerns. A lockfile bump does not establish any of those services have upgraded. Static review.
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 12f369602c5e4b93beacffb745959df68ea48253.
Keep remote forge clients and server on compatible schemas. v0.18.0 adds a required base field inside the strict OpenPull shape used by /forge/pulls and /forge/held (upstream change). New clients reject older responses that omit it, while older clients reject newly emitted fields. This extends the earlier mixed-version problem beyond status. Local GitHub-only use does not hit this response schema. Do not treat the passing lockfile check as validating a hosted forge rollout; stage support for both shapes or version these endpoints before mixing releases. Static review.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the flake.lock pin bump for the quest input.
questpin: movesrev,narHashandlastModifiedto v0.18.0 (1ab7d70). No repository code changed. (The PR title and body say v0.18.0, while the first commit's subject says v0.17.3. The second commit supersedes it.)
claude-sonnet-5-5 | 𝕏
Merging this PR will degrade performance by 0.6%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |

Bumps the
questinput, github:moq-dev/quest, from4249857to release v0.18.0 (1ab7d70): https://github.com/moq-dev/quest/releases/tag/v0.18.0Changes: moq-dev/quest@4249857...1ab7d70
quest initandquest check --fixwith the new quest changed nothing else.Review
Skipped: pin bump, no repository code changed; CI's quest check is the gate.
Opened by
quest land watch, which replaces this branch with each newer bump.