Skip to content

quest: refresh stale waits, and hold crabx-app for the first publish - #868

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/waiting-refresh
Nov 19, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/waiting-refresh

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This updates four quests whose state changed outside the tree, as this run of /quest-run found on 2026-11-18:

  • quest/m3/session-quic.md: moq's runtime-free QUIC driver quest moved from m3 to m4 (moq-dev/moq#8637) without landing, so the link and milestone now match.
  • quest/m2/crabx/binstall-tags.md: cargo-bins/cargo-binstall#2752 merged on 2026-11-15, so the maintainer's reply item is gone. The quest now waits only on a release carrying it (latest v1.27.0 / binstalk v0.30.0 predate it).
  • quest/m1/ffi-refusals/moq-pin.md: adds today's just ffi moq-cpp measurement at moq 71c6209f. Both recursion overflows remain, plus 16 stale excludes and 5 refusals the bump fixes. It also links moq's new quest for the fix (moq-dev/moq#9136).
  • quest/m3/crabx-app.md: now requires quest/m2/crabx/first-publish.md, so it isn't offered before crabx can be installed.

Decisions

  • Refresh the stale waits (maintainer, 2026-11-18): ✅ all three (rejected: leave them stale).
  • crabx-app (maintainer, 2026-11-18): ✅ require first-publish (rejected: start it now; delete it).

Validation

quest check and just ci pass. The moq measurement came from quest gate just --justfile ffi/justfile moq-cpp <moq checkout at 71c6209f>.

Public API: none.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: db91a2e

  • Base: origin/main at 65231b4

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f12f-7585-7043-9843-1540141e6ff5, round 1

  • Score: 10/10, The documentation changes are internally consistent, alter no executable behavior, and have no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Summary by CodeRabbit

  • Documentation
    • Updated project tracking to reflect the accepted release-tag change and the steps still needed before it ships.
    • Clarified that the crabx pipeline work is waiting for its first published release.
    • Updated the QUIC driver status to reflect its move to a later milestone and the next release cut.
    • Recorded the current moq pin status, including remaining recursion-depth overflows and export failures addressed by the update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

This PR updates four quest documents. The updates record moq exporter results, binstall release tracking, a crabx App pipeline prerequisite, and the current location and release status of the QUIC driver quest.

Changes: moq exporter pin

Layer / File(s) Summary
Pin status and export results
quest/m1/ffi-refusals/moq-pin.md
The Waiting section records the recursion-depth overflows at moq 71c6209f, 21 export failures addressed by the pin bump, and a link to the planned fix.

binstall release tracking

Layer / File(s) Summary
Release and crabx follow-up
quest/m2/crabx/binstall-tags.md
The plan records the upstream merge. The Waiting section tracks the release, binstalk dependency bump, and patch removal.

crabx App pipeline prerequisite

Layer / File(s) Summary
First publish requirement
quest/m3/crabx-app.md
The Plan records the decision to wait for crabx’s first publish. The Required section names crabx 0.1.0 on crates.io and npm as a prerequisite for the pipeline to run.

QUIC driver quest tracking

Layer / File(s) Summary
Driver quest location and release status
quest/m3/session-quic.md
The Waiting entry points to the runtime-free QUIC driver quest under m4 and records that it awaits the next release cut.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • kixel-ai/rust2#736: Changes the scope of the moq pin quest document, which this PR also updates.

Suggested reviewers: pullfrog

Merge Risk: Minimal · up to db91a

This PR updates planning documents to reflect current upstream status and has no runtime impact. It is safe to merge.

Architecture risk: Low · up to db91a

The change affects 1 system.

Changed systems: quest

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — quest (service) was modified; 4 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in quest/m1/ffi-refusals/moq-pin.md: The Waiting section now records that both recursion-depth overflows persist at moq 71c6209f, identifies the moq-tokio location, and reports 16 stale excludes plus five export refusals that the bump addresses. It links the planned fix in moq’s quest.
  • observed — Modified behavior in quest/m2/crabx/binstall-tags.md: The plan now says upstream’s change merged on 2026-11-15. The Waiting section replaces the open-PR, maintainer-reply, and CI-approval tasks with a release-and-crabx follow-up: wait for a cargo-binstall release carrying #2752, then bump binstalk and remove the patch. It records that v1.27.0 and binstalk v0.30.0 predate the change and says to check for newer v* and binstalk-v* releases.
  • observed — Modified behavior in quest/m3/crabx-app.md: The Plan adds the decision to wait for crabx’s first publish and records the rejected alternatives. A new Required section names crabx 0.1.0 on crates.io and npm as the prerequisite for the pipeline opened by the App to run.
  • observed — Modified behavior in quest/m3/session-quic.md: The Waiting entry updates the driver quest link from m3 to m4 and replaces the m3/breaking-release status with m4 awaiting its next release cut, citing moq#8637 and the 2026-11-14 move from m3. The completion condition remains unchanged.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes in the PR: refreshing stale waits across quest documents, and holding crabx-app until the first publish. Both match the raw summary and PR objectives. The title is…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes in the PR: refreshing stale waits across quest documents, and holding crabx-app until the first publish. Both match the raw summary and PR objectives. The title is specific enough for a teammate scanning history.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 91ca90e7-0542-4ddd-b704-584321633c29
Commits

Reviewing files that changed from the base of the PR and between 65231b4 and db91a2e.

Files selected for processing: 4

  • quest/m1/ffi-refusals/moq-pin.md
  • quest/m2/crabx/binstall-tags.md
  • quest/m3/crabx-app.md
  • quest/m3/session-quic.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — documentation-only refresh of quest waits, with crabx-app now gated on first-publish.

Reviewed changes

  • moq-pin.md: records the 2026-11-18 measurement and links moq's fix quest.
  • binstall-tags.md: drops the merged-PR maintainer item; waits only on a release.
  • crabx-app.md: adds a ## Required link to first-publish.md, which exists.
  • session-quic.md: link and milestone moved from m3 to m4.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 8bc3ca7 Nov 19, 2026
8 checks passed
@kixelated
kixelated deleted the quest-plan/waiting-refresh branch November 19, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant