Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ffi/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1768,6 +1768,9 @@ and cgocheck2, and `tests/api.py`'s checks on a debug build of the newest CPytho
blocks end where they began; and it drives the C ABI from `tests/miri/api.rs` and the
protocol scripts from `tests/miri/protocol.rs` under Miri with strict provenance. The
protocol scripts' C driver runs under each sanitizer too.
On aarch64 the glue builds without outline atomics (`-Ctarget-feature=-outline-atomics`): the
instrumented `compiler_builtins` would answer the runtime's own atomics, before its shadow
exists, and crash it in `__asan_init`.
moq's crates export through `target/moq-ffi`, an empty library on each that `just ffi moq`
writes in place of moq-ffi's remainder. The export serves the host and each target
`just ffi moq-api` staged in `target/moq-api` from the same moq sources, and fails on a
Expand Down
11 changes: 10 additions & 1 deletion ffi/tests/fixtures.rs
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,15 @@ fn api_valgrind() {
fn sanitized_glue(sanitizer: &str) -> (PathBuf, Vec<String>) {
let api = api();
let dir = scratch().join("api").join(sanitizer);
// On aarch64, the runtime's atomics call `__aarch64_*` helpers, which the instrumented
// compiler_builtins would define and answer by reading a flag through a shadow check, before
// the runtime has mapped its shadow: every run would crash in `__asan_init` or `__tsan_init`.
// Without them the link takes the toolchain's own, which are not instrumented.
let outline = if cfg!(target_arch = "aarch64") {
" -Ctarget-feature=-outline-atomics"
} else {
""
};
let built = run(cargo()
.args(["build", "--quiet", "--locked", "-Zbuild-std", "--target", host()])
.arg("--manifest-path")
Expand All @@ -536,7 +545,7 @@ fn sanitized_glue(sanitizer: &str) -> (PathBuf, Vec<String>) {
.arg(dir.join("glue"))
.env(
"RUSTFLAGS",
format!("-D warnings -Zsanitizer={sanitizer} --print=native-static-libs"),
format!("-D warnings -Zsanitizer={sanitizer} --print=native-static-libs{outline}"),
));
let native: Vec<String> = String::from_utf8_lossy(&built.stderr)
.lines()
Expand Down
3 changes: 1 addition & 2 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ hold moq's pin open; the epic retired on 2026-11-16 once its children landed. Re
Decided with the maintainer on 2026-11-18, in the per-language audit of the exporter's
bindings and the translators: ✅ its findings join m1 where moq's switch uses them. Breaking
changes are children of [the exporter epic](/quest/m1/ffi-export/README.md) and land as
soon as possible; the rest are the [proofs](/quest/m1/ffi-proofs/README.md),
[speed](/quest/m1/ffi-speed/README.md), [rule cost](/quest/m1/ffi-rules/README.md), and
soon as possible; the rest are the [speed](/quest/m1/ffi-speed/README.md), [rule cost](/quest/m1/ffi-rules/README.md), and
[packaging](/quest/m1/ffi-packaging/README.md) epics, and the fixes and additions at this
milestone's top. Rejected: packaging in m2.
3 changes: 1 addition & 2 deletions quest/m1/ffi-export/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ Decided with the maintainer on 2026-11-18, in the per-language audit:
Kotlin (landed), Python (landed), Dart (landed), and docs.
Rejected: only the surface lock holding the pin; all of them after the pin.
- ✅ Work that changes no generated API, or only adds to it, stays out of this epic, as
decided on 2026-11-12: [proofs](/quest/m1/ffi-proofs/README.md),
[speed](/quest/m1/ffi-speed/README.md), [rule cost](/quest/m1/ffi-rules/README.md),
decided on 2026-11-12: [speed](/quest/m1/ffi-speed/README.md), [rule cost](/quest/m1/ffi-rules/README.md),
[packaging](/quest/m1/ffi-packaging/README.md), ordering and stream adapters (landed),
with [Swift streams of noncopyable objects](/quest/m1/swift-async-reader.md).
- Dropped: a per-function contract in place of the whole-header hash, since moq links
Expand Down
19 changes: 0 additions & 19 deletions quest/m1/ffi-proofs/README.md

This file was deleted.

28 changes: 0 additions & 28 deletions quest/m1/ffi-proofs/arm-sanitizers.md

This file was deleted.