Repository navigation
Have CI check that the changelog line ends with the pull request's number - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog step now fails unless the pull request adds a line to CHANGELOG.md that ends with its own number, such as
(#4).The number does not exist before the pull request is opened, so a pull request from AgentsAtWork is red on its first CI run. That is on purpose: it gives the pipeline's CI fix a real red required check to repair. The failed step's log names the number to add.
The rule is stated only in the CI step, not in the changelog's opening lines, so an agent does not try to guess the number ahead of time.