Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Reviewer's GuideData structuresExtend the shared alert-filter type with opt-in unresolved-only and creation-time-window fields used by the client and API.
APIAdd optional alert-list predicates for canonical unresolved statuses and
Document the new alert-list query parameters in the OpenAPI contract and advance its version.
Uses of the APITranslate the web alert-filter fields to the backend's query parameter names and omit fields that are not set.
ImplementationValidate drill-down query values consistently and select Alerts mode when a valid filter or explicit Alerts view is present.
UIRead and validate alert drill-down parameters at the Alerts route, then initialize the grid with the requested filters and view.
Make posture KPIs, severity and status segments, and their legend entries accessible links to matching alert-grid filters.
Hydrate the alert grid from live URL state, synchronize filter changes with the URL, and expose removable drill-down filters and clearer empty-state guidance.
Prevent saved defaults from overriding an explicit drill-down while preserving manual preset selection and accessible selected-state signaling.
ConfigurationAdvance the application version metadata and Helm chart version to the release carrying this feature.
DocumentationDocument posture drill-down links, filter semantics, URL behavior, and tenant scoping for console users.
Record the feature and navigation fixes in the unreleased changelog.
Refresh the release overview to describe the current release and retain the previous release notes.
Update the README version badge for the release.
TestsVerify the alert-list client sends the expected backend query names, preserves existing filters, and omits unset values.
Check endpoint filter predicates, opt-in behavior, and tenant scoping for posture drill-down requests.
Exercise the Alerts route and view across deep-link hydration, filter changes, history restoration, defaults, and unknown statuses.
Verify every posture counter and breakdown link has the expected filtered Alerts destination.
Check saved-view defaults are suppressed for explicit drill-downs without disabling manual preset selection.
Refresh generated documentation data and language-model indexes for the release.
Lock files and vendored codeRegenerate the web end-to-end browser coverage for alert posture drill-down navigation and filter persistence.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
c941ad8 to
aac95ec
Compare
## v23.5.3 — connector data completeness, community end to end Both defects were reported with failing tests by @pavancharak **against the shipped v23.5.2 tag** ([beenuar#1970](beenuar#1970), [beenuar#1971](beenuar#1971)); both fixed by first-time contributor @Varshith-Kali in [beenuar#1973](beenuar#1973). Fixing `main` fixes no tag — deployments pulling v23.5.2 keep silently losing rows on these paths until a release carries the fix, which is the bar for this patch. ### What the tag gets 1. **Checkpoint cursors compare instants, not text** — `…10:00:00.500Z` no longer drops against a `…10:00:00Z` cursor (`.` sorts before `Z`), offset-written cursors no longer drop later rows, the staged cursor names the newest instant with id tie-breaks, and an unparseable time keeps its row rather than losing it. 2. **Huntress / Cisco Secure Endpoint / Sophos Central stop losing scheduler-skipped intervals** — each persists an event-time cursor (Huntress on `sent_at`, preserving raise-once), overlaps one poll interval so a single skipped run is covered before any cursor exists, and skips are logged (`connector.scheduler.poll_skipped`). Overlap re-reads drop against the cursor: a re-request, never a duplicate or a loss. **Verified, not asserted:** 449 connector tests pass on the fix; the new instant-ordering suite fails 5/8 against the pre-fix tree. ### Mechanics `VERSION` 23.5.3 · CHANGELOG `[23.5.3]` cut (entries landed in beenuar#1974) · RELEASES.md TL;DR + What's-new · README badge · chart `7.24.3`/`v23.5.3` · `apps/web/package.json` · scoreboard refreshed (0.97, pinned to `420c707f`) · llms/openapi regenerated · changelog-frozen, single-version, readme-gates, papers, competitor gates green locally. **No breaking changes.** One observable note: the three converted connectors emit batches oldest-first by event time rather than page order. Tag goes on the merge commit; release.yml publishes; registry verified after. Co-authored-by: beenuar <beenuar@users.noreply.github.com>
Make Total, New (24h), Critical open, and severity/disposition counts navigate to a filtered alert grid, with query-driven tab selection and removable filter chips. Preserve canonical unresolved-status semantics and filter creation-time windows using the same column as the KPI. Add regression tests, OpenAPI schema updates, and documentation. Preserve unknown backend statuses' true labels in filtered results. Signed-off-by: Albert Hsieh <knowlet@users.noreply.github.com>
Synchronize filter changes with the URL and read validated live query parameters when history restores cached page props. Preserve explicit drilldowns over automatic saved-view defaults while allowing manual presets. Improve empty-state guidance and keyboard focus. Fix the link mock and SQLAlchemy collection assertions, test the alerts HTTP parameter contract, and add reload/history and saved-view regressions with an Unreleased changelog entry. Signed-off-by: Albert Hsieh <knowlet@users.noreply.github.com>
aac95ec to
a3f3a23
Compare
Summary
Make the SOC operations Alert posture counters and severity/status breakdowns open the matching alert grid. Keep drilldown filters consistent through chip removal, reloads and browser history, and prevent an automatic saved-view default from replacing an explicit drilldown.
Type of change
Related issues
No linked issue. This includes the review corrections for this feature branch.
Changes
unresolved_onlyandcreated_within_hoursAPI filters, using the same unresolved predicate andcreated_atcolumn as the statistics endpoint. Tenant scope remains bound to the authenticated principal.pageSize: 100call, omission of unset values and explicit false.mainat143c706(v23.5.3).Testing
The web unit/coverage, web build, and web lint/type-check CI jobs are green for head
a3f3a23. Remote Vitest confirms the same 1,303 passing tests and coverage percentages below. The complete Python test job is still running.Web validation used Node 22.23.5 and pnpm 8.15.1. The successful full coverage run used
--maxWorkers=2after default-concurrency runs competed with other validation processes; no test timeout or coverage threshold was changed. The existing 95 ESLint warnings are unchanged.The complete API suite ran with the CI command and locked service environment: 5,500 passed, 266 skipped, 1 xfailed, 18 failed. Every failure reproduces on pre-feature commit
7fcfa5d: eleven are caused by the inherited SOCKS proxy setting and seven by unavailable public DNS. All eleven proxy-related cases pass unchanged when onlyALL_PROXY/all_proxyare unset. The DNS-dependent cases remain a local environment limitation; this is not a clean full local API run.The real API/PostgreSQL checks cover statistics/list equivalence, unresolved and creation-time semantics, combined filters, pagination, time-bound validation, authentication and cross-tenant isolation. API lifespan workers and other microservices were not started, so this is focused integration, not a full-stack smoke run.
Browser verification steps
These cases are encoded in
apps/web/e2e/journeys/alerts-drilldown.spec.ts.Screenshots
Not captured in this revision. The Buyer journey CI job passed on the PR merge for head
a3f3a23, including all five new navigation/focus tests. Local Chromium startup was blocked by the execution policy's UNIX-socket restriction, so the browser assertions were executed in CI.Checklist
Eval harness
Before: Not applicable.
After: Not applicable.