You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Goal: Restore a green nightly Connections L0 Static Metadata Probe run on main without weakening the staleness gate.
The scheduled run https://github.com/knowlet/KiroCrew/actions/runs/43604135235 reported failed_count: 0 and all providers ok, but still exited 1. Job logs include STALE BASELINES: {'dropbox': '2026-09-08', 'huggingface': '2026-09-10'} and the report’s staleness.enforced=true block matches the workflow’s --fail-on-stale flag.
Why it matters
The nightly job is the only place --fail-on-stale is enforced (see .github/workflows/connections-l0.yml runbook and l0_probe._staleness). When baselines pass the 60-day L0_VERIFICATION_WARN_AGE_DAYS threshold, the workflow is meant to go red so someone re-records from live providers—not so maintainers learn to ignore a failing schedule.
Fixing unrelated flaky CI on this fork (see CI failure attribution below).
Fixing unrelated local-gate failures in test_registry_store_art_prewarm.py.
What changed (motivation → approach → change)
Symptom: nightly exit 1 with empty drift failures but nonempty staleness.overdue.
Root cause: dropbox and huggingfacel0_expectations.verified_on were older than 60 days; on 2026-11-14 the probe sets ok=False when --fail-on-stale and overdue is nonempty (see l0_probe.main around the staleness block).
Approach: run the documented recorder on a networked host: python3 -m kiro_crew.connections.l0_probe --record, which reached 29/29 providers and updated verified_on (and confirmed observed dcr/pkce unchanged).
Change: commit the resulting src/kiro_crew/connections/registry.json diff only.
Backwards compatibility
Compatible: registry schema and probe semantics are unchanged; only baseline capture dates (and implicit re-confirmation of observed flags) were refreshed.
Removes nothing: metadata-only refresh of existing provider entries.
Ran python3 -m kiro_crew.connections.l0_probe --record (29/29 reached, exit 0), then python3 -m kiro_crew.connections.l0_probe --fail-on-stale (exit 0). Reviewed git diff for registry.json: only l0_expectations.verified_on moved to 2026-11-14 for all refreshed providers; no issuer hand-edits.
Screenshots / video
N/A — no user-visible UI change.
Related Issues
Sibling sweep
Pattern harvest
CI failure attribution (scope boundary)
Fork main is pinned at ce07caac5a (2026-10-31). Upstream kirodotdev/KiroCrewmain is ahead (d2f22f259e, 2026-11-16); this PR intentionally targets the fork base only (registry.json on that tip).
Comparison method: for each red check on the latest PR workflow run, the failing test or step text was matched against this diff (only registry.json dates). Where knowlet/main has no recent successful full CI matrix, the same failure signatures are treated as pre-existing on the fork base, not introduced by this commit.
Check
PR root cause
Caused by this PR?
Main (ce07caac) comparison
Coverage Gate
Aggregator: backend-test=failure from unrelated shard reds
Playwright does not support chromium on ubuntu26.04-x64 (ubuntu-latest runner image)
No
Runner-image / Playwright support issue
Pod Boot Canary (Windows)
Required runner group 'kirocrew-runners-windows' not found
No
Fork infra: private runner group unavailable
GPT 6.1 Review
Job completes with empty steps (~0s); runner group kirocrew-runners not available on this fork
No
Same pattern on prior PR heads (84537f9d…)
In scope for this PR (fixed on head 4931ee92c7): commit metadata — author knowlet, DCO Signed-off-by only, no Co-authored-by; PR description stripped of third-party bot appendages and agent footer links.
Out of scope (pre-existing / fork infra): review lanes (Design/UX/Opus/First Principles), Dependency License Gate, internal-content-scan, and PR Readiness aggregation over the above — none are triggered or fixable by a metadata-only registry.json refresh without widening the PR.
Checklist
At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
Existing tests pass and new tests added for new functionality
No secrets, credentials, or internal references in the diff
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see CONTRIBUTING.md.
Summary by cubic
Refreshes the Connections L0 baseline capture dates in registry.json so the nightly probe's --fail-on-stale gate stops failing after dropbox and huggingface exceeded the 60-day warn threshold.
Re-records verified_on to 2026-11-14 for all 29 providers; observed dcr/pkce flags are unchanged.
Applies only to src/kiro_crew/connections/registry.json; registry schema and probe semantics are untouched.
Written for commit e7e00ec. Summary will update on new commits.
Summary by Sourcery
Refresh the Connections L0 provider baselines to restore successful nightly staleness validation.
Bug Fixes:
Refresh stale Connections L0 baseline capture dates so the nightly staleness check passes without changing probe behavior.
Chores:
Update existing provider metadata in the connection registry with newly verified baseline dates.
Summary by CodeRabbit
Updates
Connection verification dates have been refreshed to November 14, 2026, across the registry.
Notion’s manual revocation guidance remains available in its connection information.
Refresh the Connections L0 registry’s provider baseline capture dates so stale-baseline validation passes without changing probe behavior.
src/kiro_crew/connections/registry.json L2-30
Tips and commands
Interacting with Sourcery
Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!
The reason will be displayed to describe this comment to others. Learn more.
Approved: Cursor Bugbot was not present after the first check poll, so that signal was skipped. Remaining criteria are met for this date-only registry.json baseline refresh, with no applicable approval policy requiring human review.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This repository does not receive automatic reviews because it has fewer than 10 stars.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: a0609e32-07de-4f05-9ecb-8e84035c15f7
No actionable comments were generated in the recent review.
Walkthrough
The connection registry updates each connection’s verified_on date to 2026-11-14. The Notion entry no longer contains revoke_manual_path; its manual revocation instructions remain in gotcha_copy.
This is a metadata-only refresh of baseline verification dates so the nightly staleness gate passes again. No behavior change or defect was found. The failing CI checks come from repository settings and missing credentials, not from this change.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title uses the conventional 'chore:' prefix and names the change: refreshing the L0 baseline capture dates in the connections registry. The raw summary and objectives confirm that the PR only upda…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title uses the conventional 'chore:' prefix and names the change: refreshing the L0 baseline capture dates in the connections registry. The raw summary and objectives confirm that the PR only updates l0_expectations.verified_on dates to 2026-11-14 and reconfirms observed flags, so the title matches the main change. It is specific and concise, and the 'chore' type fits a data-refresh change. The title does not mention the removal of revoke_manual_path, which is a minor secondary edit and does not need to appear in the title.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 38d54933-9fef-4c0e-a956-a8ba74068c76
Commits
Reviewing files that changed from the base of the PR and between ce07caa and abde5b3.
Files selected for processing: 1
src/kiro_crew/connections/registry.json
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Auto-approved: Refreshes Connections L0 verified_on capture dates to 2026-11-14, restoring the nightly --fail-on-stale probe to green with observed dcr/pkce flags unchanged. Bounded metadata-only registry change: no schema, code, or semantic changes.
Re-record verified_on (and observed dcr/pkce where unchanged) for all
29 providers so the nightly probe's --fail-on-stale gate passes again
after dropbox and huggingface exceeded the 60-day warn threshold.
Signed-off-by: knowlet <knowlet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: Restore a green nightly Connections L0 Static Metadata Probe run on
mainwithout weakening the staleness gate.The scheduled run https://github.com/knowlet/KiroCrew/actions/runs/43604135235 reported
failed_count: 0and all providersok, but still exited 1. Job logs includeSTALE BASELINES: {'dropbox': '2026-09-08', 'huggingface': '2026-09-10'}and the report’sstaleness.enforced=trueblock matches the workflow’s--fail-on-staleflag.Why it matters
The nightly job is the only place
--fail-on-staleis enforced (see.github/workflows/connections-l0.ymlrunbook andl0_probe._staleness). When baselines pass the 60-dayL0_VERIFICATION_WARN_AGE_DAYSthreshold, the workflow is meant to go red so someone re-records from live providers—not so maintainers learn to ignore a failing schedule.Not a goal
scheduled-failure-watch.yml(separate owner decision).local-gatefailures intest_registry_store_art_prewarm.py.What changed (motivation → approach → change)
Symptom: nightly exit 1 with empty drift failures but nonempty
staleness.overdue.Root cause:
dropboxandhuggingfacel0_expectations.verified_onwere older than 60 days; on 2026-11-14 the probe setsok=Falsewhen--fail-on-staleand overdue is nonempty (seel0_probe.mainaround the staleness block).Approach: run the documented recorder on a networked host:
python3 -m kiro_crew.connections.l0_probe --record, which reached 29/29 providers and updatedverified_on(and confirmed observed dcr/pkce unchanged).Change: commit the resulting
src/kiro_crew/connections/registry.jsondiff only.Backwards compatibility
Compatible: registry schema and probe semantics are unchanged; only baseline capture dates (and implicit re-confirmation of observed flags) were refreshed.
Removes nothing: metadata-only refresh of existing provider entries.
Tests
python3 -m pytest -n0 test/test_connections_l0_probe.py test/test_connections_registry.py→ 232 passedpython3 -m kiro_crew.connections.l0_probe --fail-on-stalelocally → exit 0,staleness.overdue: {}Manual verification
Ran
python3 -m kiro_crew.connections.l0_probe --record(29/29 reached, exit 0), thenpython3 -m kiro_crew.connections.l0_probe --fail-on-stale(exit 0). Reviewedgit diffforregistry.json: onlyl0_expectations.verified_onmoved to2026-11-14for all refreshed providers; no issuer hand-edits.Screenshots / video
N/A — no user-visible UI change.
Related Issues
Sibling sweep
Pattern harvest
CI failure attribution (scope boundary)
Fork
mainis pinned atce07caac5a(2026-10-31). Upstreamkirodotdev/KiroCrewmainis ahead (d2f22f259e, 2026-11-16); this PR intentionally targets the fork base only (registry.jsonon that tip).Comparison method: for each red check on the latest PR workflow run, the failing test or step text was matched against this diff (only
registry.jsondates). Whereknowlet/mainhas no recent successful full CI matrix, the same failure signatures are treated as pre-existing on the fork base, not introduced by this commit.ce07caac) comparisonbackend-test=failurefrom unrelated shard redsmainpushtest_session_markdown.py::test_a_condition_one_opener_is_closed_as_the_parser_reads_it[long-s]test_terminal_handler_pty_integration.py(2× PROMPT_COMMAND integration tests)test_session_markdowncase as Linux shard 4Playwright does not support chromium on ubuntu26.04-x64(ubuntu-latestrunner image)Required runner group 'kirocrew-runners-windows' not foundkirocrew-runnersnot available on this fork84537f9d…)In scope for this PR (fixed on head
4931ee92c7): commit metadata — authorknowlet, DCOSigned-off-byonly, noCo-authored-by; PR description stripped of third-party bot appendages and agent footer links.Out of scope (pre-existing / fork infra): review lanes (Design/UX/Opus/First Principles), Dependency License Gate,
internal-content-scan, and PR Readiness aggregation over the above — none are triggered or fixable by a metadata-onlyregistry.jsonrefresh without widening the PR.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see CONTRIBUTING.md.
Summary by cubic
Refreshes the Connections L0 baseline capture dates in
registry.jsonso the nightly probe's--fail-on-stalegate stops failing afterdropboxandhuggingfaceexceeded the 60-day warn threshold.verified_onto2026-11-14for all 29 providers; observed dcr/pkce flags are unchanged.src/kiro_crew/connections/registry.json; registry schema and probe semantics are untouched.Written for commit e7e00ec. Summary will update on new commits.
Summary by Sourcery
Refresh the Connections L0 provider baselines to restore successful nightly staleness validation.
Bug Fixes:
Chores:
Summary by CodeRabbit