Repository navigation
Return an error instead of panicking on edges shared by more than two faces - #16
Merged
Merged
Conversation
… faces edge_topology counted edges as distinct vertex pairs but paired sorted entries two at a time, so a pair occurring three or more times overran e2v (index out of bounds). It now returns an error for such input, like the other malformed-input checks. Adds a test with two tetrahedra sharing an edge. Fixes komietty#14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you for your PR. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
edge_topologynow checks the sorted half-edge list for any vertex pair that occursthree or more times and returns
Err("Input mesh has an edge shared by more than two faces."), before the counting andpairing loops that assume at most two. Valid (2-manifold or bordered) input takes the
same path as before; this only turns a panic into an error.
Adds
edge_shared_by_four_faces_is_an_error_not_a_panictosrc/tests.rs(twotetrahedra sharing an edge), which panics on
mainand passes with this change.Diff (src/manifold/hmesh.rs):
🤖 Generated with Claude Code