Support system revamp - #45
Open
kparasch wants to merge 14 commits into
Open
Conversation
… and their propagations along the different layers. A support is still defined by the two endpoints and its roll rotates the support around the axis connecting these two points. The pySC convention is the AT convention and proper conversion is made to the XSuite convention when passing misalignments to XSuite lattices.
…support was assumed straight through its endpoints which also meant it straightened every element it supports through its reference frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch revamps the support-system misalignment model to resolve support and element poses in 3D, using element-center reference positions and matrix-composed rotations instead of scalar yaw/pitch interpolation. It is based on scipy.spatial.transform.Rotation class.
Allows also to model shrinkage/expansion of supports through the appropriate dz transformations.
Key changes: