Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Extend BBA measurement to support simultaneous H/V scans
Summary
This PR adds an
HVBBA measurement mode that scans horizontal and vertical correctors together and stores the result in a dedicatedHV_dataobject. The mode emits new BBA status codes, supports live IOS updates, can be analyzed into separate horizontal and verticalBBAAnalysisresults, and is saved through the publicmeasure_bba()wrapper.Changes
BBACode.HORIZONTAL_VERTICAL,HORIZONTAL_VERTICAL_DONE, andHORIZONTAL_VERTICAL_IOS_READY.HV_datatoBBA_Measurement.one_plane_loop()to handleplane="HV"by stepping both correctors at each scan point.correctorstored as a byte-string arraydk0landinitial_k0lstored as numeric arraysmagnet_typestored as its string valuemeasure_bba(..., plane="HV")save handling.measure_bba(..., skip_cycle=True)so it is passed through toBBA_Measurement.generate().BBAAnalysis.analyze(HV_data)return separate H/V analysis results.