Repository navigation
fix: support PHP 8.7 VM interrupts - #411
Draft
realFlowControl wants to merge 1 commit into
Draft
realFlowControl wants to merge 1 commit into
realFlowControl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHP 8.7 master removed
zend_atomic_boolandzend_atomic_bool_store()in favor of standard C atomics (php/php-src#23927), breaking the build.Runtime::kill()andFuture::cancel()through one version-aware helper.atomic_store()on PHP 8.7+, preserve Zend atomics on PHP 8.2–8.6 and the existing assignment on PHP 8.0–8.1, without redefining Zend symbols.Testing
Local macOS ARM64 ZTS builds:
All 10 selected kill/cancellation tests pass on PHP 8.7, both without and with OPcache. Clang-format 20 and
git diff --checkpass.The same four failures reproduce on unmodified
developat c08caeb with PHP 8.6:tests/base/021.phpt,051.phpt, and063.phpthave deprecation-output mismatches;tests/closures/010.phptfails closure binding and reports heap corruption on PHP 8.7. These are outside this build fix.Existing compiler warnings are unchanged. PHP 8.0–8.2, PHP 8.5 ZTS, and Windows were not tested.
GitHub Actions validation is blocked: jobs are not starting because the repository owner's account is locked due to a billing issue.