Repository navigation
Harden plugin catalog validation and release signing - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The previous validator coupled duplicate checks to successful external downloads, continued after schema failures, deleted persistent architecture-named directories, and processed unbounded archives. The release workflow then signed a recursive DLL glob while downloaded third-party DLLs remained in the workspace. A crafted catalog or archive could therefore bypass local checks, consume excessive resources, traverse paths, or place third-party binaries in the signing scope.
Impact
Offline review is now deterministic and does not contact package hosts. Online CI retains URL, package hash and DLL version validation while failing safely on hostile responses. The three plugin catalog JSON files are unchanged; documentation changes only escape catalog text safely.
Validation
py -3.12 -m unittest discover -s tests -v: 29 passedpython validator.py all --offline: passed for 431 entriesruff check,ruff format --check, Bandit, Python compile, JSON Schema, YAML, PowerShell and MSBuild XML checks: passedExternal package availability, current remote bytes and manifest hash freshness were intentionally not re-fetched during the local audit; the online architecture jobs remain responsible for those checks.