Repository navigation
neurasp - #312
Merged
Merged
neurasp#312
Conversation
Contributor
|
Hola @jorgefandinno , I wait with reviwing for a PR, right..? |
Contributor
Author
|
You can merge |
jorgefandinno
requested review from
rkaminsk and
tortinator
and
a lite review from Copilot
September 25, 2026 16:06
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
The dependency constraint must also cover local setup and enforce bibtexparser version 1.2 or newer.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds the NeurASP citation and constrains CI to a compatible bibtexparser release.
Changes:
- Adds the NeurASP IJCAI 2020 bibliography entry.
- Constrains the CI dependency below version 2.
| File | Summary |
|---|---|
krr.bib |
Adds the NeurASP citation. |
.github/鈥媤orkflows/鈥媘ain.yml |
Constrains the CI parser dependency. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
Update both dependency constraints to require bibtexparser >=1.2,<2.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
Resolved since last review (1)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tortinator
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request also updates the workflow that failed because of an update to
bibtexparsermakespipnow install the incompatible versionv2.