[Ahmad-Faraj]

Membership Request for @Ahmad-Faraj

This PR adds Ahmad-Faraj to the org.kubeflow.members list.

I contribute to kubeflow/mcp-server, kubeflow/trainer and kubeflow/sdk, mostly correctness fixes.

Merged

• fix(core): report the package version in serverInfo mcp-server#262 reports the package version in serverInfo
• fix(core): report tool errors with isError mcp-server#282 reports tool errors with isError
• fix(trainer): accept dotted runtime names in get_runtime and list_training_jobs mcp-server#233 accepts dotted runtime names in get_runtime and list_training_jobs

Open

• fix(controller): keep default leader election durations when unset trainer#4131 keeps the default leader election durations when the config leaves them unset (#4130)
• fix(framework): set the logger in the Coscheduling and Volcano plugins trainer#4149 sets the logger in the Coscheduling and Volcano plugins (#4148)
• fix(trainer): report Running for a resumed TrainJob sdk#804 reports Running for a resumed TrainJob
• fix: keep events that only set eventTime in get_job_events sdk#842 keeps events that only set eventTime in get_job_events

Reviews

• feat: KEP-2839 Dynamic LLM Trainer Framework trainer#3930 (KEP-2839), with a two-pod run of the TRL runtime on kind
• fix(core): fall back to keyword search when the embedding model can't load mcp-server#254

Sponsors

• @abhijeet-dhumal
• @jaiakash

Test Output

============================= test session starts =============================
platform win32 -- Python 3.13.9, pytest-9.0.2, pluggy-1.6.0
rootdir: E:\oss\orgs\kubeflow\acls-src
collected 1 item

github-orgs\test_org_yaml.py .                                           [100%]

============================== 1 passed in 0.11s ==============================

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[google-oss-prow]

Hi @Ahmad-Faraj. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhijeet-dhumal]

Thank you @Ahmad-Faraj for your contributions! 🚀
/lgtm

[jaiakash]

Thanks @Ahmad-Faraj
/lgtm

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[juliusvonkohout]

Please use a proper rebase to master

[Ahmad-Faraj]

@juliusvonkohout rebased.