Repository navigation
fix: improve TrainerClient code quality and documentation - #645
vjkumar2756 wants to merge 1 commit into
Conversation
Signed-off-by: vjkumar2756 <vjkumar2756@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
lntutor
left a comment
There was a problem hiding this comment.
The proposed get_runtime_packages(...) -> str annotation does not match the backend implementations. LocalProcessBackend.get_runtime_packages() returns local_runtime.trainer.packages, and kubeflow/trainer/backends/localprocess/backend_test.py explicitly asserts it is a list; the container and Kubernetes implementations print their results and return None. Please use the verified cross-backend return type (for example list[str] | None, if package entries are strings) or leave this method unannotated until the backend interface is made consistent. Also add a delegation test for TrainerClient so the public annotation is protected by the actual API behavior.
|
@vjkumar2756 Sorry for the delay, can you rebase this PR, so we can merge it? |
Description
This PR addresses #640 by improving the
TrainerClientimplementation.Changes made
if not backend_configwithif backend_config is Nonefor more explicitNonechecking.Testing
Fixes #640