Repository navigation
Conversation
DataCacheInitializer only checked that the cache:// path split into two components, so cache://schema/, cache:///table and cache:/// passed client-side validation. The Trainer dataset initializer rejects these at runtime, which meant a malformed URI was only caught after the TrainJob was submitted. Require both components to be non-empty so the error is raised on the client. Fixes kubeflow#881 Signed-off-by: Karman Singh Talwar <flyingoffkarmansinghtalwar@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Validates that both the schema and table components in
DataCacheInitializer.storage_uriare non-empty.Previously, URIs such as
cache://schema/,cache:///table, andcache:///could pass client-side validation even though the downstream Trainer dataset initializer rejects missing schema or table names.The validation now rejects empty components before job submission. Valid URIs such as
cache://schema/tableare still accepted, and the existing error message is unchanged.Tests
cache://schema/,cache:///table, andcache:///to the existing parametrizedtest_data_cache_initializer. These three cases fail without the fix and pass with it.uv run pytest -q kubeflow/trainer/types/types_test.py: 14 passed.uv run pytest -q kubeflow: 700 passed.uv lock --check,ruff check,ruff format --check, andty check kubeflow/hub(the steps ofmake verify): all passed.Related issue
Closes #881