Repository navigation
chore: migrate Pydantic class-based Config to ConfigDict - #891
Open
MUKUL-PRASAD-SIGH wants to merge 1 commit into
Open
MUKUL-PRASAD-SIGH wants to merge 1 commit into
MUKUL-PRASAD-SIGH wants to merge 1 commit into
Conversation
Pydantic v2 deprecated the class-based `Config` (PydanticDeprecatedSince20) and will remove it in Pydantic v3. Replace the three remaining usages in KubernetesBackendConfig, LocalBackendStep and LocalBackendJobs with `model_config = ConfigDict(arbitrary_types_allowed=True)`. No behaviour change: each model keeps arbitrary_types_allowed=True. Signed-off-by: MUKUL PRASAD <mukulprasad958@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CqSS2VmaiPUMZ8AN2rBwLp
Author
|
/assign @andreyvelich |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pydantic v2 deprecated the class-based
Config(PydanticDeprecatedSince20), and it will be removed in Pydantic v3. This PR migrates the three remaining usages in the package tomodel_config = ConfigDict(...):kubeflow/common/types.py:KubernetesBackendConfigkubeflow/trainer/backends/localprocess/types.py:LocalBackendStep,LocalBackendJobsThere is no behaviour change: each model keeps
arbitrary_types_allowed=True.These warnings are hidden in the test suite by the
filterwarningsentry inpyproject.toml, but users importing the SDK still see them. After this change the package itself no longer emitsPydanticDeprecatedSince20. I left thepyproject.tomlfilter untouched to keep this PR minimal.Testing:
uv run pytest -W error::pydantic.warnings.PydanticDeprecatedSince20 kubeflow/common kubeflow/trainer/backends/localprocess: fails at collection onmain, 37 passed with this changeuv run pytest ./kubeflow/: 697 passeduv lock --check,ruff check,ruff format --check kubeflow,ty check kubeflow/hub(themake verifysteps) andpre-commiton the changed files: all passingWhich issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #890
Checklist:
AI disclosure: Per the Kubeflow AI policy, this change was prepared with AI assistance (Claude Code) and reviewed and tested locally before submission.